OSX/CI: phonon fails to INSTALL on branch master

2014-11-26 Thread Marko Käning
Phonon built fine, but failed to install for some reason, as a file must be missing: --- -- Installing: /Users/marko/WC/KDECI-builds/phonon/local-inst/opt/kde/install/darwin/mavericks/clang/kf5-qt5/kdesupport/phonon/phonon/inst/include/phonon4qt5/phonon/VolumeSlider CMake Error at includes/cmak

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2014-11-26 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121263/#review70996 --- I actually would prefer no such hack in the public headers. If

Re: Review Request 121262: make kservice_desktop_to_json warning an author_warning

2014-11-26 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121262/#review70995 --- Ship it! Ship It! - Alexander Richardson On Nov. 27, 2014,

Re: Review Request 121265: Make modified flag work for KMainWindow::setCaption(QString, bool)

2014-11-26 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121265/#review70989 --- src/kmainwindow.cpp

Review Request 121265: Make modified flag work for KMainWindow::setCaption(QString, bool)

2014-11-26 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121265/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Re: Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2014-11-26 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121263/ --- (Updated Nov. 27, 2014, 1:15 a.m.) Review request for KDE Frameworks, Chr

Review Request 121263: Prevent API abuse of calling setters on temporary objects.

2014-11-26 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121263/ --- Review request for KDE Frameworks, Christoph Cullmann, Dominik Haumann, and

Review Request 121262: make kservice_desktop_to_json warning an author_warning

2014-11-26 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121262/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Review Request 121258: Restart KDirWatch after a failed delete operation

2014-11-26 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121258/ --- Review request for KDE Frameworks. Repository: kio Description ---