Re: Review Request 121238: Add support for more multimedia keys

2014-11-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121238/ --- (Updated Nov. 25, 2014, 12:13 a.m.) Status -- This change has been m

Re: Review Request 121238: Add support for more multimedia keys

2014-11-24 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121238/#review70886 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 25, 2014, 1

Review Request 121238: Add support for more multimedia keys

2014-11-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121238/ --- Review request for KDE Frameworks and Martin Gräßlin. Repository: kwindow

Re: Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/ --- (Updated Nov. 24, 2014, 7:53 p.m.) Review request for KDE Frameworks and

Review Request 121233: Do not drop ASN passed to KRun when executing desktop files

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121233/ --- Review request for KDE Frameworks. Repository: kio Description ---

Jenkins build became unstable: kservice_master_qt5 #204

2014-11-24 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121197/#review70863 --- FWIW i've tried this patch and it fixes the firefox problem fo

Review Request 121230: Fix passing of DESKTOP_STARTUP_ID to child process in kioexec

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121230/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-24 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121197/#review70858 --- Ship it! Ship It! - Thomas Lübking On Nov. 24, 2014, 3:06

Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-24 Thread Thomas Lübking
> On Nov. 24, 2014, 2:01 nachm., Martin Gräßlin wrote: > > after checking > > https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ : > > this is a BC compatible change, but not SC. Seems like one needs to use a > > different method name :-( > > Thomas Lübking wrote: > Wh

Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-24 Thread Martin Gräßlin
> On Nov. 24, 2014, 3:01 p.m., Martin Gräßlin wrote: > > after checking > > https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ : > > this is a BC compatible change, but not SC. Seems like one needs to use a > > different method name :-( > > Thomas Lübking wrote: > Wher

Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-24 Thread Thomas Lübking
> On Nov. 24, 2014, 2:01 nachm., Martin Gräßlin wrote: > > after checking > > https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ : > > this is a BC compatible change, but not SC. Seems like one needs to use a > > different method name :-( > > Thomas Lübking wrote: > Wh

Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-24 Thread Thomas Lübking
> On Nov. 24, 2014, 2:01 nachm., Martin Gräßlin wrote: > > after checking > > https://techbase.kde.org/Policies/Binary_Compatibility_Issues_With_C++ : > > this is a BC compatible change, but not SC. Seems like one needs to use a > > different method name :-( Where did you read this? void

Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121197/ --- (Updated Nov. 24, 2014, 4:06 p.m.) Review request for KDE Frameworks. B

Re: Review Request 121172: Move libgit2-related macro defs into config.h

2014-11-24 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121172/ --- (Updated Nov. 24, 2014, 2:31 p.m.) Status -- This change has been di

Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121197/#review70849 --- after checking https://techbase.kde.org/Policies/Binary_Compa

Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121197/ --- (Updated Nov. 24, 2014, 2:38 nachm.) Review request for KDE Frameworks.

Re: Review Request 120257: Add support for initial mapping state of WM_HINTS

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120257/ --- (Updated Nov. 24, 2014, 9:35 a.m.) Status -- This change has been ma

Re: Re: pkexec vs kdesu

2014-11-24 Thread Martin Gräßlin
On Sunday 23 November 2014 17:14:02 Harald Sitter wrote: > On Sun, Nov 23, 2014 at 4:50 PM, David Edmundson > > wrote: > > You will probably get massively different behaviour regarding your env. > > > > pkexec won't copy anything, sudo will. > > Without $DISPLAY graphical apps are out. > > Sure

Re: Review Request 120917: Fix memory leak for NETWinInfoPrivate::client_machine

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120917/ --- (Updated Nov. 24, 2014, 9:28 a.m.) Status -- This change has been ma

Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-24 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121197/ --- (Updated Nov. 24, 2014, 9:09 a.m.) Review request for KDE Frameworks, kwi