Jenkins build is back to stable : kservice_master_qt5 #203

2014-11-23 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120199: Implement KPluginTrader::query() using KPluginLoader::findPlugins()

2014-11-23 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120199/ --- (Updated Nov. 24, 2014, 1:11 a.m.) Status -- This change has been ma

Re: Review Request 121210: Provide an accessible name for KLed

2014-11-23 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121210/#review70830 --- Ship it! Ship It! - Christoph Feck On Nov. 23, 2014, 4:09

Re: kdirlister test is too coupled

2014-11-23 Thread Albert Astals Cid
El Diumenge, 23 de novembre de 2014, a les 22:37:33, David Faure va escriure: > On Sunday 23 November 2014 22:17:27 Albert Astals Cid wrote: > > kdirlister test is highly dependant on run order, seems it needs > > testOpenUrl to always have run otherwise it always fails > > > > i.e. > > > > ./a

Re: kdirlister test is too coupled

2014-11-23 Thread David Faure
On Sunday 23 November 2014 22:17:27 Albert Astals Cid wrote: > kdirlister test is highly dependant on run order, seems it needs testOpenUrl > to always have run otherwise it always fails > > i.e. > ./autotests/kdirlistertest testRefreshRootItem Yes, just do ./autotests/kdirlistertest testOpenUr

kdirlister test is too coupled

2014-11-23 Thread Albert Astals Cid
kdirlister test is highly dependant on run order, seems it needs testOpenUrl to always have run otherwise it always fails i.e. ./autotests/kdirlistertest testRefreshRootItem I tried doing a quick refactor of renaming testOpenUrl to init() but then some other stuff failed. Can someone with mo

Jenkins build became unstable: kio_master_qt5 #438

2014-11-23 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121118: KEmoticons: Add a KEmoticonsIntegrationPlugin for KTextToHTML from KCoreAddons

2014-11-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121118/#review70817 --- autotests/CMakeLists.txt

Re: Review Request 121175: KCodecs: Import KEmailAddress class from email address parsing and validation from KPimUtils

2014-11-23 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121175/#review70816 --- Problem: I don't think anyone looking for this functionality w

Re: pkexec vs kdesu

2014-11-23 Thread Harald Sitter
On Sun, Nov 23, 2014 at 4:50 PM, David Edmundson wrote: > You will probably get massively different behaviour regarding your env. > > pkexec won't copy anything, sudo will. > Without $DISPLAY graphical apps are out. Surely not an unsolvable problem. Clearly wayland fixes this ;) > That said, pol

Re: Review Request 121210: Provide an accessible name for KLed

2014-11-23 Thread José Millán Soto
> On Nov. 22, 2014, 6:31 p.m., Christoph Feck wrote: > > I think the updateAccessibleName() should also be called from the > > constructors? Otherwise, the initial name (for which even a constructor > > exists), is never announced. In the new version of the patch, it's called in the constructo

Re: Review Request 121210: Provide an accessible name for KLed

2014-11-23 Thread José Millán Soto
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121210/ --- (Updated Nov. 23, 2014, 4:09 p.m.) Review request for KDE Accessibility,

Re: pkexec vs kdesu

2014-11-23 Thread David Edmundson
You will probably get massively different behaviour regarding your env. pkexec won't copy anything, sudo will. Without $DISPLAY graphical apps are out. That said, polkit is totally the way forward and anything using kdesu should be ported. What does still use it? David __

pkexec vs kdesu

2014-11-23 Thread Harald Sitter
hola! how about we replace all of our kdesu usage with pkexec. pkexec has a lovely nice dialog, is backed by polkit, very secure, very nice, totally cool. also, absolutely sufficient. thoughts? HS ___ Kde-frameworks-devel mailing list Kde-frameworks-de

Review Request 121218: Allow using new style connect syntax with KStandardAction::create()

2014-11-23 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121218/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti