Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-21 Thread Martin Gräßlin
> On Nov. 21, 2014, 4:21 nachm., Thomas Lübking wrote: > > src/kstartupinfo.cpp, line 1010 > > > > > > Should this not rather be ::getTimestamp() unconditionally? > > > > This is supposed to be a hint w

Re: Review Request 121198: Drop incorrect warnings when using KXMessages without QX11Info

2014-11-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121198/ --- (Updated Nov. 22, 2014, 7:18 a.m.) Status -- This change has been ma

Re: Review Request 121078: Fix exports.

2014-11-21 Thread Andrius da Costa Ribas
> On Nov. 20, 2014, 9 a.m., Luca Beltrame wrote: > > Actually it's still broken: I didn't notice because I did not build tests: > > > > > > /srv/jenkins/workspace/kde-baseapps_frameworks_qt5/konqueror/src/konqapplication.h:28:46: > > error: expected initializer before ‘:’ token > > > > The l

Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-21 Thread Martin Gräßlin
> On Nov. 21, 2014, 4:21 nachm., Thomas Lübking wrote: > > src/kstartupinfo.cpp, line 1010 > > > > > > Should this not rather be ::getTimestamp() unconditionally? > > > > This is supposed to be a hint w

Re: Review Request 120969: Fix build on OSX due to missing XDR functions.

2014-11-21 Thread Mathias Tillman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120969/ --- (Updated Nov. 21, 2014, 4:40 p.m.) Status -- This change has been ma

Re: Review Request 121198: Drop incorrect warnings when using KXMessages without QX11Info

2014-11-21 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121198/#review70740 --- Ship it! Ship It! - Thomas Lübking On Nov. 21, 2014, 11:04

Re: Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-21 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121197/#review70739 --- src/kstartupinfo.cpp

Review Request 121198: Drop incorrect warnings when using KXMessages without QX11Info

2014-11-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121198/ --- Review request for KDE Frameworks, kwin and Plasma. Bugs: 340310 http

Review Request 121197: KStartupInfo: use QX11Info::getTimestamp if appUserTime is 0

2014-11-21 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121197/ --- Review request for KDE Frameworks, kwin and Plasma. Repository: kwindowsy