Re: Review Request 121173: Use correct version in kbuildsycoca5 executable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121173/#review70632 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 18, 2014, 1

Review Request 121173: Use correct version in kbuildsycoca5 executable

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121173/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/#review70616 --- Ship it! src/kcodecs.h

Review Request 121172: Move libgit2-related macro defs into config.h

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121172/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: kte

Re: Review Request 120760: Fix bug #340212: incorrect soft-tabs alignment after beginning-of-line

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120760/ --- (Updated Nov. 18, 2014, 6:55 p.m.) Status -- This change has been ma

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121113/#review70598 --- Ship it! Ship It! - Marco Martin On Nov. 13, 2014, 6:24 p.

Re: Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121086/#review70583 --- thumbnail/CMakeLists.txt

Re: Review Request 120155: Correctly load non-square icons in KIconLoader

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120155/ --- (Updated Nov. 18, 2014, 2:38 p.m.) Status -- This change has been di

Re: Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121094/ --- (Updated Nov. 18, 2014, 2:37 p.m.) Review request for KDE Frameworks and

Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121047/ --- (Updated Nov. 18, 2014, 2:31 p.m.) Review request for KDE Frameworks, KDE

Re: Review Request 121047: KCodecs: add MIME codecs, improve {encode, decode}RFC2047String()

> On Nov. 16, 2014, 10:05 p.m., David Faure wrote: > > src/kcodecsbase64.h, line 161 > > > > > > What a weird codec name?? Looks weird, but is correct. This is the name of the encoding that appears in MIME-enco

Re: Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/#review70581 --- Ship it! Looks sane to me, also solves a real-world problem.

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated Nov. 18, 2014, 11:23 a.m.) Status -- This change has been m

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/#review70575 --- Ship it! Ship It! - Christoph Feck On Nov. 17, 2014, 4:48

Re: Review Request 121153: Restore filedialog show() functionality for modal dialogs

> On Nov. 18, 2014, 12:33 a.m., Jeremy Whiting wrote: > > I tested this here and FileDialog qml still hangs the ui with this patch. > > (though at least the dialog appears) Yes, QML still hangs, not sure why though. Looking into it. - Martin -