Re: Review Request 121153: Restore filedialog show() functionality for modal dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121153/#review70564 --- I tested this here and FileDialog qml still hangs the ui with

Re: Review Request 121163: Also allow absolute filepaths for configfile parameter.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/ --- (Updated Nov. 17, 2014, 11:28 p.m.) Status -- This change has been m

OSX/CI: gwenview build fails on branch master

1) Kdcraw is not found, although project libkdcraw is installed on the OSX/CI system. 2) I am wondering also why gwenview fails building on OSX for the not installed optional package Exiv2. --- . . . -- Could NOT find Exiv2 (missing: EXIV2_LIBRARY EXIV2_INCLUDE_DIR) (Required is at least ve

Jenkins build is back to normal : ktexteditor_master_qt5 #724

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121160: Add libgit2 compile-time check for threads support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/#review70555 --- src/utils/kateglobal.cpp

Re: Review Request 121153: Restore filedialog show() functionality for modal dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121153/#review70553 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 17, 2014, 5

Re: Review Request 121160: Add libgit2 compile-time check for threads support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/ --- (Updated Nov. 17, 2014, 10:45 p.m.) Status -- This change has been m

Re: Review Request 121163: Also allow absolute filepaths for configfile parameter.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/#review70545 --- Ship it! Works for me :) - Albert Astals Cid On nov. 17, 2

Review Request 121163: Also allow absolute filepaths for configfile parameter.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121163/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstu

Re: Review Request 121160: Add libgit2 compile-time check for threads support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/#review70541 --- Ship it! Ship It! - Christoph Cullmann On Nov. 17, 2014, 8

Re: Review Request 121160: Add libgit2 compile-time check for threads support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/#review70538 --- Ship it! This does indeed work on OSX/CI. - Marko Käning O

Review Request 121160: Add libgit2 compile-time check for threads support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121160/ --- Review request for KDE Frameworks and Christoph Cullmann. Repository: kte

Review Request 121153: Restore filedialog show() functionality for modal dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121153/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated nov. 17, 2014, 4:48 après-midi) Review request for KDE Framework

Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121098/ --- (Updated Nov. 17, 2014, 9:39 a.m.) Status -- This change has been di

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

> On Nov. 17, 2014, 3:24 p.m., Christoph Feck wrote: > > src/ksplittercollapserbutton.cpp, line 276 > > > > > > Please pass at least a QStyleOption to pixelMetric(). For some styles, > > the metric depends on th

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

> On nov. 17, 2014, 3:24 après-midi, Christoph Feck wrote: > > src/ksplittercollapserbutton.cpp, line 276 > > > > > > Please pass at least a QStyleOption to pixelMetric(). For some styles, > > the metric depends

Re: Review Request 121145: A button which appears on the side of a splitter handle and allows easy collapsing of the widget on the opposite side

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121145/ --- (Updated Nov. 17, 2014, 3:39 p.m.) Review request for KDE Frameworks, Chr

Re: [RFC] [kservice] KPluginMetadata indexing

Hi David, On Sunday, November 16, 2014 18:10:27 David Faure wrote: > Cool that you're looking into this. > > On Thursday 06 November 2014 03:44:58 Sebastian Kügler wrote: > > - a small tool called kplugin-update-index collects the json metadata from > > the plugins, and puts the list of plugins

Re: [RFC] [kservice] KPluginMetadata indexing

Hi Milian, Thanks for looking at my patches. Since the branch, as you noticed, is quite contaminated with unrelated changes, merging in and out stuff, I'll push these changes to a cleaned branch, and will address the issues you pointed out. I'll post a new RR then. On Sunday, November 16, 2014

Re: Review Request 121113: Use Qt's method of blocking for component completion rather than our own

> On Nov. 14, 2014, 12:16 p.m., Marco Martin wrote: > > hm, i don't really like it. > > is it working around a problem in particular? > > if i try the patch, the difference during startup (or just duringopening a > > popup on the first time) is pretty noticeable like, the wallpaper appearing >

Re: Supporting MSVC2010 in ktexteditor framework

> > > - initializer lists > > Unsupported on VS2012. > > Again, seems to be that CTP thingie, damn. (though, again, the initializer > lists should also be tested - maybe they also work if the number of arguments > is less than ...) I've had problems with them even on VS2013, like return QHash({

Re: Supporting MSVC2010 in ktexteditor framework

El domingo, 16 de noviembre de 2014, Ivan Čukić escribió: > Hi, > > The topic of increasing the compiler versions we require might have been > started for the specific issue one of the frameworks had, but I think it > shouldn't have died out when the issue in question got patched. > The issue in

Re: Problem with kdeinit and StartupInfo

On Sat, Oct 4, 2014 at 1:47 PM, Alex Merry wrote: > On 2014-10-04 10:08, David Faure wrote: > >> On Friday 03 October 2014 12:15:09 Alex Merry wrote: >> >>> Note that KDBusService has a known limitation where it just doesn't work >>> with startup notifications in unique mode - the necessary infor

Re: Supporting MSVC2010 in ktexteditor framework

> El 17/11/2014, a las 06:03, Ivan Čukić escribió: > >> On Monday, 17 November 2014 07:33:00 Kevin Ottens wrote: >>> On Sunday 16 November 2014 18:01:04 Ivan Čukić wrote: >>> - initializer lists >> Unsupported on VS2012. > > Again, seems to be that CTP thingie, damn. (though, again, the initial

Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

> On Nov. 15, 2014, 12:16 a.m., Martin Klapetek wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, lines 301-303 > > > > > > Looking at QDialog docs, it says > > > > "modal : bool > > This

Re: Supporting MSVC2010 in ktexteditor framework

> Yeah, it looks like I've been looking at the CTP from November 2012 - for > VS11 [1]. It would be awesome if somebody who has VS11 actually > investigated this. Namely, the 11.0 proper should support variadics up to > some number of arguments (yes, sounds really daft and hackish). If true, it >

Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

> On Nov. 15, 2014, 12:16 a.m., Martin Klapetek wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, lines 301-303 > > > > > > Looking at QDialog docs, it says > > > > "modal : bool > > This

Re: Supporting MSVC2010 in ktexteditor framework

On Monday, 17 November 2014 07:33:00 Kevin Ottens wrote: > On Sunday 16 November 2014 18:01:04 Ivan Čukić wrote: > > Hi, > > > > The topic of increasing the compiler versions we require might have been > > started for the specific issue one of the frameworks had, but I think it > > shouldn't have