OSX/CI: kdesu fails to build on branch master

2014-11-15 Thread Marko Käning
There is no X11 on my OSX/CI system! This error hasn’t happened in the past, why does it occur currently? --- Building CXX object src/kdesud/CMakeFiles/kdesud.dir/kdesud_automoc.cpp.o /Users/marko/WC/KDECI-builds/kdesu/src/kdesud/kdesud.cpp:77:10: fatal error: 'X11/X.h' file not found #include

Re: About the _stable_ jenkins jobs

2014-11-15 Thread Albert Astals Cid
El Dissabte, 15 de novembre de 2014, a les 09:29:52, Martin Gräßlin va escriure: > On Friday 14 November 2014 17:33:18 Albert Astals Cid wrote: > > Yes, there's no frameworks stable branch, but our current jenkins setup > > (which hopefully will change in this SoK) is that if we want to have a > >

Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

2014-11-15 Thread Jeremy Whiting
> On Nov. 14, 2014, 4:16 p.m., Martin Klapetek wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, lines 301-303 > > > > > > Looking at QDialog docs, it says > > > > "modal : bool > > This

Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

2014-11-15 Thread Martin Klapetek
> On Nov. 15, 2014, 12:16 a.m., Martin Klapetek wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, lines 301-303 > > > > > > Looking at QDialog docs, it says > > > > "modal : bool > > This

Re: Review Request 121098: Restore filedialog functionality for modal dialogs.

2014-11-15 Thread Jeremy Whiting
> On Nov. 14, 2014, 4:16 p.m., Martin Klapetek wrote: > > src/platformtheme/kdeplatformfiledialoghelper.cpp, lines 301-303 > > > > > > Looking at QDialog docs, it says > > > > "modal : bool > > This

Re: About the _stable_ jenkins jobs

2014-11-15 Thread Martin Gräßlin
On Friday 14 November 2014 17:33:18 Albert Astals Cid wrote: > Yes, there's no frameworks stable branch, but our current jenkins setup > (which hopefully will change in this SoK) is that if we want to have a > kalgebra_stable_qt5 build, we need stable_qt5 builds for all it's > dependencies, so i'm

Re: Review Request 121122: Allow loading KPluginMetaData from a .desktop file

2014-11-15 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121122/#review70387 --- src/lib/plugin/desktopfileparser.h