Re: OSX/CI: kde-baseapps fails to build on branch master

On Tue, Nov 11, 2014 at 8:02 AM, Aleix Pol wrote: > Try adding a "#include " on top of the file, with the rest of the > includes. > > Should solve the issue. If it does, then it should be there. Yet another #ifdef problem.. this seems to happen only if baloo is not available, (Mac OS/X) 7ed7cd97

Review Request 121100: Add qCDebug statements back into knewstuff sources.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121100/ --- Review request for KDE Frameworks. Repository: knewstuff Description --

Re: OSX/CI: kde-baseapps fails to build on branch master

On Mon, Nov 10, 2014 at 11:12 PM, Marko Käning wrote: > After recent changes to kde-baseapps there is still some usage of > KLineEdit left in the sources: > > [ 91%] Building CXX object > dolphin/src/CMakeFiles/kdeinit_dolphin.dir/settings/general/confirmationssettingspage.cpp.o > /Users/marko/WC

Review Request 121099: Fix kautosave doesn't work with more than 1 file per application.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121099/ --- Review request for KDE Frameworks and David Faure. Repository: kcoreaddon

Re: Review Request 120605: cleanup overlay icon usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120605/ --- (Updated Nov. 11, 2014, midnight) Status -- This change has been mar

OSX/CI: kde-baseapps fails to build on branch master

After recent changes to kde-baseapps there is still some usage of KLineEdit left in the sources: [ 91%] Building CXX object dolphin/src/CMakeFiles/kdeinit_dolphin.dir/settings/general/confirmationssettingspage.cpp.o /Users/marko/WC/KDECI-builds/kde-baseapps/dolphin/src/search/dolphinsearchbox.cp

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

> On Nov. 10, 2014, 9:57 nachm., David Faure wrote: > > src/services/kplugininfo.cpp, line 47 > > > > > > Missing "static" before inline, if these methods are only used in this > > .cpp file. I put it all in an

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review70220 --- Ship it! src/services/kplugininfo.cpp

Re: Split kde-baseapps?

On Thursday 06 November 2014 10:59:38 David Narvaez wrote: > On Sat, Oct 25, 2014 at 3:06 PM, David Narvaez > > wrote: > > It's also used by Rekonq and anything building a web browser using KDE > > software, it should really go to kioslave-extras. > > Any feedback on this? If it will not be move

Re: Review Request 120605: cleanup overlay icon usage

> On Nov. 1, 2014, 12:38 p.m., Emmanuel Pescosta wrote: > > Ping? No git account? > > Albert Astals Cid wrote: > He does have an account as you can see in > http://websvn.kde.org/trunk/kde-common/accounts?view=markup > > But you can still commit it yourself, don't forget to use --a

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080/#review70214 --- lib/konq/src/konq_historyentry.h

Re: KPackage framework

On Monday 10 November 2014, Marco Martin wrote: > * porting all the internal and api use of KPluginInfo to KPluginMetadata > * removing all the query functionality, (since it needs > KPluginTrader::applyConstraints) and making instead KPluginTrader able to > find packages as well > > Opinions? com

Re: How to port KTabBar::mouseMiddleClick?

2014-11-09 7:28 GMT-03:00 Frank Reininghaus : > Hi, > > 2014-11-06 2:59 GMT+01:00 Milian Wolff: >> Hey all, >> >> what do I do to get middle-click-closes-tab in Qt 5 without KTabBar? >> Previously, we used KTabBar and its mouseMiddleClick signal. > > AFAIK, currently the only solution is to subclas

Review Request 121098: Restore filedialog functionality for modal dialogs.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121098/ --- Review request for KDE Frameworks and Eike Hein. Repository: frameworkint

Review Request 121094: KCoreAddons: add KTextToHTML class for plaintext -> HTML conversion

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121094/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Review Request 121095: FrameworkIntegration: Add KTextToHTML emoticons support to FrameworkIntegrationPlugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121095/ --- Review request for KDE Frameworks. Repository: frameworkintegration Des

Jenkins build is back to stable : kio_master_qt5 #435

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : knewstuff_master_qt5 #112

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 2:36 p.m.) Status -- This change has been ma

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/#review70191 --- Ship it! Ship It! - Patrick von Reth On Nov. 10, 2014, 2:2

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 2:23 p.m.) Review request for KDE Frameworks, Alb

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- (Updated Nov. 10, 2014, 2:22 p.m.) Review request for KDE Frameworks and

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

> On Nov. 10, 2014, 2:05 p.m., Patrick von Reth wrote: > > Yes as the files include export macros compiling them into an another > > lib/exe will break the build. > > As those where already part of a dll I thought I could just link the dll. I > > tested it on Windows and it build fine. > > What

Re: Review Request 121090: Move kio-mtp to kio-extras

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121090/#review70188 --- +1 makes sense to me. - Aleix Pol Gonzalez On Nov. 10, 2014

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

> On Nov. 10, 2014, 2:05 p.m., Patrick von Reth wrote: > > Yes as the files include export macros compiling them into an another > > lib/exe will break the build. > > As those where already part of a dll I thought I could just link the dll. I > > tested it on Windows and it build fine. > > What

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

> On Nov. 10, 2014, 2:05 p.m., Patrick von Reth wrote: > > Yes as the files include export macros compiling them into an another > > lib/exe will break the build. > > As those where already part of a dll I thought I could just link the dll. I > > tested it on Windows and it build fine. > > What

Re: Review Request 121093: Revert "don't recompile exported classes, link to their dll"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/#review70185 --- Yes as the files include export macros compiling them into an

Review Request 121093: Revert "don't recompile exported classes, link to their dll"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121093/ --- Review request for KDE Frameworks, Albert Astals Cid, Patrick von Reth, and

Jenkins build became unstable: kio_master_qt5 #434

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

KPackage framework

Hi all, since at akademy there seemed the interest in it, I have been working on some classes i extracted from libplasma to be on their own, those related to Plasma::Package, since several applications have the interest of having scriptable or anyways non-binary content shippable over ghns. you

Re: Review Request 119607: Support for ".hidden" files

> On Nov. 8, 2014, 10:02 p.m., David Faure wrote: > > src/core/kcoredirlister.cpp, line 1241 > > > > > > After this line, try adding > > > > if (!url.isLocalFile()) { > > const QString l

Build failed in Jenkins: knewstuff_master_qt5 #111

See Changes: [vonreth] don't recompile exported classes, link to their dll -- [...truncated 121 lines...] Policy CMP0053 is not set: Simplify variable reference and escape sequence evaluation.

Review Request 121090: Move kio-mtp to kio-extras

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121090/ --- Review request for KDE Frameworks, David Faure and Philipp Schmidt. Repos

Re: Review Request 121068: use correct ki18n_wrap_ui in ki18n based frameworks/kjsembed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121068/ --- (Updated Nov. 10, 2014, 9:25 a.m.) Status -- This change has been ma

Re: Review Request 121067: use correct ki18n_wrap_ui in ki18n based frameworks/knotifyconfig

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121067/ --- (Updated Nov. 10, 2014, 9:21 a.m.) Status -- This change has been ma

Re: Review Request 121066: use correct ki18n_wrap_ui in ki18n based frameworks/kwallet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121066/ --- (Updated Nov. 10, 2014, 9:18 a.m.) Status -- This change has been ma

Re: Review Request 121065: use correct ki18n_wrap_ui in ki18n based plasma-frameworks

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121065/ --- (Updated Nov. 10, 2014, 9:04 a.m.) Status -- This change has been ma