Re: Review Request 121062: use correct ki18n_wrap_ui in ki18n based framework

2014-11-09 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121062/ --- (Updated Nov. 10, 2014, 7:27 a.m.) Status -- This change has been ma

Re: Review Request 121068: use correct ki18n_wrap_ui in ki18n based frameworks/kjsembed

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121068/#review70157 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 8, 2014, 2:

Re: Review Request 121067: use correct ki18n_wrap_ui in ki18n based frameworks/knotifyconfig

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121067/#review70156 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 8, 2014, 2:

Re: Review Request 121066: use correct ki18n_wrap_ui in ki18n based frameworks/kwallet

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121066/#review70155 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 8, 2014, 2:

Re: Review Request 121065: use correct ki18n_wrap_ui in ki18n based plasma-frameworks

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121065/#review70154 --- Ship it! examples/kpart/CMakeLists.txt

Re: Review Request 121062: use correct ki18n_wrap_ui in ki18n based framework

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121062/#review70153 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 8, 2014, 2:

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2014-11-09 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080/#review70152 --- When I originally got KF5 to compile on windows I seem to reme

Re: Review Request 121080: Replace KDE_DUMMY_QHASH_FUNCTION.

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121080/#review70149 --- Shouldn't it be actually implemented then? - Aleix Pol Gonzal

Re: Review Request 121078: Fix exports.

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121078/#review70148 --- Ship it! Looks good to me, really useful and definitely a ste

Re: Review Request 121076: Do not require KF5::Su on Windows

2014-11-09 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121076/#review70147 --- Ship it! Ship It! - Aleix Pol Gonzalez On Nov. 8, 2014, 10

Re: Review Request 121082: Add TODO for private signals in KJob

2014-11-09 Thread Alexander Richardson
> On Nov. 9, 2014, 8:09 nachm., Alexander Richardson wrote: > > Ship It! Strangely enough you can connect using new-style syntax when you use clang... Sorry for breakig the kdevplatform build - Alexander --- This is an automatically ge

Re: Review Request 121082: Add TODO for private signals in KJob

2014-11-09 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121082/#review70124 --- Ship it! Ship It! - Alexander Richardson On Nov. 9, 2014,

Review Request 121084: Rename libmolletnetwork to avoid conflict with KDE4

2014-11-09 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121084/ --- Review request for KDE Runtime, KDE Frameworks and Plasma. Repository: ki

Review Request 121086: Rename jpegcreatorsettings.kcfg to avoid conflicts with KDE4

2014-11-09 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121086/ --- Review request for KDE Runtime, KDE Frameworks and Plasma. Repository: ki

Re: How to port KTabBar::mouseMiddleClick?

2014-11-09 Thread Frank Reininghaus
Hi, 2014-11-06 2:59 GMT+01:00 Milian Wolff: > Hey all, > > what do I do to get middle-click-closes-tab in Qt 5 without KTabBar? > Previously, we used KTabBar and its mouseMiddleClick signal. AFAIK, currently the only solution is to subclass QTabBar, override the mousePressEvent method and emit a

Review Request 121082: Add TODO for private signals in KJob

2014-11-09 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121082/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description