Re: Review Request 121007: Fix warning when using newer upower backend.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121007/#review69967 --- Ship it! Finally! - Kevin Funk On Nov. 6, 2014, 1:05 a.m.,

Review Request 121019: reverse ShowIconsOnPushButtons default

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121019/ --- Review request for KDE Frameworks, kdelibs and Thomas Pfeiffer. Repositor

Review Request 121021: reverse ShowIconsOnPushButtons default

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121021/ --- Review request for KDE Frameworks, kdelibs and Thomas Pfeiffer. Repositor

Review Request 121020: reverse ShowIconsOnPushButtons default

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121020/ --- Review request for KDE Frameworks, kdelibs and Thomas Pfeiffer. Repositor

Re: [RFC] [kservice] KPluginMetadata indexing

2014-11-05 23:44 GMT-03:00 Sebastian Kügler : > So, this code is in a bit of a draft stage, I'd very much welcome feedback > about the approach, and of course the code itself. It can be found in > kservice[sebas/kpluginindex]. the kpluginmetadata autotest gives a useful > testing target. I didn't s

Re: Review Request 120199: Implement KPluginTrader::query() using KPluginLoader::findPlugins()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120199/#review69948 --- src/plugin/kplugintrader.cpp

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review69947 --- src/services/kplugininfo.cpp

Re: [RFC] [kservice] KPluginMetadata indexing

On Thursday 06 November 2014 17:06:38 Mark Gaiser wrote: > On Thu, Nov 6, 2014 at 4:43 PM, Sebastian Kügler wrote: > > On Thursday, November 06, 2014 10:09:51 Mark Gaiser wrote: > >> I'm curious about one thing. Have you done some profiling on the > >> current KPluginMetaData to see where the actu

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/ --- (Updated Nov. 6, 2014, 6:50 nachm.) Review request for KDE Frameworks.

Re: Review Request 120199: Implement KPluginTrader::query() using KPluginLoader::findPlugins()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120199/ --- (Updated Nov. 6, 2014, 6:49 nachm.) Review request for KDE Frameworks.

Re: Review Request 120825: Fix KPluginInfo::entryPath() being empty when not loaded from .desktop

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120825/ --- (Updated Nov. 6, 2014, 4:09 p.m.) Status -- This change has been mar

Re: [RFC] [kservice] KPluginMetadata indexing

On Thu, Nov 6, 2014 at 4:43 PM, Sebastian Kügler wrote: > On Thursday, November 06, 2014 10:09:51 Mark Gaiser wrote: >> I'm curious about one thing. Have you done some profiling on the >> current KPluginMetaData to see where the actual hot spot is? >> In case you don't know how to do that, here ar

Re: Split kde-baseapps?

On Sat, Oct 25, 2014 at 3:06 PM, David Narvaez wrote: > It's also used by Rekonq and anything building a web browser using KDE > software, it should really go to kioslave-extras. Any feedback on this? If it will not be moved to kioslave-extras I need to patch Rekonq to stop annoying me about the

Feedback on KDBusService::activateRequested

Hi, After working on the implementation of the unique mode in Rekonq[0], I have some (unsolicited) feedback about the activateRequested slot that I would like to share in case these issues can be addressed: Whenever I use libraries that deal with command line arguments my first question is whethe

Re: [RFC] [kservice] KPluginMetadata indexing

On Thursday, November 06, 2014 10:09:51 Mark Gaiser wrote: > I'm curious about one thing. Have you done some profiling on the > current KPluginMetaData to see where the actual hot spot is? > In case you don't know how to do that, here are some tips: > 1. Recompile Qt with debug symbols (not debug m

Re: [RFC] [kservice] KPluginMetadata indexing

On Thursday 06 November 2014, Sebastian Kügler wrote: > Basic Mechanism > > - a small tool called kplugin-update-index collects the json metadata from > the plugins, and puts the list of plugins in a given plugin directory into > a QJsonArray, and dumps that in Qt's json binary format to disk sin

Re: Review Request 120854: KPassivePopup - Set default hide delay

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120854/ --- (Updated Nov. 6, 2014, 11:36 a.m.) Status -- This change has been ma

Re: Review Request 120728: Install public header for KNotifyPlugin and rename it to KNotificationPlugin

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120728/ --- (Updated Nov. 6, 2014, 11:36 a.m.) Status -- This change has been ma

Re: Review Request 120199: Implement KPluginTrader::query() using KPluginLoader::findPlugins()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120199/#review69929 --- src/plugin/kplugintrader.cpp

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review69928 --- src/services/kplugininfo.cpp

Re: [RFC] [kservice] KPluginMetadata indexing

On Thursday 06 November 2014 10:09:51 Mark Gaiser wrote: > On Thu, Nov 6, 2014 at 3:44 AM, Sebastian Kügler wrote: > > Hi all, especially Alex and David, > > > > tl;dr: > > I've done a proof-of-concept implementation of a metadata index for > > KPluginTrader::query(), the main entry point when i

Re: [RFC] [kservice] KPluginMetadata indexing

On Thu, Nov 6, 2014 at 3:44 AM, Sebastian Kügler wrote: > Hi all, especially Alex and David, > > tl;dr: > I've done a proof-of-concept implementation of a metadata index for > KPluginTrader::query(), the main entry point when it comes to finding binary > plugins. This index considerably speeds up