Re: Supporting MSVC2010 in ktexteditor framework

2014-11-04 Thread Martin Graesslin
On Wednesday 05 November 2014 08:53:42 Mirko Boehm wrote: > Hi, > > > On 05 Nov 2014, at 04:33, Nicolás Alvarez > > wrote: > > > > So, I hereby propose making an exception and bumping the minimum > > compiler version *for ktexteditor only* to MSVC2012. Opinions? > > I propose to bump the requir

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-04 Thread Mirko Boehm
Hi, > On 05 Nov 2014, at 04:33, Nicolás Alvarez wrote: > > So, I hereby propose making an exception and bumping the minimum > compiler version *for ktexteditor only* to MSVC2012. Opinions? I propose to bump the required compiler versions across the board to compilers that fully 100% implemen

Supporting MSVC2010 in ktexteditor framework

2014-11-04 Thread Nicolás Alvarez
Hi all, According to https://community.kde.org/Frameworks/C++11, KDE Frameworks support MSVC2010 and later versions. Since ktexteditor is part of KF5, it is supposed to work on MSVC2010. It currently doesn't; several unsupported C++11 features were introduced to the library in the past few months.

Re: kio and scheme://

2014-11-04 Thread David Faure
On Sunday 02 November 2014 23:23:55 Milian Wolff wrote: > On Sunday 02 November 2014 13:43:50 Àlex Fiestas wrote: > > Hi there > > > > There are quite a few places where the following code is found: > > > > if (!url.path().endsWith('/')) { > > > > url.setPath(url.path() + '/'); > > > > } >

Re: kio and scheme://

2014-11-04 Thread David Faure
On Sunday 02 November 2014 13:43:50 Àlex Fiestas wrote: > Hi there > > There are quite a few places where the following code is found: > > if (!url.path().endsWith('/')) { > url.setPath(url.path() + '/'); > } Right. > Given an url like: 'scheme://' KUrl will return '/' as path Wrong. htt

Re: Review Request 120969: Fix build on OSX due to missing XDR functions.

2014-11-04 Thread Mathias Tillman
> On Nov. 4, 2014, 3:55 p.m., David Faure wrote: > > What does XDG have to do with data types? Do you mean XDR ? Ahh, didn't realise I had written XDG. It should be XDR :) - Mathias --- This is an automatically generated e-mail. To repl

Re: Review Request 120969: Fix build on OSX due to missing XDR functions.

2014-11-04 Thread Mathias Tillman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120969/ --- (Updated Nov. 4, 2014, 3:58 p.m.) Review request for KDE Frameworks and D

Re: Review Request 120969: Fix build on OSX due to missing XDR functions.

2014-11-04 Thread Mathias Tillman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120969/ --- (Updated Nov. 4, 2014, 3:57 p.m.) Review request for KDE Frameworks and D

Re: Review Request 120969: Fix build on OSX due to missing XDG functions.

2014-11-04 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120969/#review69829 --- What does XDG have to do with data types? Do you mean XDR ? -

Re: Review Request 120969: Fix build on OSX due to missing XDG functions.

2014-11-04 Thread Mathias Tillman
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120969/ --- (Updated Nov. 4, 2014, 2:40 p.m.) Review request for KDE Frameworks and D

Re: Gerrit available for trial

2014-11-04 Thread Jan Kundrát
On Saturday, 11 October 2014 11:57:20 CEST, Kevin Krammer wrote: I am not opposed but I think just the new ones would be sufficient. If one is interested in the proceedings of a specific request it is easy enough to add oneselves as a reviewer. It also makes the "new" notification stand out si

Change in kio[master]: Ignore this: testing Gerrit -> ML notifications

2014-11-04 Thread Code Review
Jan Kundrát has uploaded a new change for review. https://gerrit.vesnicky.cesnet.cz/r/143 Change subject: Ignore this: testing Gerrit -> ML notifications .. Ignore this: testing Gerrit -> ML notifications This should be the o

Re: OSX/CI: kio-extras builds to fail on branch master

2014-11-04 Thread Marko Käning
Hi Mathias, On 03 Nov 2014, at 11:41 , Mathias Tillman wrote: > yes, that did the job: $ ./install.sh kio-extras rebuild -- Project : kde/workspace/kio-extras Branch : master Linux-CI : UNSTABLE Calling prepare script Calling build script