Re: Where are kwalletd autotests?

2014-10-31 Thread Albert Astals Cid
El Dissabte, 1 de novembre de 2014, a les 00:23:57, David Faure va escriure: > On Friday 31 October 2014 01:00:41 Albert Astals Cid wrote: > > kwalletd has autotests in kde-runtime in kdelibs4 world but can't find > > them > > in KF5 land. > > > > Any reason why they are not there? Or they are and

Jenkins build is back to stable : kio_master_qt5 #421

2014-10-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Where are kwalletd autotests?

2014-10-31 Thread David Faure
On Friday 31 October 2014 01:00:41 Albert Astals Cid wrote: > kwalletd has autotests in kde-runtime in kdelibs4 world but can't find them > in KF5 land. > > Any reason why they are not there? Or they are and i can't find them? These? ./tests/kwalletd/CMakeLists.txt ./tests/kwalletd/kwalletmany.c

Re: Review Request 120926: Remove redundant code from KRun::KRunPrivate::isPromptNeeded()

2014-10-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120926/#review69611 --- I would rather that this is all encapsulated, so callers don't

Review Request 120926: Remove redundant code from KRun::KRunPrivate::isPromptNeeded()

2014-10-31 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120926/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 120920: Fill SendTo menu async to fix "Bug 312495 - Very slow 'Send to' menu"

2014-10-31 Thread Gregor Mi
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120920/ --- (Updated Oct. 31, 2014, 5:50 p.m.) Review request for KDE Frameworks, KDE

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #862

2014-10-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to stable : plasma-framework_master_qt5 » NoX11,LINBUILDER #862

2014-10-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: plasma-framework_master_qt5 » All,LINBUILDER #861

2014-10-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #861

2014-10-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120917: Fix memory leak for NETWinInfoPrivate::client_machine

2014-10-31 Thread Martin Gräßlin
> On Oct. 31, 2014, 2:37 p.m., Lukáš Tinkl wrote: > > Please add reference to https://bugs.kde.org/show_bug.cgi?id=339902 > > > > Gonna test later, thanks for taking care of this! actually there seems to be another leak indicated in the bug report which I was not able yet to reproduce in a tes

Re: Review Request 120917: Fix memory leak for NETWinInfoPrivate::client_machine

2014-10-31 Thread Lukáš Tinkl
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120917/#review69582 --- Please add reference to https://bugs.kde.org/show_bug.cgi?id=3

Review Request 120917: Fix memory leak for NETWinInfoPrivate::client_machine

2014-10-31 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120917/ --- Review request for KDE Frameworks, kwin, Bhushan Shah, and Lukáš Tinkl. R

Jenkins build is back to stable : kwindowsystem_master_qt5 » All,LINBUILDER #114

2014-10-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kio_master_qt5 #417

2014-10-31 Thread KDE CI System
See Changes: [faure] KIO: new job PasteJob, handles pasting+dropping URLs and data. [faure] Deprecate KIO::pasteClipboard and port some code to KIO::paste [faure] Make pastejob.h usable from the outside - it didn't find job_base.h -

Re: Review Request 120909: in kio_smb: Set inode/directory mimetype for folders

2014-10-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120909/#review69572 --- Hmm, not sure which change in KFileItem you're referring to. B

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

2014-10-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/#review69565 --- Ship it! Looking nice now! Thanks. src/main.cpp