Where are kwalletd autotests?

2014-10-30 Thread Albert Astals Cid
kwalletd has autotests in kde-runtime in kdelibs4 world but can't find them in KF5 land. Any reason why they are not there? Or they are and i can't find them? Cheers, Albert ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://m

Re: Review Request 120155: Correctly load non-square icons in KIconLoader

2014-10-30 Thread Christoph Feck
> On Oct. 1, 2014, 7:45 a.m., David Faure wrote: > > So, iconthemes aren't made for non-square icons. So why not skip the use of > > icon themes for this? Some use of QStandardPaths to locate the icon > > directly; just like konqueror finds its indicator_connect.png for instance. > > Or does t

Re: Review Request 120909: in kio_smb: Set inode/directory mimetype for folders

2014-10-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120909/#review69560 --- > Previously (kde4) KFileItem was doing an extra effort into f

Review Request 120909: in kio_smb: Set inode/directory mimetype for folders

2014-10-30 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120909/ --- Review request for KDE Frameworks and David Faure. Repository: kio-extras

Re: Review Request 120902: [KRatingPainter] Support monochrome icon themes (such as breeze)

2014-10-30 Thread Christoph Feck
> On Oct. 30, 2014, 2:04 p.m., David Edmundson wrote: > > src/kratingpainter.cpp, line 252 > > > > > > This part seems like it needs fixing too, as it's still just taking the > > full potentially grey icon and g

Re: Review Request 120794: Implement Unique Mode Properly in Rekonq

2014-10-30 Thread Andrea Diamantini
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/#review69530 --- Ship it! Seems good to me now. - Andrea Diamantini On Oct.

Re: Review Request 120902: [KRatingPainter] Support monochrome icon themes (such as breeze)

2014-10-30 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120902/#review69528 --- src/kratingpainter.cpp

Re: Review Request 120902: [KRatingPainter] Support monochrome icon themes (such as breeze)

2014-10-30 Thread David Edmundson
> On Oct. 30, 2014, 2:04 p.m., David Edmundson wrote: > > src/kratingpainter.cpp, line 231 > > > > > > this was previously only turned into an image to do the toGrayScale > > conversion. > > > > I don't

Re: Review Request 120903: Fix typo in documentation.

2014-10-30 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120903/ --- (Updated Oct. 30, 2014, 1:30 p.m.) Status -- This change has been ma

Re: Review Request 120888: add a new KNotification::Event with icon name

2014-10-30 Thread Christoph Feck
> On Oct. 30, 2014, 12:18 p.m., Christoph Feck wrote: > > This seems to introduce a source-incompatible change, see build failure in > > kruler/frameworks: http://paste.opensuse.org/68026650 oops, already fixed - Christoph --- This is

Re: Review Request 120888: add a new KNotification::Event with icon name

2014-10-30 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120888/#review69522 --- This seems to introduce a source-incompatible change, see buil

Build failed in Jenkins: kio_master_qt5 #413

2014-10-30 Thread KDE CI System
See Changes: [arjunak234] Show script execution prompt only if asked to -- [...truncated 1272 lines...] Linking CXX executable kio_http_cache_cleaner [ 51%] Built target kio_http_cache_cleaner [ 52%] [

Re: Review Request 120886: Show script execution prompt only if asked to

2014-10-30 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120886/ --- (Updated Oct. 30, 2014, 11:31 a.m.) Status -- This change has been m