Review Request 120794: Implement Unique Mode Properly in Rekonq

2014-10-24 Thread David Narváez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120794/ --- Review request for KDE Frameworks and rekonq. Repository: rekonq Descri

Re: Review Request 120641: Turn virtuals into Q_DECL_OVERRIDE and rename a wrong override

2014-10-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120641/ --- (Updated Oct. 24, 2014, 10:42 p.m.) Status -- This change has been m

Re: Review Request 120640: Turn virtuals into Q_DECL_OVERRIDE and remove wrong override

2014-10-24 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120640/ --- (Updated Oct. 24, 2014, 10:40 p.m.) Status -- This change has been m

Re: Severe behavioural change regressions in release branch

2014-10-24 Thread Ben Cooksley
On Sat, Oct 25, 2014 at 5:44 AM, Stephen Kelly wrote: > Ben Cooksley wrote: > >> Hi all, >> >> It would appear that CMake 3.0 to 3.1 introduces a colossal change in >> behaviour. This change totally breaks all KDE projects which use >> Extra-CMake-Modules, as necessary headers are no longer instal

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #182

2014-10-24 Thread KDE CI System
See Changes: [scripty] SVN_SILENT made messages (after extraction) [frank78ac] Connect to the currentDirectoryChanged signal after the shell setup [emmanuelpescosta099] Fix the information panel video player in Dolphin. [frank7

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #854

2014-10-24 Thread KDE CI System
See Changes: [notmart] fix paint and size hints -- [...truncated 183 lines...] -- Configuring done -- Generating done CMake Warning: Manually-specified

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #854

2014-10-24 Thread KDE CI System
See Changes: [notmart] fix paint and size hints -- [...truncated 271 lines...] Automatic moc for target framesvgtest Generating moc_dialognativetest.cpp [ 8

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #181

2014-10-24 Thread KDE CI System
See Changes: [Daniel Vrátil] Konq: install konq_popupmenu.h, which other apps include -- [...truncated 606 lines...] make[1]: *** [lib/konq/src/favicons/CMakeFiles/kded_favicons.dir/all] Er

Build failed in Jenkins: ktexteditor_master_qt5 #713

2014-10-24 Thread KDE CI System
See Changes: [svenbrauch] implement "go to last editing position" action -- [...truncated 135 lines...] QT.KTextEditor.MAJOR_VERSION = 5 QT.KTextEditor.MINOR_VERSION = 4 QT.KTextEdit

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-24 Thread Emmanuel Pescosta
> On Oct. 23, 2014, 11:43 a.m., David Faure wrote: > > Thanks for the patch. > > > > Calling init() again surprised me a bit, since this method was never called > > twice before, but OK, anything else would be much more invasive. I would > > suggest to at least add a comment e.g. in the call t

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-24 Thread Emmanuel Pescosta
> On Oct. 23, 2014, 1:14 p.m., Emmanuel Pescosta wrote: > > src/widgets/krun.cpp, line 1013 > > > > > > Any reason why using show instead of exec? Exec would avoid the rather > > complex and error-prone code pa

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #853

2014-10-24 Thread KDE CI System
See Changes: [notmart] make sure there is any screen geometry returned -- [...truncated 255 lines...] Generating qrangemodel.moc

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #853

2014-10-24 Thread KDE CI System
See Changes: [notmart] make sure there is any screen geometry returned -- [...truncated 189 lines...] KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_SI

Re: Review Request 120648: Encode the URIs which end up in DTD files

2014-10-24 Thread Alex Merry
> On Oct. 21, 2014, 9:08 p.m., Alex Merry wrote: > > Ship It! > > Marko Käning wrote: > Hi Alex, did you test this successfully on Windows? No, I'm expecting Luigi to interpret my shipit as approval of the CMake code in principle, and to exercise his own judgement in whether it's actually

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #852

2014-10-24 Thread KDE CI System
See Changes: [notmart] don't mess with cursor pos if mouse outside view -- [...truncated 257 lines...] [ 8%] Automatic moc for target framesvgtest Automat

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #852

2014-10-24 Thread KDE CI System
See Changes: [notmart] don't mess with cursor pos if mouse outside view -- [...truncated 191 lines...] KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_S

Re: Review Request 120666: Get user's permission before executing scripts or desktop files

2014-10-24 Thread David Faure
> On Oct. 23, 2014, 11:14 a.m., Emmanuel Pescosta wrote: > > src/widgets/krun.cpp, line 1013 > > > > > > Any reason why using show instead of exec? Exec would avoid the rather > > complex and error-prone code p