Re: Review Request 120640: Turn virtuals into Q_DECL_OVERRIDE and remove wrong override

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120640/#review68861 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 18, 2014, 3

Re: Review Request 120641: Turn virtuals into Q_DECL_OVERRIDE and rename a wrong override

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120641/#review68862 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 18, 2014, 7

OSX/CI: kio-extras builds to fail on branch master

On Linux kio-extras seems to build fine, but it doesn’t on OSX: --- [92%] Building C object nfs/CMakeFiles/kio_nfs.dir/rpc_nfs3_prot_xdr.c.o /Users/marko/WC/KDECI-builds/kio-extras/nfs/rpc_nfs3_prot_xdr.c:13:8: error: implicit declaration of function 'xdr_u_quad_t' [-Werror,-Wimplicit-function-

OSX/CI: kate builds to fail on branch master

[ 86%] Building CXX object addons/katesql/CMakeFiles/katesqlplugin.dir/exportwizard.cpp.o [ 86%] Built target kategdbplugin [ 86%] Building CXX object addons/katebuild-plugin/CMakeFiles/katebuildplugin.dir/KBProcess.cpp.o /Users/marko/WC/KDECI-builds/kate/addons/katebuild-plugin/KBProcess.cpp:40:

Re: Review Request 120586: Fix KPluginSelector not adding non .desktop file plugins

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120586/#review68858 --- Ship it! I think we need a way to compare whether two plugins

Re: Review Request 120198: KPluginInfo: use KPluginMetaData instead of a QVariantMap for storage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120198/#review68857 --- I've looked at the patch and tested it, it looks like a really

Re: Review Request 120648: Encode the URIs which end up in DTD files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68855 --- Ship it! Ship It! - Alex Merry On Oct. 20, 2014, 12:12 a.m

Re: Review Request 120648: Encode the URIs which end up in DTD files

> On Oct. 19, 2014, 10:52 a.m., Alex Merry wrote: > > src/CMakeLists.txt, line 19 > > > > > > You've already included it above... > > Luigi Toscano wrote: > This is different, it's in a piece of code inside i

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #170

See Changes: [faure] Remove KonqOperations::pasteInfo. -- [...truncated 1988 lines...] [ 61%] Building CXX object dolphin/src/CMakeFiles/kcm_dolphingeneral.dir/settings/general/confirmatio

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #169

See Changes: [lukas] address 2 more KUrl -> QUrl issues mentioned in rr#120688 -- [...truncated 1885 lines...] [ 51%] Building CXX object dolphin/src/CMakeFiles/dolphinprivate.dir/kitemvie

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #168

See Changes: [faure] Dolphin: port to KIO::pasteInfoText(). -- [...truncated 1911 lines...] [ 54%] Building CXX object konqueror/src/CMakeFiles/kdeinit_konqueror.dir/kded_interface.cpp.o [

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #167

See Changes: [lukas] libkonq now loads its own catalog [lukas] port away from KMimeType -- [...truncated 2148 lines...] ^

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #166

See Changes: [lukas] set translation domain [lukas] port Dolphin from KUrl to QUrl -- [...truncated 2181 lines...]

Re: Build failed in Jenkins: kdelibs4support_master_qt5 #288

On Tuesday 21 of October 2014 19:58:55 KDE CI System wrote: > See > In file included from > > :21:0: >

Build failed in Jenkins: kdelibs4support_master_qt5 #288

See Changes: [hrvoje.senjan] Fix build with Qt 5.4 -- [...truncated 935 lines...] :700:20: warning: ‘virtu

Re: Review Request 120641: Turn virtuals into Q_DECL_OVERRIDE and rename a wrong override

> On oct. 18, 2014, 4:30 p.m., Aleix Pol Gonzalez wrote: > > +1 Looks good to me. Anyone has other comments? Can i has a shipit? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/

Re: Review Request 120640: Turn virtuals into Q_DECL_OVERRIDE and remove wrong override

> On oct. 18, 2014, 4:29 p.m., Aleix Pol Gonzalez wrote: > > Looks good to me. +1 Anyone has other comments? Can i has a shipit? - Albert --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #164

See Changes: [faure] Remove parentless ctor for KonqCopyToMenu, as the TODO said -- [...truncated 1524 lines...] :5

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #163

See Changes: [faure] Remove deprecated KonqNameAndUrlInputDialog -- [...truncated 1052 lines...]