Re: Review Request 120605: cleanup overlay icon usage

> On Oct. 16, 2014, 6:09 p.m., Emmanuel Pescosta wrote: > > Looks good! +1 from my side > > > > (Please use the CCBUG hook when you commit this patch, because it only > > fixes one mentioned problem) Any more comments? Is this a SHIP IT? BTW: The same applies to SC 4, should I backport it to

Re: Review Request 120648: Encode the URIs which end up in DTD files

> On Ott. 18, 2014, 8:50 p.m., René J.V. Bertin wrote: > > These are both RRs for KF5? > > Luigi Toscano wrote: > Yes, otherwise the repository would have been kdelibs. Do you think it > would make sense to backport it? > > René J.V. Bertin wrote: > You say that this is for "when the p

Re: Review Request 120648: Encode the URIs which end up in DTD files

> On Oct. 18, 2014, 8:50 p.m., René J.V. Bertin wrote: > > These are both RRs for KF5? > > Luigi Toscano wrote: > Yes, otherwise the repository would have been kdelibs. Do you think it > would make sense to backport it? You say that this is for "when the path contains spaces, as it happens

Re: Review Request 120648: Encode the URIs which end up in DTD files

> On Ott. 18, 2014, 8:10 p.m., Alex Merry wrote: > > I guess we're assuming no-one's putting double-quotes in the URIs? > > > > It's probably not worth making it more reslient, given the extra complexity > > that would entail (you'd either have to do some pre-escaping or write it > > out to a

Re: Review Request 120648: Encode the URIs which end up in DTD files

> On Ott. 18, 2014, 8:50 p.m., René J.V. Bertin wrote: > > These are both RRs for KF5? Yes, otherwise the repository would have been kdelibs. Do you think it would make sense to backport it? - Luigi --- This is an automatically generat

Re: Review Request 120648: Encode the URIs which end up in DTD files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68675 --- These are both RRs for KF5? - René J.V. Bertin On Oct. 18,

Re: Review Request 120648: Encode the URIs which end up in DTD files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/#review68674 --- I guess we're assuming no-one's putting double-quotes in the U

Jenkins build is back to normal : solid_master_qt5 #119

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120641: Turn virtuals into Q_DECL_OVERRIDE and rename a wrong override

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120641/#review68671 --- +1 Looks good to me. - Aleix Pol Gonzalez On Oct. 18, 2014,

Re: Review Request 120640: Turn virtuals into Q_DECL_OVERRIDE and remove wrong override

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120640/#review68670 --- Looks good to me. +1 - Aleix Pol Gonzalez On Oct. 18, 2014,

Solid compilation issue

Hey, I'm running into an issue compiling Solid: [ 96%] Building CXX object autotests/CMakeFiles/logindinhibitionargument.dir/logindinhibitionargumenttest.cpp.o In file included from /home/kde- devel/src/frameworks/solid/autotests/logindinhibitionargumenttest.cpp:22:0: /home/kde- devel/src/framew

Review Request 120649: Encode the URIs which end up in DTD files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120649/ --- Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,

Review Request 120648: Encode the URIs which end up in DTD files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120648/ --- Review request for Build System, KDE Software on Mac OS X, KDE Frameworks,

Re: Review Request 119607: Support for ".hidden" files

> On Out. 18, 2014, 10:02 a.m., David Faure wrote: > > The last patch says "I have not tested this yet" - has it been tested > > meanwhile? Let's not let this rot completely :-) Yes, I have tested it already. It works, but the issues were not all fixed yet. And, as discussed above, the patch d

Re: Review Request 119607: Support for ".hidden" files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119607/#review68653 --- The last patch says "I have not tested this yet" - has it been

Re: Review Request 120458: Port html, djvu and folder thumbcreators

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120458/#review68650 --- Ship it! Ship It! - David Faure On Oct. 4, 2014, 5:31 p.m.

Review Request 120641: Turn virtuals into Q_DECL_OVERRIDE and rename a wrong override

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120641/ --- Review request for KDE Frameworks. Repository: attica Description -