Review Request 120640: Turn virtuals into Q_DECL_OVERRIDE and remove wrong override

2014-10-17 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120640/ --- Review request for KDE Frameworks. Repository: karchive Description ---

Re: Review Request 120622: Update QIconItem on resize

2014-10-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120622/ --- (Updated Oct. 17, 2014, 2:45 p.m.) Status -- This change has been ma

Re: Review Request 120622: Update QIconItem on resize

2014-10-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120622/#review68614 --- Ship it! Looks good! - Aleix Pol Gonzalez On Oct. 17, 2014

Review Request 120622: Update QIconItem on resize

2014-10-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120622/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Re: Review Request 120621: Add atlas support into ImagesTexturesCache

2014-10-17 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120621/#review68613 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 17, 2014, 2

Review Request 120621: Add atlas support into ImagesTexturesCache

2014-10-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120621/ --- Review request for KDE Frameworks. Repository: kdeclarative Description

Re: Review Request 120606: Properly parse URL in KUrlNavigator

2014-10-17 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120606/ --- (Updated Oct. 17, 2014, 9:36 a.m.) Status -- This change has been ma

Re: Review Request 120606: Properly parse URL in KUrlNavigator

2014-10-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120606/#review68597 --- Ship it! Thanks. Leaves one small issue. src/filewidgets/ku

Re: Review Request 120606: Properly parse URL in KUrlNavigator

2014-10-17 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120606/ --- (Updated Říj. 17, 2014, 7:53 dop.) Review request for KDE Frameworks and

Re: Review Request 120606: Properly parse URL in KUrlNavigator

2014-10-17 Thread David Faure
> On Oct. 16, 2014, 2:43 p.m., David Faure wrote: > > src/filewidgets/kurlnavigator.cpp, line 717 > > > > > > This looks wrong. > > > > After this line, path can contain either a path or a URL. > >

Re: Review Request 120606: Properly parse URL in KUrlNavigator

2014-10-17 Thread David Faure
> On Oct. 16, 2014, 2:43 p.m., David Faure wrote: > > src/filewidgets/kurlnavigator.cpp, line 717 > > > > > > This looks wrong. > > > > After this line, path can contain either a path or a URL. > >

Re: Review Request 120606: Properly parse URL in KUrlNavigator

2014-10-17 Thread Jan Grulich
> On Říj. 16, 2014, 2:43 odp., David Faure wrote: > > src/filewidgets/kurlnavigator.cpp, line 717 > > > > > > This looks wrong. > > > > After this line, path can contain either a path or a URL. > >