Jenkins build is back to normal : knewstuff_master_qt5 #102

2014-10-14 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: knewstuff_master_qt5 #101

2014-10-14 Thread KDE CI System
See Changes: [jpwhiting] Enable autotests. -- [...truncated 39 lines...] KDE Continuous Integration Build == Building Project: knewstuff - Branch master == Build Dependencies: kio - Branch ma

Re: Review Request 120592: enable autotests for knewstuff

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120592/ --- (Updated Oct. 15, 2014, 1:41 a.m.) Status -- This change has been ma

Re: Review Request 120592: enable autotests for knewstuff

2014-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120592/#review68423 --- Ship it! Ship It! - Aleix Pol Gonzalez On Oct. 14, 2014, 1

Re: private export

2014-10-14 Thread Jeremy Whiting
Meh, Albert found a decent enough way to do it. Posted to rb to look at. On Tue, Oct 14, 2014 at 5:03 PM, Aleix Pol wrote: > On Tue, Oct 14, 2014 at 10:37 PM, Jeremy Whiting wrote: >> >> Hello, >> >> In KNewStuff autotests there are two disabled tests that build and >> work if I export the Autho

Review Request 120592: Remove #ifndefs for WIN CE, we don't support CE anymore.

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120592/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstu

Re: Review Request 120592: enable autotests for knewstuff

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120592/ --- (Updated Oct. 14, 2014, 5:19 p.m.) Review request for KDE Frameworks and

Re: private export

2014-10-14 Thread Aleix Pol
On Tue, Oct 14, 2014 at 10:37 PM, Jeremy Whiting wrote: > Hello, > > In KNewStuff autotests there are two disabled tests that build and > work if I export the Author and EntryInternal classes, but these two > classes are private (declared in _p.h files) so I'd rather not export > them, since they

private export

2014-10-14 Thread Jeremy Whiting
Hello, In KNewStuff autotests there are two disabled tests that build and work if I export the Author and EntryInternal classes, but these two classes are private (declared in _p.h files) so I'd rather not export them, since they aren't public api. Is there a way to have them exported when BUILD_T

Review Request 120589: Remove #ifndefs for WIN CE, we don't support CE anymore.

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120589/ --- Review request for KDE Frameworks, Nicolás Alvarez and Jeremy Whiting. Re

Re: Review Request 120574: Add explicit to ctors with one parameter

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/ --- (Updated Oct. 14, 2014, 7:47 p.m.) Status -- This change has been ma

Re: Gerrit available for trial

2014-10-14 Thread David Faure
On Tuesday 14 October 2014 10:47:34 Jan Kundrát wrote: > On Friday, 10 October 2014 22:57:26 CEST, David Faure wrote: > > However I can't add the KDE contributors that I want, to the request. > > They all have a KDE identity account, but obviously didn't create a gerrit > > account yet. > > Hi Dav

Re: Review Request 120574: Add explicit to ctors with one parameter

2014-10-14 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/#review68414 --- Ship it! This is technically source incompatible, but only fo

Review Request 120586: Fix KPluginSelector not adding non .desktop file plugins

2014-10-14 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120586/ --- Review request for KDE Frameworks. Repository: kcmutils Description ---

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-14 Thread Marco Martin
> On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: > > src/quickaddons/managedtexturenode.h, line 52 > > > > > > even if will always remain just this member, just to me sure, it should > > be in a dpointer > > A

Re: Review Request 120574: Add explicit to ctors with one parameter

2014-10-14 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/ --- (Updated Oct. 14, 2014, 10:11 a.m.) Review request for KDE Frameworks, Da

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #141

2014-10-14 Thread KDE CI System
See Changes: [me] Port Dolphin to the new Baloo APIs -- [...truncated 2955 lines...] KDialog *regExpDialog; ^

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-14 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/#review68396 --- src/quickaddons/imagetexturescache.h

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-14 Thread Vishesh Handa
> On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: > > src/quickaddons/managedtexturenode.h, line 52 > > > > > > even if will always remain just this member, just to me sure, it should > > be in a dpointer > > A

Re: Review Request 120581: Don't crash if the plasmoid wasn't properly loaded

2014-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120581/ --- (Updated Oct. 14, 2014, 1:46 p.m.) Status -- This change has been ma

Re: Review Request 120581: Don't crash if the plasmoid wasn't properly loaded

2014-10-14 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120581/#review68390 --- Ship it! Inviala! - Marco Martin On Ott. 14, 2014, 1:09 p.

Review Request 120581: Don't crash if the plasmoid wasn't properly loaded

2014-10-14 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120581/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 120443: Add ctags configuration option to highlighting

2014-10-14 Thread Bastian Holst
> On Okt. 10, 2014, 7:55 nachm., Christoph Cullmann wrote: > > Hi, I think that should not be in KTextEditor. > > Thats really special and given that only a very limited amount of languages > > with ctags specials exists, it would make more sense to just have a > > heuristic in the project plug

Re: Gerrit available for trial

2014-10-14 Thread Jan Kundrát
On Friday, 10 October 2014 22:57:26 CEST, David Faure wrote: However I can't add the KDE contributors that I want, to the request. They all have a KDE identity account, but obviously didn't create a gerrit account yet. Hi David, all KDE developers are now available in Gerrit, so you can start