Re: Review Request 120574: Add explicit to ctors with one parameter

2014-10-13 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/#review68341 --- I think it's not allowed (though better ask Kevin or David) in

Re: platforms

2014-10-13 Thread Andrius da Costa Ribas
It can be cleaned up ... other WinCE specifics had already been cleaned up in frameworks. 2014-10-13 20:59 GMT-03:00 Jeremy Whiting : > Do we support building and using frameworks on Windows CE anymore? I > don't see it on > http://qt-project.org/doc/qt-4.8/supported-platforms.html so I guess > n

platforms

2014-10-13 Thread Jeremy Whiting
Do we support building and using frameworks on Windows CE anymore? I don't see it on http://qt-project.org/doc/qt-4.8/supported-platforms.html so I guess not, is that correct? If not I can clean up some old ifdefs in knewstuff sources. thanks, Jeremy ___

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-13 Thread Aleix Pol Gonzalez
> On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: > > src/quickaddons/managedtexturenode.h, line 52 > > > > > > even if will always remain just this member, just to me sure, it should > > be in a dpointer > > A

Review Request 120574: Add explicit to ctors with one parameter

2014-10-13 Thread Jeremy Whiting
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120574/ --- Review request for KDE Frameworks and Jeremy Whiting. Repository: knewstu

I18n issues in frameworks + kf5

2014-10-13 Thread Burkhard Lück
Hi, I have some serious issues/problems with translations in frameworks/kf5: My System: separate user for frameworks/kf5 with ~/Qt5.3.0/ binary/sources/translation with ~/kf5/ up to date build from sources switch in konsole to kf5 user and launch app via commandline or plasmashell -w My ~/.confi

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-13 Thread Marco Martin
> On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: > > src/quickaddons/managedtexturenode.h, line 52 > > > > > > even if will always remain just this member, just to me sure, it should > > be in a dpointer > > A

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/ --- (Updated Oct. 13, 2014, 5:54 p.m.) Review request for KDE Frameworks, Pla

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-13 Thread Aleix Pol Gonzalez
> On Oct. 13, 2014, 1:35 p.m., Marco Martin wrote: > > src/quickaddons/managedtexturenode.h, line 52 > > > > > > even if will always remain just this member, just to me sure, it should > > be in a dpointer I don

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/#review68307 --- Ship it! apart managedtexturenode needing a dpointer, looks g

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-13 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/#review68302 --- src/quickaddons/imagetexturescache.h

Re: Review Request 120550: Use the same strategy as FrameSvgItem and IconItem in QIconItem

2014-10-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120550/ --- (Updated Oct. 13, 2014, 11:13 a.m.) Review request for KDE Frameworks, Da

Re: Moving SVGTextureNode to KDeclarative

2014-10-13 Thread Marco Martin
On Fri, Oct 10, 2014 at 11:37 PM, David Faure wrote: > On Friday 10 October 2014 18:18:40 Marco Martin wrote: > > (but even if it doesn't export symbols > > i'm not sure removing target_link_libraries is bc?) > > Depends if it was a PUBLIC or PRIVATE library (in the target_link_libraries > line).