Re: Review Request 120199: Implement KPluginTrader::query() using KPluginLoader::findPlugins()

2014-10-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120199/#review68284 --- Ship it! Looks good! Sorry, I missed this one earlier. - Dav

Jenkins build is back to stable : plasma-framework_master_qt5 » All,LINBUILDER #831

2014-10-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120267: Don't run kioexec if we are already running it

2014-10-11 Thread David Faure
> On Oct. 11, 2014, 9:03 a.m., David Faure wrote: > > src/core/desktopexecparser.cpp, line 310 > > > > > > I would merge this with the if (useKioexec) line. Otherwise this > > creates a new code path (going dire

Re: Review Request 120075: KArchive: add support for rcc files

2014-10-11 Thread David Faure
> On Oct. 11, 2014, 2:38 p.m., Milian Wolff wrote: > > src/krcc.cpp, line 154 > > > > > > maybe I'm missing something, but this looks like you don't need to > > override it at all when you just delegate to the b

Re: Review Request 120075: KArchive: add support for rcc files

2014-10-11 Thread Milian Wolff
> On Oct. 11, 2014, 2:38 p.m., Milian Wolff wrote: > > src/krcc.h, line 93 > > > > > > scoped pointer? > > David Faure wrote: > Hmm. Not done anywhere else in karchive or frameworks in general. Not > much po

Re: Review Request 120075: KArchive: add support for rcc files

2014-10-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120075/ --- (Updated Oct. 11, 2014, 3:37 p.m.) Status -- This change has been ma

Re: Review Request 120075: KArchive: add support for rcc files

2014-10-11 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120075/#review68270 --- Ship it! Ship It! - Milian Wolff On Oct. 11, 2014, 3:28 p.

Re: Review Request 120267: Don't run kioexec if we are already running it

2014-10-11 Thread Maarten De Meyer
> On Oct. 11, 2014, 9:03 a.m., David Faure wrote: > > src/core/desktopexecparser.cpp, line 310 > > > > > > I would merge this with the if (useKioexec) line. Otherwise this > > creates a new code path (going dire

Re: Review Request 120075: KArchive: add support for rcc files

2014-10-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120075/ --- (Updated Oct. 11, 2014, 3:28 p.m.) Review request for KDE Frameworks, Mar

Re: Review Request 120075: KArchive: add support for rcc files

2014-10-11 Thread David Faure
> On Oct. 11, 2014, 2:38 p.m., Milian Wolff wrote: > > src/krcc.h, line 44 > > > > > > "ar" file? maybe "archive" instead? Copy/paste error from kar.h :-) > On Oct. 11, 2014, 2:38 p.m., Milian Wolff wrote: > >

Jenkins build is back to stable : ktexteditor_master_qt5 #707

2014-10-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: frameworks' cmake configs looking for other things

2014-10-11 Thread Alex Merry
On Friday 10 Oct 2014 17:49:10 Harald Sitter wrote: > Alohas > > as described in [1] I think there is a bit of a problem how we track > inter-dependencies in cmake configs right now (that is: the configs > frameworks install to be found by 3rd party bits). > > If I write a 3rd party software that

Re: blogging about technical details

2014-10-11 Thread Luigi Toscano
Dominik Haumann ha scritto: > Hi all, > > imho, these are changes that get mostly unnoticed, and hence close to no one > will use this feature. I personally would find it very cool if there were > lots > and lots of blogs on the planet for these technical details. It would also > communicate a

Re: Review Request 120443: Add ctags configuration option to highlighting

2014-10-11 Thread Dominik Haumann
> On Oct. 10, 2014, 7:55 p.m., Christoph Cullmann wrote: > > Hi, I think that should not be in KTextEditor. > > Thats really special and given that only a very limited amount of languages > > with ctags specials exists, it would make more sense to just have a > > heuristic in the project plugin

blogging about technical details (was: Re: Review Request 120099: RFC: UI-Files inside resources instead of filesystem)

2014-10-11 Thread Dominik Haumann
Hi all, imho, these are changes that get mostly unnoticed, and hence close to no one will use this feature. I personally would find it very cool if there were lots and lots of blogs on the planet for these technical details. It would also communicate a bit more of the internals to potentially n

Re: Review Request 120075: KArchive: add support for rcc files

2014-10-11 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120075/#review68263 --- Ship it! some small nitpicks from my side :) src/krcc.h

Jenkins build became unstable: ktexteditor_master_qt5 #706

2014-10-11 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Gerrit available for trial

2014-10-11 Thread David Faure
On Saturday 11 October 2014 11:57:20 Kevin Krammer wrote: > On Saturday, 2014-10-11, 11:31:54, David Faure wrote: > > On Saturday 11 October 2014 00:00:53 Jan Kundrát wrote: > > > On Friday, 10 October 2014 23:38:37 CEST, David Faure wrote: > > > > Another issue: could all incoming review requests

Re: Gerrit available for trial

2014-10-11 Thread Kevin Krammer
On Saturday, 2014-10-11, 11:31:54, David Faure wrote: > On Saturday 11 October 2014 00:00:53 Jan Kundrát wrote: > > On Friday, 10 October 2014 23:38:37 CEST, David Faure wrote: > > > Another issue: could all incoming review requests for kio (and all other > > > frameworks in the future, except plas

Re: Gerrit available for trial

2014-10-11 Thread David Faure
On Saturday 11 October 2014 00:00:53 Jan Kundrát wrote: > On Friday, 10 October 2014 23:38:37 CEST, David Faure wrote: > > Another issue: could all incoming review requests for kio (and all other > > frameworks in the future, except plasma-framework which has a > > dedicated list) > > be sent to kd

Re: Review Request 120267: Don't run kioexec if we are already running it

2014-10-11 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120267/#review68253 --- Ah ok so this is not a new bug, but something that would have

Re: Review Request 120393: Restore accidentally(?) removed strigi check

2014-10-11 Thread David Faure
> On Oct. 10, 2014, 9:12 p.m., David Faure wrote: > > right, it's inconsistent - but I wonder, how did this create a problem for > > you? i.e. did you miss the strigi-dependent code? I thought nothing used > > that anymore, and afaik strigi for qt5 doesn't exist? > > Hrvoje Senjan wrote: >

Re: Whoopsie in KF5::WindowSystem 5.3.0

2014-10-11 Thread David Faure
On Friday 10 October 2014 23:03:26 Nicolás Alvarez wrote: > 2014-10-10 19:47 GMT-03:00 David Faure : > > On Friday 10 October 2014 17:14:41 Martin Graesslin wrote: > >> I recommend to either do a 5.3.1 > >> release for KWindowSystem with just that commit added > > > > Done. > > > > kwindowsystem

Re: Review Request 120435: Declare InheritanceChecker before actual use

2014-10-11 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120435/ --- (Updated Oct. 11, 2014, 8:40 a.m.) Status -- This change has been ma