Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-28 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120360/ --- (Updated Sept. 29, 2014, 6:30 a.m.) Review request for KDE Frameworks and

Re: Review Request 120361: Force kpagewidget layout's margin to zero when embedded in kpagedialog, to enforce alignment with buttonbox

2014-09-28 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120361/ --- (Updated Sept. 29, 2014, 6:28 a.m.) Status -- This change has been m

Re: Review Request 120361: Force kpagewidget layout's margin to zero when embedded in kpagedialog, to enforce alignment with buttonbox

2014-09-28 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120361/ --- (Updated Sept. 29, 2014, 6:27 a.m.) Review request for KDE Frameworks and

Re: Review Request 120408: Port textcreator thumbnailer

2014-09-28 Thread Christoph Feck
> On Sept. 28, 2014, 10:47 p.m., Christoph Feck wrote: > > Ship It! Please CC bug 339456. - Christoph --- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/#review67599

Re: Review Request 120408: Port textcreator thumbnailer

2014-09-28 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/#review67599 --- Ship it! Ship It! - Christoph Feck On Sept. 28, 2014, 10:4

Re: Review Request 120408: Port textcreator thumbnailer

2014-09-28 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/ --- (Updated Sept. 28, 2014, 10:41 p.m.) Review request for KDE Frameworks.

Re: Review Request 120408: Port textcreator thumbnailer

2014-09-28 Thread Christoph Feck
> On Sept. 28, 2014, 8:58 p.m., Christoph Feck wrote: > > thumbnail/CMakeLists.txt, line 110 > > > > > > Could you make this line match the previous version (one space after > > first #) for consistency with the

Re: Review Request 120408: Port textcreator thumbnailer

2014-09-28 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/#review67589 --- thumbnail/CMakeLists.txt

Re: Review Request 120408: Port textcreator thumbnailer

2014-09-28 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/#review67586 --- I suggest to keep the KEncodingProber code for now, as the cha

Re: Review Request 120408: Port textcreator thumbnailer

2014-09-28 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/#review67584 --- ah, the QGuiApplication does the trick :D i had almost identic

baloo fails to compile

2014-09-28 Thread Andriy Rysin
I cleaned all build and install files but baloo refuses to compile in master: -- Found Gettext: /usr/bin/msgmerge (found version "0.18.3") -- Found PythonInterp: /usr/bin/python (found version "2.7.5") -- Found KF5I18n: /home/kde5dev/kde5/install/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found vers

Review Request 120408: Port textcreator thumbnailer

2014-09-28 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120408/ --- Review request for KDE Frameworks. Repository: kio-extras Description -

Re: Review Request 120382: Port comicbook thumbnailer to KF5

2014-09-28 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120382/ --- (Updated Sept. 28, 2014, 3:46 p.m.) Status -- This change has been m

Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #792

2014-09-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #792

2014-09-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel