Jenkins build is back to normal : karchive_master_qt5 #77

2014-09-27 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: karchive_master_qt5 #76

2014-09-27 Thread KDE CI System
See Changes: [nicolas.alvarez] Replace variable-length arrays with dynamically allocated memory. -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on L

Re: Review Request 119607: Support for ".hidden" files

2014-09-27 Thread David Faure
> On Sept. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > src/core/kcoredirlister.cpp, line 2799 > > > > > > This will only work for local files. I'm not sure if we would want to > > support the ".hidden" me

Review Request 120393: Restore accidentally(?) removed strigi check

2014-09-27 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120393/ --- Review request for KDE Frameworks. Repository: kdelibs4support Descript

Re: Review Request 120382: Port comicbook thumbnailer to KF5

2014-09-27 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120382/#review67526 --- Ship it! - David Edmundson On Sept. 27, 2014, 10:12 a.m., M

Re: Review Request 120388: Do not sync if wallet file does not exist

2014-09-27 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/#review67522 --- src/runtime/kwalletd/backend/kwalletbackend.cc

Review Request 120388: Do not sync if wallet file does not exist

2014-09-27 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120388/ --- Review request for KDE Frameworks. Repository: kwallet Description

Review Request 120387: 'walletListDirty' signal should be emitted if the 'kwalletd' directory is deleted

2014-09-27 Thread Arjun AK
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120387/ --- Review request for KDE Frameworks. Repository: kwallet Description

Re: Review Request 119607: Support for ".hidden" files

2014-09-27 Thread Bruno Nova
> On Set. 14, 2014, 3:27 p.m., Frank Reininghaus wrote: > > src/core/kcoredirlister.cpp, line 2799 > > > > > > This will only work for local files. I'm not sure if we would want to > > support the ".hidden" mec

Re: Review Request 120382: Port comicbook thumbnailer to KF5

2014-09-27 Thread Maarten De Meyer
> On Sept. 26, 2014, 10:51 p.m., Martin Klapetek wrote: > > thumbnail/comiccreator.cpp, line 323 > > > > > > You shouldn't need this include unless you have a class with the > > Q_OBJECT macro in the .cpp file (

Re: Review Request 120382: Port comicbook thumbnailer to KF5

2014-09-27 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120382/ --- (Updated Sept. 27, 2014, 10:12 a.m.) Review request for KDE Frameworks.

Re: Review Request 120382: Port comicbook thumbnailer to KF5

2014-09-27 Thread Maarten De Meyer
> On Sept. 26, 2014, 10:44 p.m., David Edmundson wrote: > > thumbnail/comiccreator.cpp, line 227 > > > > > > Why do we run unrar manually when we're already linking against > > karchive elsewhere? > > > >