Re: Re: Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11, LINBUILDER #784

2014-09-25 Thread Martin Gräßlin
On Thursday 25 September 2014 19:40:29 Marco Martin wrote: > On Thursday 25 September 2014 19:02:09 Aleix Pol wrote: > > On Thu, Sep 25, 2014 at 6:12 PM, KDE CI System wrote: > > > See < > > > http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,lab > > > el > > > =LINBUILDER/chang

Re: Review Request 120324: Simplify CMake code for DTD generation (WIN32/non-WIN32)

2014-09-25 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120324/ --- (Updated Set. 26, 2014, 12:56 a.m.) Status -- This change has been d

Re: Review Request 120324: Simplify CMake code for DTD generation (WIN32/non-WIN32)

2014-09-25 Thread Luigi Toscano
> On Set. 23, 2014, 12:53 a.m., Luigi Toscano wrote: > > Re-reading the code and the comments, the core of the problem is described > > later, in another part which should be touched by the patch. The comment > > says: > > > > # WARNING: this has severe limitations on the windows platform sinc

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #120

2014-09-25 Thread KDE CI System
See Changes: [ahartmetz] Make this wrong in a way that at least compiles. -- [...truncated 2293 lines...] KUrl::List uris = selectedUrls(); ^

Re: Review Request 120324: Simplify CMake code for DTD generation (WIN32/non-WIN32)

2014-09-25 Thread Patrick Spendrin
> On Sept. 22, 2014, 10:53 nachm., Luigi Toscano wrote: > > Re-reading the code and the comments, the core of the problem is described > > later, in another part which should be touched by the patch. The comment > > says: > > > > # WARNING: this has severe limitations on the windows platform s

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-25 Thread Hugo Pereira Da Costa
> On Sept. 25, 2014, 7:17 p.m., Christoph Feck wrote: > > I reopened the issue Kai raised. > > Hugo Pereira Da Costa wrote: > Why ? I did fix it I think, in the new uploaded diff. (and added comment > that I can take out if you ask) ah crap forget it. I forgot the spaces after 'if' Will fi

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-25 Thread Hugo Pereira Da Costa
> On Sept. 25, 2014, 7:17 p.m., Christoph Feck wrote: > > I reopened the issue Kai raised. Why ? I did fix it I think, in the new uploaded diff. (and added comment that I can take out if you ask) - Hugo --- This is an automatically gen

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-25 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120360/#review67446 --- I reopened the issue Kai raised. - Christoph Feck On Sept.

Re: Review Request 120361: Force kpagewidget layout's margin to zero when embedded in kpagedialog, to enforce alignment with buttonbox

2014-09-25 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120361/#review67445 --- Ship it! Commit it without the comment and the blank line bef

Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #785

2014-09-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #785

2014-09-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11, LINBUILDER #784

2014-09-25 Thread Marco Martin
On Thursday 25 September 2014 19:02:09 Aleix Pol wrote: > On Thu, Sep 25, 2014 at 6:12 PM, KDE CI System wrote: > > See < > > http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label > > =LINBUILDER/changes > It's been some days with this. Do we know what's wrong with the dialogt

Re: Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #784

2014-09-25 Thread Aleix Pol
On Thu, Sep 25, 2014 at 6:12 PM, KDE CI System wrote: > See < > http://build.kde.org/job/plasma-framework_master_qt5/Variation=NoX11,label=LINBUILDER/changes > > > It's been some days with this. Do we know what's wrong with the dialogtest? Aleix ___ K

Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #784

2014-09-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #784

2014-09-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #783

2014-09-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #783

2014-09-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-25 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120360/ --- (Updated Sept. 25, 2014, 3:32 p.m.) Review request for KDE Frameworks and

Re: Review Request 120185: Look for kdesu in the correct location

2014-09-25 Thread Maarten De Meyer
> On Sept. 16, 2014, 10:33 a.m., Marco Martin wrote: > > this approach is probably better than > > https://git.reviewboard.kde.org/r/120040/ > > Maarten De Meyer wrote: > I think we'll need both. We still need to rename the kdesu binary, no? > > Marco Martin wrote: > if it goes in libe

Re: Review Request 120361: Force kpagewidget layout's margin to zero when embedded in kpagedialog, to enforce alignment with buttonbox

2014-09-25 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120361/#review67420 --- +1 It does look much better, thanks for looking into this. -

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-25 Thread Hugo Pereira Da Costa
> On Sept. 25, 2014, 1:09 p.m., Kai Uwe Broulik wrote: > > File Attachment: config-after.png - config-after.png > > > > > > What is that gray are at the bottom? It's not present in the before > > screenshot. an artifact from the decora

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120360/#review67418 --- src/kpagewidget.cpp

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-25 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120360/#review67417 --- File Attachment: config-after.png - config-after.png

Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #782

2014-09-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #782

2014-09-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 120361: Force kpagewidget layout's margin to zero when embedded in kpagedialog, to enforce alignment with buttonbox

2014-09-25 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120361/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget

Re: Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-25 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120360/ --- (Updated Sept. 25, 2014, 12:33 p.m.) Review request for KDE Frameworks an

Review Request 120360: force layout to zero when adding page to force alignment with title widget

2014-09-25 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120360/ --- Review request for KDE Frameworks and Christoph Feck. Repository: kwidget

Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #781

2014-09-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #781

2014-09-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » NoX11,LINBUILDER #780

2014-09-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is still unstable: plasma-framework_master_qt5 » All,LINBUILDER #780

2014-09-25 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Split kde-baseapps?

2014-09-25 Thread David Edmundson
libkonq was discussed in the frameworks BOF at Akademy. Some parts (konqoperations and such) will go into the KIO framework. I think this has already been started. The rest will move into konqueror ___ Kde-frameworks-devel mailing list Kde-frameworks-dev

Re: Split kde-baseapps?

2014-09-25 Thread Treeve Jelbert
On Wednesday 24 September 2014 17:39:42 Luca Beltrame wrote: > Michael Palimaka wrote: > > Are there any plans to split frameworks-based kde-baseapps? > > IMO it would make sense first to consult with the various applications' > maintainers and / or review what's in there and what should happen to