Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-13 Thread Matthew Dawson
On September 12, 2014 03:19:13 AM Ben Cooksley wrote: > > On Sept. 8, 2014, 10:22 p.m., Ben Cooksley wrote: > > Matthew Dawson wrote: > > I don't think upstream would be happy with the patch, as it hijacks > > the moderator emails (which should link to the admin page) to send > > out no

Re: Review Request 120139: kill warning

2014-09-13 Thread Andreas Hartmetz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120139/#review66446 --- It looks like the warning is indeed misguided, but it is not c

Re: Review Request 120173: Add unicode emoticons to Glass theme

2014-09-13 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120173/ --- (Updated Sept. 13, 2014, 10:27 p.m.) Status -- This change has been

Re: Review Request 120173: Add unicode emoticons to Glass theme

2014-09-13 Thread David Gil Oliva
> On set. 12, 2014, 9:31 p.m., Eike Hein wrote: > > This is a pretty complex problem area. I hesitantly agree that adding the > > Unicode emojis to KEmoticons is probably a good stopgap solution (and I'd > > recommend also adding DoCoMo's private area mappings, since they're widely > > used as

Jenkins build is back to stable : frameworkintegration_master_qt5 #111

2014-09-13 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kio_master_qt5 #354

2014-09-13 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120187: Make data tables static const.

2014-09-13 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120187/ --- (Updated Sept. 13, 2014, 8 p.m.) Status -- This change has been mark

Re: Review Request 120187: Make data tables static const.

2014-09-13 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120187/#review66429 --- Ship it! yay - Milian Wolff On Sept. 13, 2014, 5:19 p.m.,

Re: kio_trash

2014-09-13 Thread Luigi Toscano
Luigi Toscano ha scritto: > Nicolás Alvarez ha scritto: >> 2014-09-13 15:13 GMT-03:00 Nicolás Alvarez : >>> Done. The resulting history looks kind of weird though, because we >>> have the full history of kio_trash but only partial history of kio, if >>> you didn't graft kdelibs in. >> >> In fact,

Re: kio_trash

2014-09-13 Thread Luigi Toscano
Nicolás Alvarez ha scritto: > 2014-09-13 15:13 GMT-03:00 Nicolás Alvarez : >> 2014-09-09 12:22 GMT-03:00 David Faure : >>> On Sunday 17 August 2014 00:03:41 David Faure wrote: kio_trash is currently in kde-workspace/kio-extras, but KIO actually offers API that depends on kio_trash (KIO::t

Re: kio_trash

2014-09-13 Thread Nicolás Alvarez
2014-09-13 15:13 GMT-03:00 Nicolás Alvarez : > 2014-09-09 12:22 GMT-03:00 David Faure : >> On Sunday 17 August 2014 00:03:41 David Faure wrote: >>> kio_trash is currently in kde-workspace/kio-extras, but KIO actually offers >>> API that depends on kio_trash (KIO::trash(), JobUiDelegateExtension::Tr

Re: kio_trash

2014-09-13 Thread Nicolás Alvarez
2014-09-09 12:22 GMT-03:00 David Faure : > On Sunday 17 August 2014 00:03:41 David Faure wrote: >> kio_trash is currently in kde-workspace/kio-extras, but KIO actually offers >> API that depends on kio_trash (KIO::trash(), JobUiDelegateExtension::Trash, >> support for trash in FileUndoManager, and

Review Request 120187: Make data tables static const.

2014-09-13 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120187/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti

Re: Review Request 120186: Make the encoding prober data tables const.

2014-09-13 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120186/ --- (Updated Sept. 13, 2014, 4:52 p.m.) Status -- This change has been m

Re: Review Request 120186: Make the encoding prober data tables const.

2014-09-13 Thread Volker Krause
> On Sept. 13, 2014, 4:20 p.m., Milian Wolff wrote: > > Cool, looks like a no-brained to me. Could we also wrap these things in > > anonymous namespaces to give them file-local linkage? Right, there's still 9256 bytes in .data.rel.ro, at least half of which we can probably get to .rodata as we

Re: Review Request 120186: Make the encoding prober data tables const.

2014-09-13 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120186/#review66415 --- Ship it! Cool, looks like a no-brained to me. Could we also w

Review Request 120186: Make the encoding prober data tables const.

2014-09-13 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120186/ --- Review request for KDE Frameworks. Repository: kcodecs Description

Review Request 120185: Look for kdesu in the correct location

2014-09-13 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120185/ --- Review request for KDE Frameworks and David Faure. Bugs: 338755 https

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

2014-09-13 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120160/#review66411 --- Nice, I think I've seen this behavior before and always wonder

Re: Porting uses of 'accuracy' in KMimeType API

2014-09-13 Thread Milian Wolff
On Friday 12 September 2014 21:06:36 Kevin Funk wrote: > On Friday 12 September 2014 10:50:36 David Faure wrote: > > On Friday 12 September 2014 09:39:42 Kevin Funk wrote: > > > Heya, > > > > > > Context: Forward-porting some patches in KDevelop involving KMimeType > > > API. > > > > > > I've jus

Review Request 120184: Remove dead code.

2014-09-13 Thread Volker Krause
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120184/ --- Review request for KDE Frameworks. Repository: karchive Description ---

Jenkins build is back to normal : ktexteditor_master_qt5 #661

2014-09-13 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: ktexteditor_master_qt5 #660

2014-09-13 Thread KDE CI System
See Changes: [svenbrauch] template handler: more tests, more documentation -- [...truncated 1110 lines...] [ 58%] Building CXX object src/CMakeFiles/KF5TextEditor.dir/utils/attribute.cpp.o [ 58

Re: Review Request 120158: [kwindowsystem] Add support for urgency hint in NETWinInfo

2014-09-13 Thread Martin Gräßlin
> On Sept. 12, 2014, 3:26 nachm., Thomas Lübking wrote: > > src/netwm.cpp, line 4562 > > > > > > #include is not an option? > > Martin Gräßlin wrote: > nope, distros still have problems with it (see workar

Re: Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

2014-09-13 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120160/#review66388 --- Looks sensible, +1 ...also thanks for the test! - Martin Kla