Re: Review Request 120173: Add unicode emoticons to Glass theme

2014-09-12 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120173/#review66379 --- Ship it! This is a pretty complex problem area. I hesitantly

Review Request 120173: Add unicode emoticons to Glass theme

2014-09-12 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120173/ --- Review request for KDE Frameworks. Repository: kemoticons Description -

Re: Porting uses of 'accuracy' in KMimeType API

2014-09-12 Thread Kevin Funk
On Friday 12 September 2014 10:50:36 David Faure wrote: > On Friday 12 September 2014 09:39:42 Kevin Funk wrote: > > Heya, > > > > Context: Forward-porting some patches in KDevelop involving KMimeType API. > > > > I've just noticed that in Qt5, QMimeDataBase/QMimeType doesn't allow me to > > retr

Re: Review Request 120158: [kwindowsystem] Add support for urgency hint in NETWinInfo

2014-09-12 Thread Thomas Lübking
> On Sept. 12, 2014, 1:26 nachm., Thomas Lübking wrote: > > src/netwm.cpp, line 4562 > > > > > > #include is not an option? > > Martin Gräßlin wrote: > nope, distros still have problems with it (see workar

kconfigwidgets should install have kf5_entry.desktop

2014-09-12 Thread Albert Astals Cid
Hi David, kf-ers KLanguageButton is using kf5_entry.desktop as seen on http://lxr.kde.org/search?v=kf5-qt5&_filestring=&_string=+KLanguageButton It seems that the packaging scripts are not aware of it and thus it is not getting packaged/installed. David can you make sure the files get packaged

Re: Review Request 120165: Add support for input hint in NETWinInfo

2014-09-12 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120165/#review66349 --- Ship it! src/netwm.cpp

Re: Review Request 120165: Add support for input hint in NETWinInfo

2014-09-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120165/ --- (Updated Sept. 12, 2014, 4:23 p.m.) Review request for KDE Frameworks.

Re: Review Request 120165: Add support for input hint in NETWinInfo

2014-09-12 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120165/#review66348 --- src/netwm.cpp

Review Request 120165: Add support for input hint in NETWinInfo

2014-09-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120165/ --- Review request for KDE Frameworks and kwin. Repository: kwindowsystem D

Re: Review Request 120158: [kwindowsystem] Add support for urgency hint in NETWinInfo

2014-09-12 Thread Martin Gräßlin
> On Sept. 12, 2014, 3:26 p.m., Thomas Lübking wrote: > > src/netwm.cpp, line 4562 > > > > > > #include is not an option? nope, distros still have problems with it (see workaround we have in KWin). - Martin

Re: Review Request 120158: [kwindowsystem] Add support for urgency hint in NETWinInfo

2014-09-12 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120158/#review66343 --- src/netwm.cpp

Review Request 120160: KMessageWidget: fix handling of rapid succession of animatedHide+animatedShow calls

2014-09-12 Thread Fabio D'Urso
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120160/ --- Review request for KDE Frameworks, Christoph Feck and Aurélien Gâteau. Re

Build failed in Jenkins: kde-baseapps_frameworks_qt5 #110

2014-09-12 Thread KDE CI System
See Changes: [emmanuelpescosta099] Ported KIcon to QIcon -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILD

Re: Review Request 120155: Correctly load non-square icons in KIconLoader

2014-09-12 Thread Dan Vrátil
> On Sept. 12, 2014, 12:49 p.m., Christoph Feck wrote: > > Use KPixmapSequence if you need to access an FDO animation icon. That's the thing: I want to feed the animation icon to KPixmapSequence, but KPixmapSequence only accepts full file path, or QPixmap. And I can't get the filename without

Re: Review Request 120155: Correctly load non-square icons in KIconLoader

2014-09-12 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120155/#review66332 --- Use KPixmapSequence if you need to access an FDO animation ico

Re: There's no proper replacement for KIcon

2014-09-12 Thread Albert Astals Cid
El Divendres, 12 de setembre de 2014, a les 12:04:38, Allan Sandfeld Jensen va escriure: > On Wednesday 03 September 2014, Albert Astals Cid wrote: > > Porting guide lies in saying that KIcon should be replaced with > > QIcon::fromTheme since KIcon defauted to oxygen icon theme and obviously > > Q

Re: Gerrit available for trial

2014-09-12 Thread Jan Kundrát
Hi folks, we're trying to document how to work with Gerrit within KDE at [1]. If you can make that page better, please go ahead. With kind regards, Jan [1] https://techbase.kde.org/Development/Gerrit -- Trojitá, a fast Qt IMAP e-mail client -- http://trojita.flaska.net/ __

Re: There's no proper replacement for KIcon

2014-09-12 Thread Allan Sandfeld Jensen
On Wednesday 03 September 2014, Albert Astals Cid wrote: > Porting guide lies in saying that KIcon should be replaced with > QIcon::fromTheme since KIcon defauted to oxygen icon theme and obviously > QIcon::fromTheme doesn't do that. > > Please someone provide a solution for this problem or undepr

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #94

2014-09-12 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Gerrit available for trial

2014-09-12 Thread Kevin Krammer
Hi all, service annoucement for the people who were not so lucky as to being able to participant at this year's Akademy: Jan Kundrát, of Trojita fame, has set up a Gerrit instance [1] connected to the KDE git repository, i.e. it is now possible for KDE projects to opt in to a test of Gerrit fo

Review Request 120158: [kwindowsystem] Add support for urgency hint in NETWinInfo

2014-09-12 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120158/ --- Review request for KDE Frameworks and kwin. Summary (updated) ---

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-12 Thread Denis Steckelmacher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119991/ --- (Updated Sept. 12, 2014, 9:24 a.m.) Status -- This change has been m

Jenkins build became unstable: frameworkintegration_master_qt5 #110

2014-09-12 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120147: Add frame arount KTextEditor::View, with proper handling of focus and mouse over, for widget themes that support it

2014-09-12 Thread Aleix Pol Gonzalez
> On Sept. 11, 2014, 10:19 p.m., Aleix Pol Gonzalez wrote: > > Why is the component responsible for defining how it's going to be visually > > integrated with the host application? > > > > Do we get to hit the scrollbar if the component doesn't have a margin and > > it's by the screen's border

Re: Porting uses of 'accuracy' in KMimeType API

2014-09-12 Thread David Faure
On Friday 12 September 2014 09:39:42 Kevin Funk wrote: > Heya, > > Context: Forward-porting some patches in KDevelop involving KMimeType API. > > I've just noticed that in Qt5, QMimeDataBase/QMimeType doesn't allow me to > retrieve the accuracy of a match anymore, while KMimeType did. For example

Re: Review Request 120155: Correctly load non-square icons in KIconLoader

2014-09-12 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120155/#review66323 --- Not complaining, but the icon spec is about square icons, so t

Review Request 120155: Correctly load non-square icons in KIconLoader

2014-09-12 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120155/ --- Review request for KDE Frameworks. Repository: kiconthemes Description

Porting uses of 'accuracy' in KMimeType API

2014-09-12 Thread Kevin Funk
Heya, Context: Forward-porting some patches in KDevelop involving KMimeType API. I've just noticed that in Qt5, QMimeDataBase/QMimeType doesn't allow me to retrieve the accuracy of a match anymore, while KMimeType did. For example, compare the possible arguments for QMimeDataBase::mimeTypeForUr

Re: Review Request 120138: kshorturifilter : Treat "///..." as "/"

2014-09-12 Thread Arjun Ak
> On Sept. 12, 2014, 2:48 a.m., David Faure wrote: > > src/urifilters/shorturi/kshorturifilter.cpp, line 133 > > > > > > This looks slow. It will go through a very long path, counting the > > number of slashes,

Re: There's no proper replacement for KIcon

2014-09-12 Thread Kevin Krammer
On Thursday, 2014-09-11, 17:56:38, Eike Hein wrote: > On 11.09.2014 17:22, Kevin Krammer wrote: > > Hicolor is there for cases where the setup fails to provide any workspace > > or distribution specific theme. > > Yes. So I'm thinking ahead and telling you how that "setup" looks > like for a works