Re: There's no proper replacement for KIcon

2014-09-10 Thread Kevin Krammer
On Wednesday, 2014-09-10, 23:43:15, Albert Astals Cid wrote: > El Dimarts, 9 de setembre de 2014, a les 16:25:26, Kevin Krammer va escriure: > > On Sunday, 2014-09-07, 10:27:06, Albert Astals Cid wrote: > > > So as I see it, there's three options: > > > * Do nothing, and expect that people have t

Re: OSX/CI: bovo fails to build on branch frameworks

2014-09-10 Thread Marko Käning
Hi Treeve, thanks for supplying your patches. I’ve applied them on the OSX/CI system. :) The patched libkdegames installs fine. But bovo still has problems: /Users/marko/WC/KDECI-builds/bovo/ai/aron/aiboard.cc:450:11: error: non-constant-expression cannot be narrowed from type 'int' to

Re: Review Request 120118: Make code coverage possible in any KDE project

2014-09-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120118/ --- (Updated Sept. 10, 2014, 11:33 p.m.) Review request for Build System and

Re: Review Request 120132: correct documentation for overlays parameter

2014-09-10 Thread Stefan Brüns
> On Sept. 10, 2014, 9:31 p.m., Luigi Toscano wrote: > > I guess this is about frameworks branch. If yes, please ignore it, as it > > has been split into the several framework repositories; check if the issue > > applies in the separate KIconThemes framework. patch applies also to kiconthemes

Re: Review Request 120131: Fix encoding issue in places dialog.

2014-09-10 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120131/#review66197 --- Ship it! Huh, this code went through a lot of history. KDE3:

Re: There's no proper replacement for KIcon

2014-09-10 Thread Albert Astals Cid
El Dimarts, 9 de setembre de 2014, a les 16:25:26, Kevin Krammer va escriure: > On Sunday, 2014-09-07, 10:27:06, Albert Astals Cid wrote: > > So as I see it, there's three options: > > * Do nothing, and expect that people have to set one of > > > > XDG_CURRENT_DESKTOP, KDE_FULL_SESSION, GNOME_DES

Re: There's no proper replacement for KIcon

2014-09-10 Thread Albert Astals Cid
El Dimecres, 10 de setembre de 2014, a les 16:38:55, David Faure va escriure: > On Tuesday 09 September 2014 16:25:26 Kevin Krammer wrote: > > Wouldn't a fourth option be to make sure that hicolor is actually a proper > > fallback as specified? > > > > Applications already are more or less require

Re: Review Request 120132: correct documentation for overlays parameter

2014-09-10 Thread Luigi Toscano
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120132/#review66195 --- I guess this is about frameworks branch. If yes, please ignore

Review Request 120132: correct documentation for overlays parameter

2014-09-10 Thread Stefan Brüns
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120132/ --- Review request for KDE Frameworks. Repository: kdelibs Description

Review Request 120131: Fix encoding issue in places dialog.

2014-09-10 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120131/ --- Review request for KDE Frameworks and David Faure. Bugs: 337642 https

Re: KDE Frameworks 5.2.0 release

2014-09-10 Thread Marko Käning
Hi David, considering the upcoming 5.2.0 release I just wanted to inform you, that there are currently no issues with any framework on OSX/CI. :) Greets, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailm

Re: There's no proper replacement for KIcon

2014-09-10 Thread David Faure
On Tuesday 09 September 2014 16:25:26 Kevin Krammer wrote: > Wouldn't a fourth option be to make sure that hicolor is actually a proper > fallback as specified? > > Applications already are more or less required to install their fallbacks > in hicolor, so the shared icons should be there as well

Re: Review Request 120071: QUrl::fromUserInput in kfilewidget

2014-09-10 Thread David Faure
> On Sept. 5, 2014, 10:14 p.m., David Faure wrote: > > Ship It! > > David Faure wrote: > I reworked this code today, to fix other issues (fromUserInput is wrong > for relative paths, which affected at least other parts of the code). Can you > check that it's still working for you? Thanks.

Re: Review Request 120071: QUrl::fromUserInput in kfilewidget

2014-09-10 Thread Maarten De Meyer
> On Sept. 5, 2014, 10:14 p.m., David Faure wrote: > > Ship It! > > David Faure wrote: > I reworked this code today, to fix other issues (fromUserInput is wrong > for relative paths, which affected at least other parts of the code). Can you > check that it's still working for you? Thanks.

Re: [dot] KDE Frameworks 5.2.0 release

2014-09-10 Thread Mirko Boehm
Hello David, notable changes are: * The maximum worker count will now decrease if a lower value is set after workers have been created. Previously, workers would remain active once they have been created. * Examples from the previous ThreadWeaverDemos Github repository are being merged into the K

Re: [dot] KDE Frameworks 5.2.0 release

2014-09-10 Thread David Faure
On Tuesday 09 September 2014 08:21:02 Carl Symons wrote: > On 09/09/2014 06:57 AM, David Faure wrote: > > I just tagged and packed 5.2.0. > > > > I extracted the following changelog items from git commits. But I don't > > really understand the plasma-framework and threadweaver commits > > Mirk

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-10 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/ --- (Updated Sept. 10, 2014, 8:08 a.m.) Status -- This change has been m

Re: Review Request 119991: Use Juvia to add comments on the API class pages

2014-09-10 Thread Aleix Pol Gonzalez
> On Sept. 8, 2014, 10:22 p.m., Ben Cooksley wrote: > > What is the status of this? Is there anything blocking it being shipped and > > made available on api.kde.org? > > Denis Steckelmacher wrote: > It works locally, so I'm just waiting for a ship-it or other comments :-) > > Aleix Pol Go

Re: Review Request 120118: Make code coverage possible in any KDE project

2014-09-10 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120118/#review66168 --- +1 for the approach. - Martin Gräßlin On Sept. 9, 2014, 6:0