Re: kcoreaddons fails to build properly on OSX/CI (was OSX/CI: kauth fails to build )

2014-09-07 Thread Marko Käning
Hi David, due to me working nonstop over the weekend - on bringing a Jenkins-based OSX/CI slave system to life [1] - I’ve not yet informed you guys that I by now have successfully retried building a newer cmake version (a1eb90c85d80acf9617ccac73a45b6753188947d) as well [2]. Turns out that I was

Re: Review Request 120015: KIO: Save the default application into the group [Default Applications]

2014-09-07 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120015/ --- (Updated Sept. 7, 2014, 11:59 p.m.) Status -- This change has been m

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #93

2014-09-07 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 120012: kde-cli-tools: Save the default application into the group [Default Applications]

2014-09-07 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120012/ --- (Updated Sept. 7, 2014, 11:58 p.m.) Status -- This change has been m

Jenkins build is back to normal : kconfigwidgets_master_qt5 #83

2014-09-07 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: kcoreaddons fails to build properly on OSX/CI (was OSX/CI: kauth fails to build )

2014-09-07 Thread Ben Cooksley
On Sep 8, 2014 11:15 AM, "David Faure" wrote: > > On Wednesday 20 August 2014 22:44:20 Marko Käning wrote: > > I had to revert back to and rebuild the older cmake version now [3], in > > order to be at least partially able to build things. > > [2] cmake revision: 7000a06b06ef3c5d15418b3afb4f0525fa

Re: kcoreaddons fails to build properly on OSX/CI (was OSX/CI: kauth fails to build )

2014-09-07 Thread David Faure
On Wednesday 20 August 2014 22:44:20 Marko Käning wrote: > I had to revert back to and rebuild the older cmake version now [3], in > order to be at least partially able to build things. > [2] cmake revision: 7000a06b06ef3c5d15418b3afb4f0525fa1f688c from June 3rd > [3] cmake revision: 0ee116b7eb1e6

Build failed in Jenkins: kconfigwidgets_master_qt5 #82

2014-09-07 Thread KDE CI System
See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Re: SIC in KIO master

2014-09-07 Thread David Faure
On Sunday 31 August 2014 19:01:01 Harald Sitter wrote: > That being said, IMHO it would be perfectly reasonable to deprecate > the signal OK I did that now, after reverting. I guess you're right, holding our SC/BC promise even in (IMHO) theoretical cases is more important than a bit of clean up

Re: Review Request 120017: kde-cli-tools: Open user mimeapps.list from XDG_CONFIG_HOME

2014-09-07 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120017/ --- (Updated Sept. 7, 2014, 10:45 p.m.) Status -- This change has been m

Re: Review Request 120016: Read mimeapps.list from XDG_CONFIG_HOME and XDG_CONFIG_DIRS

2014-09-07 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120016/ --- (Updated Sept. 7, 2014, 10:11 p.m.) Status -- This change has been m

Re: Review Request 120018: KIO: Open user mimeapps.list from XDG_CONFIG_HOME

2014-09-07 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120018/ --- (Updated Sept. 7, 2014, 10:11 p.m.) Status -- This change has been m

Re: Review Request 120093: Guard too verbose 'KDirWatchPrivate::addEntry: Added File...' message + use same method to output available methods

2014-09-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120093/#review66015 --- Ship it! Ideally this should use qCDebug though (with a call

Re: Review Request 120026: Pass KActionCollection to KHelpMenu for KParts::MainWindow

2014-09-07 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120026/ --- (Updated Sept. 7, 2014, 6:03 nachm.) Status -- This change has been

Re: Review Request 120024: Prevent some false positive critical warnings for KStandardActions

2014-09-07 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120024/ --- (Updated Sept. 7, 2014, 6:03 nachm.) Status -- This change has been

Re: Review Request 120025: Have KStandardAction::create(...) call KActionCollection::setDefaultShortcuts()

2014-09-07 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120025/ --- (Updated Sept. 7, 2014, 6 nachm.) Status -- This change has been dis

Re: Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-07 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/#review66006 --- I would suggest to use QVarLengthArray instead. - Christoph F

Re: OSX/CI: kate uses invalid category

2014-09-07 Thread Marko Käning
On 07 Sep 2014, at 13:34 , Dominik Haumann wrote: > On Saturday, September 06, 2014 02:54:04 PM Marko Käning wrote: >> When building kate I suddenly see tons of these warnings popping up: > > Rename to *-apps-*.png. Can you try again? There is only one left: --- 17:27:59 Icon debug-kategdb.png

Review Request 120096: replace static arrays with dynamic size with QVector

2014-09-07 Thread Patrick Spendrin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120096/ --- Review request for KDE Frameworks and kdewin. Repository: karchive Desc

Re: OSX/CI: kate uses invalid category

2014-09-07 Thread Dominik Haumann
On Saturday, September 06, 2014 02:54:04 PM Marko Käning wrote: > When building kate I suddenly see tons of these warnings popping up: Rename to *-apps-*.png. Can you try again? Thanks, Dominik > CMake Warning at > /opt/kde/install/darwin/mavericks/clang/kf5-qt5/kdesupport/extra-cmake-modu > les

Re: Review Request 120092: Turn KFormat into Q_GADGET and expose DurationFormat

2014-09-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120092/ --- (Updated Sept. 7, 2014, 1:49 p.m.) Review request for KDE Frameworks and

Re: Review Request 120093: Guard too verbose 'KDirWatchPrivate::addEntry: Added File...' message + use same method to output available methods

2014-09-07 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120093/ --- (Updated Sept. 7, 2014, 1:29 p.m.) Review request for KDE Frameworks and

Review Request 120093: Guard too verbose 'KDirWatchPrivate::addEntry: Added File...' message

2014-09-07 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120093/ --- Review request for KDE Frameworks and David Faure. Repository: kcoreaddon

Re: Review Request 120088: Fix the warning about setDefaultShortcut for stdactions

2014-09-07 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120088/ --- (Updated Sept. 7, 2014, 11:33 a.m.) Status -- This change has been m

Re: Review Request 120078: workaround QTBUG-40584

2014-09-07 Thread Thomas Lübking
> On Sept. 6, 2014, 12:46 nachm., Lukáš Tinkl wrote: > > [ 22%] Building CXX object src/CMakeFiles/KF5XmlGui.dir/kmainwindow.cpp.o > > > > > > /home/ltinkl/git/plasma-ne

Re: Review Request 120078: workaround QTBUG-40584

2014-09-07 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120078/ --- (Updated Sept. 7, 2014, 11:02 a.m.) Status -- This change has been m

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-09-07 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119977/ --- (Updated Sept. 7, 2014, 9:21 a.m.) Status -- This change has been ma

Re: Interesting issue with KAboutData and icons

2014-09-07 Thread David Faure
On Monday 18 August 2014 10:08:53 Harald Sitter wrote: > On Mon, Aug 18, 2014 at 9:41 AM, David Faure wrote: > > On Monday 04 August 2014 22:01:15 Michael Pyne wrote: > >> Hi all, > >> > >> I received a bug (https://bugs.kde.org/show_bug.cgi?id=337938) reported > >> against KAboutData in KCoreAdd

Re: Review Request 120088: Fix the warning about setDefaultShortcut for stdactions

2014-09-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120088/#review65958 --- Ship it! src/kstandardaction.cpp

Re: Review Request 120088: Fix the warning about setDefaultShortcut for stdactions

2014-09-07 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120088/ --- (Updated Sept. 7, 2014, 8:44 a.m.) Review request for KDE Frameworks and

Review Request 120088: Fix the warning about setDefaultShortcut for stdactions

2014-09-07 Thread Christoph Cullmann
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120088/ --- Review request for KDE Frameworks and David Faure. Repository: kconfigwid

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-09-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119977/#review65948 --- Ship it! Yes, this is indeed the best solution. Let people us

Re: There's no proper replacement for KIcon

2014-09-07 Thread Albert Astals Cid
El Dijous, 4 de setembre de 2014, a les 14:04:04, Kevin Ottens va escriure: > On Thursday 04 September 2014 11:36:38 Martin Klapetek wrote: > > On Wed, Sep 3, 2014 at 10:10 PM, Eike Hein wrote: > > > On 09/03/2014 10:07 PM, Nicolás Alvarez wrote: > > >> So if I'm not in a Plasma session I get no i

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-07 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/ --- (Updated Sept. 7, 2014, 7:57 a.m.) Review request for Build System, KDE F

Re: Review Request 120058: Move imagethumbnailer away from KDE4Support

2014-09-07 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120058/#review65944 --- Ship it! Ship It! - David Faure On Sept. 5, 2014, 4:56 p.m