Re: Review Request 120062: KActionCollection::setDefaultShortcuts now makes the shortcut active too.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120062/#review65873 --- Ship it! Ship It! - Kevin Ottens On Sept. 5, 2014, 8:39 a.

Re: Review Request 119936: Fix inconsistencies in KPluginInfo and add a basic unit test

> On Sept. 5, 2014, 11:58 nachm., David Faure wrote: > > src/services/kplugininfo.cpp, line 95 > > > > > > can't that lead to a crash if people use other methods after that? Well, it is the same as when KPluginIn

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

> On Sept. 6, 2014, 12:07 vorm., David Faure wrote: > > Between KService, KPluginInfo (.desktop) and KPluginMetaData (json) (all of > > which represent a plugin), it's getting a bit confusing :) > > But I can't see anything wrong in this commit :) My plan is to implement KPluginInfo based on KP

Re: Review Request 120025: Have KStandardAction::create(...) call KActionCollection::setDefaultShortcuts()

> On Sept. 1, 2014, 7:55 vorm., David Faure wrote: > > You wrote: "I have not yet completely grasped the concept of the default > > shortcuts and why they are set only explicitely via > > KActionCollection::setDefaultShortcuts." > > > > I think the concept is simple. QAction only knows "the cu

Jenkins build is still unstable: kwindowsystem_master_qt5 » All,LINBUILDER #92

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119958: Fix thumbnails for mimetype groups.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119958/#review65869 --- I wouldn't recommend implementing support for groups in KServi

Re: Review Request 120040: Install kdesu under bin

On Sept. 2, 2014, 6:37 p.m., Marco Martin wrote: > > I'm a bit worried by the multitude of user and distro specific scripts that > > rely on kdesu being present :/ > > Marco Martin wrote: > to me either way it gets fixed i'm ok. > the other option is to keep it called kdesu, so it would

Jenkins build became unstable: frameworkintegration_master_qt5 #105

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Error building KService

On Friday 05 September 2014 23:48:24 David Gil Oliva wrote: > In file included from /usr/include/kexportplugin.h:21:0, > /usr/include/kglobal.h:4 It's picking up kdelibs4 headers from /usr/include. Easy solution: remove kdelibs4-dev or whatever that package is called. Correct solution: make VERB

Review Request 120075: KArchive: add support for rcc files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120075/ --- Review request for KDE Frameworks. Repository: karchive Description ---

Re: Review Request 120071: QUrl::fromUserInput in kfilewidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120071/#review65867 --- Ship it! Ship It! - David Faure On Sept. 5, 2014, 6:31 p.m

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/#review65866 --- Ah wait, I do: lots of @since 5.2 missing in api docs. And a

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/#review65865 --- Ship it! Between KService, KPluginInfo (.desktop) and KPlugin

Re: Review Request 119975: KDBusService shouldn't crash upon bad application name

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119975/#review65864 --- Ship it! Ship It! - David Faure On Aug. 28, 2014, 3:57 p.m

Re: Review Request 119936: Fix inconsistencies in KPluginInfo and add a basic unit test

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119936/#review65863 --- Ship it! src/services/kplugininfo.h

Error building KService

Hi! I get this error when building KService. I don't quite get it, what it means. Could someone help me deciphering the error? Thanks! David Gil # kdesrc-build running: 'make' '-j2' # from directory: /home/david/devel/kf5-development/build/frameworks/kservice Scanning dependencies of target -ho

Re: What to do with autostart scripts? (kinit / ksmserver problem)

On Tuesday 02 September 2014 11:06:02 Luca Beltrame wrote: > In data martedì 19 agosto 2014 21:48:04, David Faure ha scritto: > > I'd pick option 1 - do it all in ksmserver. > > I suppose this would mean running all but .desktop files (which are handled > by kinit)? I thought "all" was clear ;) I

Re: Review Request 119594: fix FileDialog size restorage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119594/ --- (Updated Sept. 5, 2014, 7:01 p.m.) Status -- This change has been ma

Review Request 120071: QUrl::fromUserInput in kfilewidget

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120071/ --- Review request for KDE Frameworks and David Faure. Bugs: 337557 https

Re: Review Request 120058: Move imagethumbnailer away from KDE4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120058/ --- (Updated Sept. 5, 2014, 4:56 p.m.) Review request for KDE Frameworks. R

Re: Review Request 119798: Generating PkgConfig files from ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review65841 --- Sorry to still be nitpicking documentation, but I view it as o

Re: Review Request 120062: KActionCollection::setDefaultShortcuts now makes the shortcut active too.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120062/#review65826 --- Looks like good idea. - Christoph Cullmann On Sept. 5, 2014

Re: Review Request 120062: KActionCollection::setDefaultShortcuts now makes the shortcut active too.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120062/#review65825 --- For me it's better. I like it. For me "Ship it" is a good ide

Re: Review Request 120062: KActionCollection::setDefaultShortcuts now makes the shortcut active too.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120062/ --- (Updated Sept. 5, 2014, 8:39 a.m.) Review request for KDE Frameworks, Chr

Review Request 120062: KActionCollection::setDefaultShortcuts now makes the shortcut active too.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120062/ --- Review request for KDE Frameworks, Christoph Cullmann, Kevin Ottens, and F