Re: Review Request 120058: Move imagethumbnailer away from KDE4Support

2014-09-04 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120058/#review65817 --- thumbnail/imagecreator.h

Re: Review Request 120058: Move imagethumbnailer away from KDE4Support

2014-09-04 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120058/#review65808 --- Ship it! Ship It! - Sebastian Kügler On Sept. 4, 2014, 3:4

Re: Review Request 119594: fix FileDialog size restorage

2014-09-04 Thread Thomas Lübking
> On Aug. 4, 2014, 1 nachm., Lukáš Tinkl wrote: > > Great, this works for me :) Now what about > > https://git.reviewboard.kde.org/r/119593/ Sorry, I somehow missed this comment. https://git.reviewboard.kde.org/r/119593/ will make processing more robust - as long as the restore happens while

Re: Review Request 119958: Fix thumbnails for mimetype groups.

2014-09-04 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119958/ --- (Updated Sept. 4, 2014, 3:43 p.m.) Review request for KDE Frameworks and

Review Request 120058: Move imagethumbnailer away from KDE4Support

2014-09-04 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120058/ --- Review request for KDE Frameworks. Repository: kio-extras Description -

Re: There's no proper replacement for KIcon

2014-09-04 Thread Eike Hein
On 04.09.2014 14:21, Luigi Toscano wrote: What I don't understand here: is this Qt plugin a GNOME-specific one, or the generic default one? This is not (only) a GNOME issue; replace GNOME with "generic unknown window manager". I think we need a sane default, if the default is there and it is br

Re: There's no proper replacement for KIcon

2014-09-04 Thread Luigi Toscano
Il 04.09.2014 14:15 Martin Klapetek ha scritto: On Thu, Sep 4, 2014 at 2:04 PM, Kevin Ottens wrote: Spot on. And such a plugin is in fact shipped with Qt, but for some reason isn't loaded in Albert's case. That awfully sounds like a bug to me, hence why my line of argument is that it should be

Re: There's no proper replacement for KIcon

2014-09-04 Thread Martin Klapetek
On Thu, Sep 4, 2014 at 2:04 PM, Kevin Ottens wrote: > > Spot on. And such a plugin is in fact shipped with Qt, but for some reason > isn't loaded in Albert's case. That awfully sounds like a bug to me, hence > why > my line of argument is that it should be investigated and fixed. > Maybe it's al

Re: There's no proper replacement for KIcon

2014-09-04 Thread Kevin Ottens
On Thursday 04 September 2014 11:36:38 Martin Klapetek wrote: > On Wed, Sep 3, 2014 at 10:10 PM, Eike Hein wrote: > > On 09/03/2014 10:07 PM, Nicolás Alvarez wrote: > >> So if I'm not in a Plasma session I get no icons? > > > > If you're not in a Plasma session you don't get the Plasma > > platfo

Re: There's no proper replacement for KIcon

2014-09-04 Thread Martin Klapetek
On Wed, Sep 3, 2014 at 10:10 PM, Eike Hein wrote: > > > On 09/03/2014 10:07 PM, Nicolás Alvarez wrote: > >> So if I'm not in a Plasma session I get no icons? >> > > If you're not in a Plasma session you don't get the Plasma > platform plugin. Other platform plugins can drive this as > they prefer