Re: There's no proper replacement for KIcon

2014-09-03 Thread Aleix Pol
On Wed, Sep 3, 2014 at 10:01 PM, Albert Astals Cid wrote: > El Dimecres, 3 de setembre de 2014, a les 21:42:24, Mark Gaiser va > escriure: > > On Wed, Sep 3, 2014 at 7:16 PM, Albert Astals Cid wrote: > > > Porting guide lies in saying that KIcon should be replaced with > > > QIcon::fromTheme sin

Re: Review Request 120049: KDirNotify: Use QUrl::toStringList

2014-09-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120049/#review65781 --- Ship it! Ship It! - Aleix Pol Gonzalez On Sept. 3, 2014, 4

Re: There's no proper replacement for KIcon

2014-09-03 Thread Eike Hein
For the list's benefit, here's a log of a technical discussion we had in #kde-devel as an extension of this thread that went over various aspects of the problem and possible solutions (I've removed some unrelated parts): [23:33] uhm, I have no idea of how it works in details, but I understood

Re: There's no proper replacement for KIcon

2014-09-03 Thread Albert Astals Cid
El Dimecres, 3 de setembre de 2014, a les 23:23:37, Eike Hein va escriure: > On 09/03/2014 11:12 PM, Albert Astals Cid wrote: > > Which attack tone? I merely did a question. > > Yes, a "Did you stop beating your wife?"-type loaded > question casting me as an ally to evil app-breaking > perpetrator

Re: There's no proper replacement for KIcon

2014-09-03 Thread Albert Astals Cid
El Dimecres, 3 de setembre de 2014, a les 23:12:58, Albert Astals Cid va escriure: > El Dimecres, 3 de setembre de 2014, a les 22:26:22, Eike Hein va escriure: > > I don't know how the "ultimate fallback" works when > > there's no suitable plugin. I think the fd.o spec pro- > > scribes the hicolor

Re: There's no proper replacement for KIcon

2014-09-03 Thread Eike Hein
On 09/03/2014 11:12 PM, Albert Astals Cid wrote: Which attack tone? I merely did a question. Yes, a "Did you stop beating your wife?"-type loaded question casting me as an ally to evil app-breaking perpetrators, while answering a specific technical question someone had. What more analysis

Re: There's no proper replacement for KIcon

2014-09-03 Thread Albert Astals Cid
El Dimecres, 3 de setembre de 2014, a les 22:26:22, Eike Hein va escriure: > On 09/03/2014 10:14 PM, Albert Astals Cid wrote: > > Are you suggesting it is acceptable for my apps to regress (compared to > > their kdelibs4 version) and have no icons because they are not being run > > under a Plasma s

Re: There's no proper replacement for KIcon

2014-09-03 Thread Harald Sitter
On Wed, Sep 3, 2014 at 10:26 PM, Eike Hein wrote: > I think the fd.o spec pro- > scribes the hicolor theme then? ^ this > In that case it would > be up to the distro to make sure this works out. That wouldn't help the original issue that we previously had a hardcoded fallback to oxygen, in fac

Re: There's no proper replacement for KIcon

2014-09-03 Thread Eike Hein
On 09/03/2014 10:14 PM, Albert Astals Cid wrote: Are you suggesting it is acceptable for my apps to regress (compared to their kdelibs4 version) and have no icons because they are not being run under a Plasma session? No, I'm not. The context my reply is about was quoted in my email. I hones

Re: There's no proper replacement for KIcon

2014-09-03 Thread Albert Astals Cid
El Dimecres, 3 de setembre de 2014, a les 22:10:52, Eike Hein va escriure: > On 09/03/2014 10:07 PM, Nicolás Alvarez wrote: > > So if I'm not in a Plasma session I get no icons? > > If you're not in a Plasma session you don't get the Plasma > platform plugin. Other platform plugins can drive this

Re: There's no proper replacement for KIcon

2014-09-03 Thread Eike Hein
On 09/03/2014 10:07 PM, Nicolás Alvarez wrote: So if I'm not in a Plasma session I get no icons? If you're not in a Plasma session you don't get the Plasma platform plugin. Other platform plugins can drive this as they prefer. Cheers, Eike ___ Kde

Re: There's no proper replacement for KIcon

2014-09-03 Thread Nicolás Alvarez
2014-09-03 17:05 GMT-03:00 Mark Gaiser : > On Wed, Sep 3, 2014 at 10:01 PM, Albert Astals Cid wrote: >> El Dimecres, 3 de setembre de 2014, a les 21:42:24, Mark Gaiser va escriure: >>> On Wed, Sep 3, 2014 at 7:16 PM, Albert Astals Cid wrote: >>> > Porting guide lies in saying that KIcon should be

Re: There's no proper replacement for KIcon

2014-09-03 Thread Mark Gaiser
On Wed, Sep 3, 2014 at 10:01 PM, Albert Astals Cid wrote: > El Dimecres, 3 de setembre de 2014, a les 21:42:24, Mark Gaiser va escriure: >> On Wed, Sep 3, 2014 at 7:16 PM, Albert Astals Cid wrote: >> > Porting guide lies in saying that KIcon should be replaced with >> > QIcon::fromTheme since KIc

Re: There's no proper replacement for KIcon

2014-09-03 Thread Albert Astals Cid
El Dimecres, 3 de setembre de 2014, a les 21:42:24, Mark Gaiser va escriure: > On Wed, Sep 3, 2014 at 7:16 PM, Albert Astals Cid wrote: > > Porting guide lies in saying that KIcon should be replaced with > > QIcon::fromTheme since KIcon defauted to oxygen icon theme and obviously > > QIcon::fromTh

Re: Review Request 120049: KDirNotify: Use QUrl::toStringList

2014-09-03 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120049/#review65776 --- Ship it! If you want to go really crazy, you could try this a

Re: There's no proper replacement for KIcon

2014-09-03 Thread Mark Gaiser
On Wed, Sep 3, 2014 at 7:16 PM, Albert Astals Cid wrote: > Porting guide lies in saying that KIcon should be replaced with > QIcon::fromTheme since KIcon defauted to oxygen icon theme and obviously > QIcon::fromTheme doesn't do that. > > Please someone provide a solution for this problem or undepr

There's no proper replacement for KIcon

2014-09-03 Thread Albert Astals Cid
Porting guide lies in saying that KIcon should be replaced with QIcon::fromTheme since KIcon defauted to oxygen icon theme and obviously QIcon::fromTheme doesn't do that. Please someone provide a solution for this problem or undeprecate KIcon. This is blocking the porting of my applications. C

Review Request 120049: KDirNotify: Use QUrl::toStringList

2014-09-03 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120049/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

2014-09-03 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/ --- (Updated Sept. 3, 2014, 12:38 p.m.) Status -- This change has been m

Re: Compression of SVG(Z)s in git repositories

2014-09-03 Thread Sebastian Kügler
On Wednesday, September 03, 2014 13:50:01 Milian Wolff wrote: > On Wednesday 03 September 2014 13:35:00 Sebastian Kügler wrote: > > On Tuesday, September 02, 2014 16:50:35 Elias Probst wrote: > > > On 09/02/2014 12:48 PM, Martin Gräßlin wrote: > > > > > > Exactly. This might make sense to be placed

Re: Compression of SVG(Z)s in git repositories

2014-09-03 Thread Mark Gaiser
On Wed, Sep 3, 2014 at 1:35 PM, Sebastian Kügler wrote: > On Tuesday, September 02, 2014 16:50:35 Elias Probst wrote: >> On 09/02/2014 12:48 PM, Martin Gräßlin wrote: >> > On Tuesday 02 September 2014 12:27:11 Sebastian Kügler wrote: >> >> On Monday, September 01, 2014 12:59:04 Elias Probst wrote:

Re: Compression of SVG(Z)s in git repositories

2014-09-03 Thread Milian Wolff
On Wednesday 03 September 2014 13:35:00 Sebastian Kügler wrote: > On Tuesday, September 02, 2014 16:50:35 Elias Probst wrote: > > On 09/02/2014 12:48 PM, Martin Gräßlin wrote: > > > On Tuesday 02 September 2014 12:27:11 Sebastian Kügler wrote: > > >> On Monday, September 01, 2014 12:59:04 Elias Pro

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Marco Martin
> On Set. 1, 2014, 4:53 p.m., David Edmundson wrote: > > I need some the concept explaining, why would a developer set a > > fallbackpackage? > > Is it not always org.kde.breeze.desktop? > > Marco Martin wrote: > It would usually be the packagestructure setting it, in initPackage(), so > s

Re: Compression of SVG(Z)s in git repositories

2014-09-03 Thread Sebastian Kügler
On Tuesday, September 02, 2014 16:50:35 Elias Probst wrote: > On 09/02/2014 12:48 PM, Martin Gräßlin wrote: > > On Tuesday 02 September 2014 12:27:11 Sebastian Kügler wrote: > >> On Monday, September 01, 2014 12:59:04 Elias Probst wrote: > >> > >> Compressed SVG files are way faster to read (it's

Re: Review Request 119798: Generating PkgConfig files from ECM

2014-09-03 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/ --- (Updated Sept. 3, 2014, 10:53 a.m.) Review request for Build System, KDE

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Marco Martin
> On Set. 1, 2014, 4:53 p.m., David Edmundson wrote: > > I need some the concept explaining, why would a developer set a > > fallbackpackage? > > Is it not always org.kde.breeze.desktop? > > Marco Martin wrote: > It would usually be the packagestructure setting it, in initPackage(), so > s

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Aaron J. Seigo
> On Sept. 1, 2014, 4:53 p.m., David Edmundson wrote: > > I need some the concept explaining, why would a developer set a > > fallbackpackage? > > Is it not always org.kde.breeze.desktop? > > Marco Martin wrote: > It would usually be the packagestructure setting it, in initPackage(), so >

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Marco Martin
> On Set. 1, 2014, 4:53 p.m., David Edmundson wrote: > > I need some the concept explaining, why would a developer set a > > fallbackpackage? > > Is it not always org.kde.breeze.desktop? > > Marco Martin wrote: > It would usually be the packagestructure setting it, in initPackage(), so > s

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Aaron J. Seigo
> On Sept. 1, 2014, 4:53 p.m., David Edmundson wrote: > > I need some the concept explaining, why would a developer set a > > fallbackpackage? > > Is it not always org.kde.breeze.desktop? > > Marco Martin wrote: > It would usually be the packagestructure setting it, in initPackage(), so >

Re: Review Request 120029: introduce the concept of package fallback

2014-09-03 Thread Marco Martin
> On Set. 1, 2014, 4:53 p.m., David Edmundson wrote: > > I need some the concept explaining, why would a developer set a > > fallbackpackage? > > Is it not always org.kde.breeze.desktop? > > Marco Martin wrote: > It would usually be the packagestructure setting it, in initPackage(), so > s