Re: Review Request 120016: Read mimeapps.list from XDG_CONFIG_HOME and XDG_CONFIG_DIRS

2014-08-31 Thread Luc Menut
> On août 31, 2014, 6:50 après-midi, David Faure wrote: > > Good point, we don't implement that spec yet. ($desktop-mimeapps.list is > > missing too). > > > > I'm not sure the syntax QStringList = list1 << list2 is portable to all > > compilers. It reads to me like it would modify list1 I

Re: Review Request 120016: Read mimeapps.list from XDG_CONFIG_HOME and XDG_CONFIG_DIRS

2014-08-31 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120016/ --- (Updated août 31, 2014, 8:35 après-midi) Review request for KDE Framework

Re: Review Request 120016: Read mimeapps.list from XDG_CONFIG_HOME and XDG_CONFIG_DIRS

2014-08-31 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120016/#review65610 --- Good point, we don't implement that spec yet. ($desktop-mimea

Re: Review Request 120023: Fix crash in unit test when run with ASAN

2014-08-31 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120023/#review65607 --- src/k7zip.cpp

Re: Review Request 120023: Fix crash in unit test when run with ASAN

2014-08-31 Thread Albert Astals Cid
> On ago. 31, 2014, 4:48 p.m., Milian Wolff wrote: > > src/k7zip.cpp, line 562 > > > > > > personally, I'd prefer the C++ way of casting over unsafe C-style casts > > every time. > > > > Also, what is t

Re: SIC in KIO master

2014-08-31 Thread Harald Sitter
On Fri, Aug 29, 2014 at 8:26 PM, David Faure wrote: > On Tuesday 26 August 2014 16:29:23 Harald Sitter wrote: >> alohas, >> >> it would appear to me that a recent change in kio [1] was rather, >> very, entirely source incompatible (one could argue binary but let's >> not go there). >> >> Say I had

Re: Review Request 120023: Fix crash in unit test when run with ASAN

2014-08-31 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120023/#review65603 --- src/k7zip.cpp

Re: Review Request 120025: Have KStandardAction::create(...) call KActionCollection::setDefaultShortcuts()

2014-08-31 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120025/ --- (Updated Aug. 31, 2014, 4:40 nachm.) Review request for KDE Frameworks.

Re: Review Request 120025: Have KStandardAction::create(...) call KActionCollection::setDefaultShortcuts()

2014-08-31 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120025/ --- (Updated Aug. 31, 2014, 4:38 nachm.) Review request for KDE Frameworks.

Re: Review Request 120026: Pass KActionCollection to KHelpMenu for KParts::MainWindow

2014-08-31 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120026/ --- (Updated Aug. 31, 2014, 4:37 nachm.) Review request for KDE Frameworks.

Review Request 120026: Pass KActionCollection to KHelpMenu for KParts::MainWindow

2014-08-31 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120026/ --- Review request for KDE Frameworks. Repository: kparts Description -

Review Request 120024: Prevent some false positive critical warnings for KStandardActions

2014-08-31 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120024/ --- Review request for KDE Frameworks. Repository: kxmlgui Description

Review Request 120025: Have KStandardAction::create(...) call KActionCollection::setDefaultShortcuts()

2014-08-31 Thread Friedrich W. H. Kossebau
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120025/ --- Review request for KDE Frameworks. Repository: kconfigwidgets Descripti

Re: Review Request 119997: Add documentation to KConfig::sync()

2014-08-31 Thread Matthew Dawson
> On Aug. 31, 2014, 12:57 a.m., Matthew Dawson wrote: > > Thanks for taking a look at this. It appears KConfigBase isn't available > > on api.kde.org as it isn't documented, as kapidox hides such classes by > > default. As KConfigBase is used outside of KConfig, I'd prefer if > > KConfigBase

Re: Review Request 119713: Switch to breeze or oxygen if they are available and icon theme is either not set or hicolor

2014-08-31 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119713/ --- (Updated Aug. 31, 2014, 4:02 p.m.) Status -- This change has been ma

braindump: Node.js interface to create kio slaves? (perhaps for gsoc 2015?)

2014-08-31 Thread Mark Gaiser
Hi, disclaimer: this is just an idea that might be nice to have in the future. I don't want to make this, i merely had the idea which i want to put out in the open. Perhaps this can evolve into a nice gsoc project for 2015? A few days ago i thought: "hmm, i would like to access my google drive fr

Review Request 120023: Fix crash in unit test when run with ASAN

2014-08-31 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120023/ --- Review request for KDE Frameworks, Mario Bensi and Mathieu Tarral. Reposi

Re: Review Request 119997: Add documentation to KConfig::sync()

2014-08-31 Thread Martin Klapetek
> On Srp. 31, 2014, 1:25 dop., Aleix Pol Gonzalez wrote: > > I'm not against the change, but maybe doxygen should be a bit smarter with > > @reimp, no? I guess, it'd be cool actually. On the other hand, even reimpl methods should have its own documentation as their implementation can be differ

Re: Review Request 119997: Add documentation to KConfig::sync()

2014-08-31 Thread Martin Klapetek
> On Srp. 31, 2014, 6:57 dop., Matthew Dawson wrote: > > Thanks for taking a look at this. It appears KConfigBase isn't available > > on api.kde.org as it isn't documented, as kapidox hides such classes by > > default. As KConfigBase is used outside of KConfig, I'd prefer if > > KConfigBase

Review Request 120018: KIO: Open user mimeapps.list from XDG_CONFIG_HOME

2014-08-31 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120018/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Review Request 120017: kde-cli-tools: Open user mimeapps.list from XDG_CONFIG_HOME

2014-08-31 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120017/ --- Review request for KDE Frameworks and David Faure. Repository: kde-cli-to

Review Request 120016: Read mimeapps.list from XDG_CONFIG_HOME and XDG_CONFIG_DIRS

2014-08-31 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120016/ --- Review request for KDE Frameworks and David Faure. Repository: kservice

Re: Review Request 120012: kde-cli-tools: Save the default application into the group [Default Applications]

2014-08-31 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120012/ --- (Updated août 31, 2014, 10:08 matin) Review request for KDE Frameworks an

Review Request 120015: KIO: Save the default application into the group [Default Applications]

2014-08-31 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120015/ --- Review request for KDE Frameworks and David Faure. Repository: kio Desc

Review Request 120012: Save the default application into the group [Default Applications]

2014-08-31 Thread Luc Menut
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120012/ --- Review request for KDE Frameworks and David Faure. Repository: kde-cli-to

Jenkins build is back to stable : frameworkintegration_master_qt5 #103

2014-08-31 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: need flyer content and design for Qt DevDays

2014-08-31 Thread Lydia Pintscher
On Sun, Aug 24, 2014 at 3:10 PM, Lydia Pintscher wrote: > Hey folks :) > > Qt DevDays is coming up and we have the opportunity to add a flyer to > the welcome bag. I think we should do this. It should be a flyer about > Frameworks 5. Ideally we can re-use the same flyer later for other > events li