Re: Review Request 119940: Use style primitive to render custom tooltip rather than custom code

> On Aug. 26, 2014, 2:21 p.m., Aleix Pol Gonzalez wrote: > > +1 looks good to me. > > > > Maybe a before/after screenshot would help in these reviews. > > Hugo Pereira Da Costa wrote: > sorry. Will add > (being lazy) > > Ben Cooksley wrote: > You may wish to examine System Settings

Re: Review Request 119991: Use Juvia to add comments on the API class pages

> On Aug. 29, 2014, 2:42 p.m., Matthew Dawson wrote: > > This looks really awesome. Is there some way for maintainers (or other > > interested parties) to watch their framework's comments, to be on the look > > out for any interesting conversation? Users may make comments about the > > API's

Review Request 119997: Add documentation to KConfig::sync()

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119997/ --- Review request for KDE Frameworks. Repository: kconfig Description

Re: Review Request 119798: Generating PkgConfig files from ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/#review65528 --- modules/ECMGeneratePkgConfigFile.cmake

Re: SIC in KIO master

On Tuesday 26 August 2014 16:29:23 Harald Sitter wrote: > alohas, > > it would appear to me that a recent change in kio [1] was rather, > very, entirely source incompatible (one could argue binary but let's > not go there). > > Say I had the following in my application using kio 5.0/1: > > conne

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

> On Aug. 27, 2014, 6:05 p.m., Alex Merry wrote: > > modules/ECMQueryQmake.cmake, line 2 > > > > > > CMake macros/functions that take a variable name usually take it first. > > Swapping the argument order would ma

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

> On Aug. 27, 2014, 11:35 p.m., Alex Merry wrote: > > modules/ECMQueryQmake.cmake, line 2 > > > > > > CMake macros/functions that take a variable name usually take it first. > > Swapping the argument order would m

Re: Review Request 119988: Package structure cleanups

> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119992: PackageStructure plugin loading and tidy up of DataEngien plugin loading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119992/ --- (Updated Aug. 29, 2014, 3:25 p.m.) Status -- This change has been ma

Re: Review Request 119991: Use Juvia to add comments on the API class pages

> On ago. 29, 2014, 2:42 p.m., Matthew Dawson wrote: > > This looks really awesome. Is there some way for maintainers (or other > > interested parties) to watch their framework's comments, to be on the look > > out for any interesting conversation? Users may make comments about the > > API's

Re: Review Request 119988: Package structure cleanups

> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119991: Use Juvia to add comments on the API class pages

> On Aug. 29, 2014, 2:42 p.m., Matthew Dawson wrote: > > This looks really awesome. Is there some way for maintainers (or other > > interested parties) to watch their framework's comments, to be on the look > > out for any interesting conversation? Users may make comments about the > > API's

Re: Review Request 119988: Package structure cleanups

> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119991: Use Juvia to add comments on the API class pages

> On Aug. 29, 2014, 2:42 p.m., Matthew Dawson wrote: > > This looks really awesome. Is there some way for maintainers (or other > > interested parties) to watch their framework's comments, to be on the look > > out for any interesting conversation? Users may make comments about the > > API's

Re: Review Request 119992: PackageStructure plugin loading and tidy up of DataEngien plugin loading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119992/#review65508 --- Ship it! and +1 me. Thanks. - David Edmundson On Aug. 29,

Re: Review Request 119992: PackageStructure plugin loading and tidy up of DataEngien plugin loading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119992/#review65507 --- Ship it! this having both defines should make old users build

Re: Review Request 119991: Use Juvia to add comments on the API class pages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119991/#review65506 --- This looks really awesome. Is there some way for maintainers

Re: Review Request 119991: Use Juvia to add comments on the API class pages

> On Aug. 29, 2014, 2:23 p.m., Aleix Pol Gonzalez wrote: > > Do we have any identification system? How do we know the comments are from > > human? The user provides a pseudo and an e-mail, but no registration is needed. Akismet is a big online database of spamming IPs and also (I think) an ant

Re: Review Request 119991: Use Juvia to add comments on the API class pages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119991/#review65504 --- Do we have any identification system? How do we know the comme

Re: Review Request 119988: Package structure cleanups

> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119988/ --- (Updated Aug. 29, 2014, 2:20 p.m.) Status -- This change has been di

Review Request 119992: PackageStructure plugin loading and tidy up of DataEngien plugin loading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119992/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 119988: Package structure cleanups

> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Review Request 119991: Use Juvia to add comments on the API class pages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119991/ --- Review request for KDE Frameworks and Aurélien Gâteau. Repository: kapido

Re: circular dependencies?

Hi Michael, > As a consolation I've updated the --help output to at least document that > each > module passed in will be included in the output. Sorry for the confusion. no problem and thanks for taking care of this that far. Greets, Marko ___ Kde-f

Re: OSX/CI: libkdxraw fails to build on branch frameworks

Hi Ben, > > - kig > > - kstars > > - kqtquickcharts > Those three have now been added to the CI system. Thanks! Greets, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-

Re: Review Request 119988: Package structure cleanups

> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

> On Aug. 29, 2014, 2 p.m., David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters

Re: Review Request 119988: Package structure cleanups

> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters fo

Re: Review Request 119988: Package structure cleanups

> On Aug. 29, 2014, 2 p.m., David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? > > Aaron J. Seigo wrote: > Yes, but I don't think it maters

Re: Review Request 119988: Package structure cleanups

> On Aug. 29, 2014, noon, David Edmundson wrote: > > src/plasma/packagestructure.h, line 99 > > > > > > would removing a #define count as a SIC? Yes, but I don't think it maters for two reasons: 1) DataEngine al

Re: Review Request 119988: Package structure cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119988/#review65482 --- Ship it! +1 for removing shellpackage. good for plugin-ificat

Re: Review Request 119988: Package structure cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119988/#review65481 --- src/plasma/packagestructure.h

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

> On Aug. 27, 2014, 6:05 p.m., Alex Merry wrote: > > modules/ECMQueryQmake.cmake, line 1 > > > > > > I think we need to be a bit more clever here. I'd go for a cache > > variable, and if (TARGET Qt5::qmake), set t

Review Request 119988: Package structure cleanups

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119988/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: SIC in KIO master

On Tue, Aug 26, 2014 at 4:29 PM, Harald Sitter wrote: > alohas, > > it would appear to me that a recent change in kio [1] was rather, > very, entirely source incompatible (one could argue binary but let's > not go there). > > Say I had the following in my application using kio 5.0/1: > > connect(c