Jenkins build is back to normal : ktexteditor_master_qt5 #596

2014-08-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : kcmutils_master_qt5 #77

2014-08-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: OSX/CI: libkdxraw fails to build on branch frameworks

2014-08-28 Thread Ben Cooksley
On Thu, Aug 28, 2014 at 9:07 AM, Marko Käning wrote: > Hi Albert, Ben and Aleix, Hi all, > > On 27 Aug 2014, at 22:19 , Albert Astals Cid wrote: >> As I already said, I don't think it's worth for you building things that >> don't >> have Linux CI [unless you can work on fixing them, but I thin

Re: circular dependencies?

2014-08-28 Thread Michael Pyne
On Mon, August 25, 2014 22:18:13 Michael Pyne wrote: > On Mon, August 25, 2014 22:26:50 Marko Käning wrote: > > Hi, > > > > I just see (on the OSX/CI system) using e.g. > > > > --- > > $ cd ~/scripts/dependencies/tools > > $ list_dependencies frameworks/kauth > > desupport/extra-cmake-modules > >

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-08-28 Thread Albert Astals Cid
> On ago. 28, 2014, 5:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Jenkins build is back to normal : ktexteditor_master_qt5 #594

2014-08-28 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-08-28 Thread Jonathan Riddell
> On Aug. 28, 2014, 5:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

2014-08-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/ --- (Updated Aug. 28, 2014, 9:50 nachm.) Review request for KDE Frameworks.

Re: Review Request 119936: Fix inconsistencies in KPluginInfo and add a basic unit test

2014-08-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119936/ --- (Updated Aug. 28, 2014, 9:48 nachm.) Review request for KDE Frameworks.

Build failed in Jenkins: ktexteditor_master_qt5 #593

2014-08-28 Thread KDE CI System
See Changes: [walch.martin] Make SQL* highlighting files more similar, add comment folding to PL/SQL -- [...truncated 339 lines...] Generating moc_kateconfigpage.cpp Generating moc_katedialogs.

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-08-28 Thread Albert Astals Cid
> On ago. 28, 2014, 5:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Build failed in Jenkins: ktexteditor_master_qt5 #592

2014-08-28 Thread KDE CI System
See Changes: [walch.martin] Add syntax highlighting support for Kconfig files (LinuxKernelConf/LKC). -- [...truncated 921 lines...] Generating moc_kateconfigpage.cpp Generating moc_katedialogs.

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-08-28 Thread Jonathan Riddell
> On Aug. 28, 2014, 5:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-08-28 Thread Albert Astals Cid
> On ago. 28, 2014, 5:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-08-28 Thread Jonathan Riddell
> On Aug. 28, 2014, 5:02 p.m., Albert Astals Cid wrote: > > Errr, what do you mean it doesn't do anything? > > > > It's used > > http://lxr.kde.org/source/frameworks/kxmlgui/src/kaboutapplicationdialog.cpp?v=kf5-qt5 > > http://lxr.kde.org/source/frameworks/kjobwidgets/src/kuiserverjobtracker.cp

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-08-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119977/#review65445 --- Errr, what do you mean it doesn't do anything? It's used htt

Re: Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-08-28 Thread Harald Sitter
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119977/#review65444 --- seems best course of action unless someone wants to pursue imp

Review Request 119977: Mark setProgramIconName() as deprecated, it did not do anything

2014-08-28 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119977/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 119975: KDBusService shouldn't crash upon bad application name

2014-08-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119975/ --- (Updated Aug. 28, 2014, 3:57 p.m.) Review request for KDE Frameworks. R

Re: Review Request 119975: KDBusService shouldn't crash upon bad application name

2014-08-28 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119975/#review65442 --- src/kdbusservice.cpp

Review Request 119975: KDBusService shouldn't crash upon bad application name

2014-08-28 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119975/ --- Review request for KDE Frameworks. Repository: kdbusaddons Description

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

2014-08-28 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/#review65434 --- Ship it! +1 from my side, but I'm not the maintainer of that

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

2014-08-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/ --- (Updated Aug. 28, 2014, 2:56 nachm.) Review request for KDE Frameworks.

Re: Review Request 119936: Add a basic unit test for KPluginInfo

2014-08-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119936/ --- (Updated Aug. 28, 2014, 2:56 nachm.) Review request for KDE Frameworks.

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

2014-08-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/ --- (Updated Aug. 28, 2014, 2:52 nachm.) Review request for KDE Frameworks.

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

2014-08-28 Thread Milian Wolff
> On Aug. 28, 2014, 12:07 p.m., Milian Wolff wrote: > > src/services/kplugininfo.cpp, line 523 > > > > > > don't create the string literals multiple times, i.e. Name at least is > > twice here which increases th

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

2014-08-28 Thread Alexander Richardson
> On Aug. 28, 2014, 2:07 nachm., Milian Wolff wrote: > > src/services/kplugininfo.h, line 429 > > > > > > here and below: > > > > maybe just rename this to > > > > toMetaData() > > f

Re: Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

2014-08-28 Thread Milian Wolff
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/#review65421 --- src/services/kplugininfo.h

Review Request 119970: Add functions to convert between KPluginInfo and KPluginMetaData to KPluginInfo ( + unit test)

2014-08-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119970/ --- Review request for KDE Frameworks. Repository: kservice Description ---

Re: Review Request 119936: Add a basic unit test for KPluginInfo

2014-08-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119936/ --- (Updated Aug. 28, 2014, 1:09 nachm.) Review request for KDE Frameworks.

Re: Review Request 119936: Add a basic unit test for KPluginInfo

2014-08-28 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119936/ --- (Updated Aug. 28, 2014, 1:08 nachm.) Review request for KDE Frameworks.

Re: [Kde-pim] split kdepimlibs

2014-08-28 Thread Sebastian Kügler
On Thursday, August 28, 2014 11:46:02 Kevin Krammer wrote: > > We also have Akademy and the sprint scheduled for November (?) at > > which we could sit down and methodically work through the list of > > everything and figure out what to do. > > I agree, it makes little sense to rush this before Ak

Re: split kdepimlibs

2014-08-28 Thread Kevin Krammer
On Wednesday, 2014-08-27, 19:59:24, John Layt wrote: > My general 2c: I'm with Kevin that we should do functional and api > reviews, move code around, and generally refactor stuff *before* we > split anything. It's just plain easier that way. I don't think we're > anywhere near close to knowing wha

Re: [Kde-pim] split kdepimlibs

2014-08-28 Thread Kevin Krammer
On Tuesday, 2014-08-26, 18:30:54, Daniel Vratil wrote: > I think all the type-specific libraries (-abc, -calendar, ...) would all > depend on the Widgets library anyway and the amount of non-gui stuff is > rather limited * I think it is a worthy goal to make a widget split there as well. Some of