Re: split kdepimlibs

2014-08-27 Thread laurent Montel
Le mardi 26 août 2014 11:50:50 Kevin Ottens a écrit : > > kpimidentities > > Maybe deserves a better name? kidentitymanagement? Done. > > kpimtextedit > > I suspect it could get a better name, but couldn't decide yet. :-) > Also I wonder if some of it could/should go in ktexteditor? But I don't

Re: kio_trash

2014-08-27 Thread Kevin Funk
On Sunday 17 August 2014 00:03:41 David Faure wrote: > kio_trash is currently in kde-workspace/kio-extras, but KIO actually offers > API that depends on kio_trash (KIO::trash(), JobUiDelegateExtension::Trash, > support for trash in FileUndoManager, and I'm about to add a > KIO::restoreFromTrash job

Re: OSX/CI: libkdxraw fails to build on branch frameworks

2014-08-27 Thread Marko Käning
Hi Albert, Ben and Aleix, On 27 Aug 2014, at 22:19 , Albert Astals Cid wrote: > As I already said, I don't think it's worth for you building things that > don't > have Linux CI [unless you can work on fixing them, but I think you said it > was > not part of your skills]. hmmm, okay. Well, I’

Re: OSX/CI: libkdxraw fails to build on branch frameworks

2014-08-27 Thread Albert Astals Cid
El Dimecres, 27 d'agost de 2014, a les 19:56:17, Marko Käning va escriure: > Hi David, > > On 27 Aug 2014, at 12:53 , David Edmundson wrote: > > It's known it's not finished being ported. > > Not to me. As I already said, I don't think it's worth for you building things that don't have Linux

Re: split kdepimlibs

2014-08-27 Thread John Layt
On 26 August 2014 11:41, Jonathan Riddell wrote: > > I'd like to suggest taking the opportunity to remove uses of the quite ugly > term PIM in favour of the friendlier Kontact. I would say no. PIM in library names makes sense, especially as we want that others outside KDE-PIM / Kontact will use

Re: split kdepimlibs

2014-08-27 Thread John Layt
My general 2c: I'm with Kevin that we should do functional and api reviews, move code around, and generally refactor stuff *before* we split anything. It's just plain easier that way. I don't think we're anywhere near close to knowing what to do with everything to be splitting things yet. Will we

Review Request 119958: Fix thumbnails for mimetype groups.

2014-08-27 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119958/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

2014-08-27 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/#review65382 --- Nice! See my comments below, though. kde-modules/KDEInstallD

Re: OSX/CI: libkdxraw fails to build on branch frameworks

2014-08-27 Thread Marko Käning
Hi David, On 27 Aug 2014, at 12:53 , David Edmundson wrote: > It's known it's not finished being ported. Not to me. Where would I find a place with information about the porting state of the various KDE libs? I know there is one for kdeedu, which Aleix pointed out to me a while ago [1]. Somethi

Re: Review Request 119901: Fix ECM to use qmake instead of hardcoding plugin install dirs

2014-08-27 Thread Rohan Garg
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119901/ --- (Updated Aug. 27, 2014, 6:41 p.m.) Review request for Build System and KD

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-27 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/ --- (Updated Aug. 27, 2014, 12:42 p.m.) Status -- This change has been m

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-27 Thread Kevin Krammer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/#review65352 --- Ship it! Ship It! - Kevin Krammer On Aug. 22, 2014, 10:55

Re: OSX/CI: libkdxraw fails to build on branch frameworks

2014-08-27 Thread David Edmundson
It's known it's not finished being ported. I started porting this, as I needed it for Gwenview. I got stuck on the Threadweaver porting, so at the time just made it an optional dependency in Gwenview instead. It's on my TODO list, though feel free to help out. David. ___

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-27 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/#review65350 --- So what do I do ? - Laurent Montel On août 22, 2014, 10:55

Re: OSX/CI: libkdxraw fails to build on branch frameworks

2014-08-27 Thread Aleix Pol
On Wed, Aug 27, 2014 at 10:48 AM, Marko Käning wrote: > Hi Aleix, > > On 26 Aug 2014, at 12:18 , Aleix Pol wrote: > > libkdcraw is not a KDE Framework anyway, you probably want to tell the > Digikam mailing lists. > > hmmm, I just verified again that it has a frameworks branch. > > OK, so a fram

Re: OSX/CI: libkdxraw fails to build on branch frameworks

2014-08-27 Thread Marko Käning
Hi Aleix, On 26 Aug 2014, at 12:18 , Aleix Pol wrote: > libkdcraw is not a KDE Framework anyway, you probably want to tell the > Digikam mailing lists. hmmm, I just verified again that it has a frameworks branch. OK, so a frameworks branch alone doesn't mean that a project is already framewor

Re: Review Request 119940: Use style primitive to render custom tooltip rather than custom code

2014-08-27 Thread Hugo Pereira Da Costa
> On Aug. 26, 2014, 2:21 p.m., Aleix Pol Gonzalez wrote: > > +1 looks good to me. > > > > Maybe a before/after screenshot would help in these reviews. > > Hugo Pereira Da Costa wrote: > sorry. Will add > (being lazy) > > Ben Cooksley wrote: > You may wish to examine System Settings