Re: Review Request 119940: Use style primitive to render custom tooltip rather than custom code

> On Aug. 26, 2014, 2:21 p.m., Aleix Pol Gonzalez wrote: > > +1 looks good to me. > > > > Maybe a before/after screenshot would help in these reviews. > > Hugo Pereira Da Costa wrote: > sorry. Will add > (being lazy) You may wish to examine System Settings, it has very similar code as

Re: Review Request 119942: give the applet alternatives QML file an entry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119942/ --- (Updated Aug. 26, 2014, 7:44 p.m.) Status -- This change has been ma

Re: Review Request 119942: give the applet alternatives QML file an entry

> On Aug. 26, 2014, 5:40 p.m., Marco Martin wrote: > > src/plasma/private/packages.cpp, line 278 > > > > > > maybe going even more explicit and giving its own subdicrectory too? > > (i'm fine with either) A sub

Re: Review Request 119947: Re-enable build of SVG thumbnailer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119947/ --- (Updated Aug. 26, 2014, 7:20 p.m.) Status -- This change has been ma

Re: split kdepimlibs

Hello, On Tuesday 26 August 2014 18:25:01 Daniel Vratil wrote: > I definitely want to have the Server and the client libraries in one repo, > shipped as a complete solution for PIM storage with the server being just > part of the solution, not a standalone one. Excellent. Definitely what I'd like

Re: Review Request 119947: Re-enable build of SVG thumbnailer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119947/#review65309 --- Ship it! Ship It! - David Edmundson On Aug. 26, 2014, 6:40

Review Request 119947: Re-enable build of SVG thumbnailer

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119947/ --- Review request for KDE Frameworks and Plasma. Repository: kio-extras De

Re: split kdepimlibs

On Tuesday 26 of August 2014 19:02:49 laurent Montel wrote: > Le mardi 26 août 2014 18:25:01 Daniel Vratil a écrit : > > On Tuesday 26 of August 2014 12:32:48 laurent Montel wrote: > > > Le mardi 26 août 2014 11:50:50 Kevin Ottens a écrit : > > > > On Tuesday 26 August 2014 11:20:25 laurent Montel

Re: Review Request 119942: give the applet alternatives QML file an entry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119942/#review65294 --- Ship it! src/plasma/private/packages.cpp

Re: circular dependencies?

On Mon, August 25, 2014 22:26:50 Marko Käning wrote: > Hi, > > I just see (on the OSX/CI system) using e.g. > > --- > $ cd ~/scripts/dependencies/tools > $ list_dependencies frameworks/kauth > desupport/extra-cmake-modules > Qt5[stable] > frameworks/kcoreaddons > frameworks/kauth > --- > > that

Review Request 119942: give the applet alternatives QML file an entry

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119942/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: split kdepimlibs

Le mardi 26 août 2014 18:25:01 Daniel Vratil a écrit : > On Tuesday 26 of August 2014 12:32:48 laurent Montel wrote: > > Le mardi 26 août 2014 11:50:50 Kevin Ottens a écrit : > > > On Tuesday 26 August 2014 11:20:25 laurent Montel wrote: > > > > Hi, > > > > I will split kdepimlibs as it > > > > >

Re: split kdepimlibs

Le mardi 26 août 2014 17:24:24 Kevin Krammer a écrit : > Looks like you forgot to add the KDE PIM list :-) > > On Tuesday, 2014-08-26, 11:20:25, laurent Montel wrote: > > Hi, > > I will split kdepimlibs as it > > > > akonadi (need to find another name because it's still used) > > akonadi-abc > >

Re: split kdepimlibs

Le mardi 26 août 2014 17:29:46 Kevin Krammer a écrit : > > kioslave indeed not a framework. I think that just pop3 is used by kdepim > > > > yes others can move to kio-extra > > Is the Akonadi IO slave in there as well? Akonadi io slave is from kdepim-runtime but can be moved to kio-extra too n

Re: split kdepimlibs

On Tuesday 26 of August 2014 17:24:24 Kevin Krammer wrote: > Looks like you forgot to add the KDE PIM list :-) > > On Tuesday, 2014-08-26, 11:20:25, laurent Montel wrote: > > Hi, > > I will split kdepimlibs as it > > > > akonadi (need to find another name because it's still used) > > akonadi-abc

Re: split kdepimlibs

On Tuesday 26 of August 2014 17:29:46 Kevin Krammer wrote: > On Tuesday, 2014-08-26, 12:32:48, laurent Montel wrote: > > Le mardi 26 août 2014 11:50:50 Kevin Ottens a écrit : > > > On Tuesday 26 August 2014 11:20:25 laurent Montel wrote: > > > > Hi, > > > > I will split kdepimlibs as it > > > > >

Re: split kdepimlibs

On Tuesday 26 of August 2014 12:32:48 laurent Montel wrote: > Le mardi 26 août 2014 11:50:50 Kevin Ottens a écrit : > > On Tuesday 26 August 2014 11:20:25 laurent Montel wrote: > > > Hi, > > > I will split kdepimlibs as it > > > > > > akonadi (need to find another name because it's still used) > >

Re: split kdepimlibs

On Tuesday, 2014-08-26, 12:32:48, laurent Montel wrote: > Le mardi 26 août 2014 11:50:50 Kevin Ottens a écrit : > > On Tuesday 26 August 2014 11:20:25 laurent Montel wrote: > > > Hi, > > > I will split kdepimlibs as it > > > > > > akonadi (need to find another name because it's still used) > > > a

Re: split kdepimlibs

Looks like you forgot to add the KDE PIM list :-) On Tuesday, 2014-08-26, 11:20:25, laurent Montel wrote: > Hi, > I will split kdepimlibs as it > > akonadi (need to find another name because it's still used) > akonadi-abc Is that akonadi/kabc? > akonadi-calendar > akonadi-contact > akonadi-mime

Re: split kdepimlibs

On Tuesday 26 August 2014 15:51:33 David Gil Oliva wrote: > El 26/08/2014 15:49, "Vishesh Handa" escribió: > > On Tuesday, August 26, 2014 11:50:50 AM Kevin Ottens wrote: > > > > gpgme++ > > > > kabc > > > > kalarmcal > > > > kblog > > > > kcalcore > > > > kcalutils > > > > > > This one looks lik

Re: Review Request 119940: Use style primitive to render custom tooltip rather than custom code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119940/ --- (Updated Aug. 26, 2014, 2:43 p.m.) Status -- This change has been ma

Re: Review Request 119940: Use style primitive to render custom tooltip rather than custom code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119940/ --- (Updated Aug. 26, 2014, 2:38 p.m.) Review request for KDE Frameworks. C

SIC in KIO master

alohas, it would appear to me that a recent change in kio [1] was rather, very, entirely source incompatible (one could argue binary but let's not go there). Say I had the following in my application using kio 5.0/1: connect(copyjob, &CopyJob::aboutToCreate, this, &MyThing::onABoutToCreate); my

Re: Review Request 119940: Use style primitive to render custom tooltip rather than custom code

> On Aug. 26, 2014, 2:21 p.m., Aleix Pol Gonzalez wrote: > > +1 looks good to me. > > > > Maybe a before/after screenshot would help in these reviews. sorry. Will add (being lazy) - Hugo --- This is an automatically generated e-mail. T

Re: Review Request 119940: Use style primitive to render custom tooltip rather than custom code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119940/#review65279 --- Ship it! +1 looks good to me. Maybe a before/after screensho

Review Request 119940: Use style primitive to render custom tooltip rather than custom code

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119940/ --- Review request for KDE Frameworks. Repository: kinfocenter Description

Re: split kdepimlibs

On Tuesday, August 26, 2014 11:50:50 AM Kevin Ottens wrote: > > gpgme++ > > kabc > > kalarmcal > > kblog > > kcalcore > > kcalutils > > This one looks like a dumping ground of random things. Maybe some of it > should move in other frameworks? KAbc definitely doesn't seem like a dumping ground. I

Re: split kdepimlibs

El 26/08/2014 15:49, "Vishesh Handa" escribió: > > On Tuesday, August 26, 2014 11:50:50 AM Kevin Ottens wrote: > > > gpgme++ > > > kabc > > > kalarmcal > > > kblog > > > kcalcore > > > kcalutils > > > > This one looks like a dumping ground of random things. Maybe some of it > > should move in oth

Re: OSX/CI: libkdxraw fails to build on branch frameworks

On 26 Aug 2014, at 12:18 , Aleix Pol wrote: > Maybe it hasn't been ported yet? I was jumping the gun again. :) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119798: Generating PkgConfig files from ECM

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119798/ --- (Updated Aug. 26, 2014, 11:51 a.m.) Review request for Build System, KDE

Re: split kdepimlibs

Le mardi 26 août 2014 12:37:40 Aleix Pol a écrit : > On Tue, Aug 26, 2014 at 11:20 AM, laurent Montel wrote: > > Hi, > > I will split kdepimlibs as it > > > > akonadi (need to find another name because it's still used) > > akonadi-abc > > akonadi-calendar > > akonadi-contact > > akonadi-mime > >

Re: split kdepimlibs

I'd like to suggest taking the opportunity to remove uses of the quite ugly term PIM in favour of the friendlier Kontact. Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-d

Re: split kdepimlibs

On Tue, Aug 26, 2014 at 11:20 AM, laurent Montel wrote: > Hi, > I will split kdepimlibs as it > > akonadi (need to find another name because it's still used) > akonadi-abc > akonadi-calendar > akonadi-contact > akonadi-mime > akonadi-notes > akonadi-socialutils > gpgme++ > kabc > kalarmcal > kblo

Re: split kdepimlibs

Le mardi 26 août 2014 11:50:50 Kevin Ottens a écrit : > On Tuesday 26 August 2014 11:20:25 laurent Montel wrote: > > Hi, > > I will split kdepimlibs as it > > > > akonadi (need to find another name because it's still used) > > akonadi-abc > > akonadi-calendar > > akonadi-contact > > akonadi-mime >

Re: OSX/CI: libkdxraw fails to build on branch frameworks

On Tue, Aug 26, 2014 at 8:28 AM, Marko Käning wrote: > There are actually two problems here: > > --- > > Building CXX object src/CMakeFiles/LibKDcraw.dir/squeezedcombobox.cpp.o > In file included from > /Users/marko/WC/KDECI-builds/libkdcraw/src/squeezedcombobox.cpp:31: > /Users/marko/WC/KDECI-bu

Re: split kdepimlibs

On Tuesday 26 August 2014 11:20:25 laurent Montel wrote: > Hi, > I will split kdepimlibs as it > > akonadi (need to find another name because it's still used) > akonadi-abc > akonadi-calendar > akonadi-contact > akonadi-mime > akonadi-notes > akonadi-socialutils To me it sounds like some of those

split kdepimlibs

Hi, I will split kdepimlibs as it akonadi (need to find another name because it's still used) akonadi-abc akonadi-calendar akonadi-contact akonadi-mime akonadi-notes akonadi-socialutils gpgme++ kabc kalarmcal kblog kcalcore kcalutils kholidays kimap kioslave kldap kmbox kmime kontactinterface kpim

Jenkins build is back to normal : kcmutils_master_qt5 #76

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Attention KDE Frameworks 5 Cookbook authors

Thanks Valorie, for the hint. Greets, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Attention KDE Frameworks 5 Cookbook authors

On Tue, Aug 26, 2014 at 12:00 AM, Marko Käning wrote: > Hi Valorie, > > is there already a PDF somewhere accessible, or does one need to build it > locally still? > > Greets, > Marko Hi Marko, Please read Mirko's recent blog: http://creative-destruction.me/2014/08/25/how-to-contribute-to-the-kd

Re: Attention KDE Frameworks 5 Cookbook authors

Hi Valorie, is there already a PDF somewhere accessible, or does one need to build it locally still? Greets, Marko ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel