Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-21 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/ --- (Updated août 22, 2014, 6:25 matin) Review request for KDE Frameworks, Da

Re: Review Request 119895: New class for 5.2 to help user to migrate config files and ui file to new standardpath

2014-08-21 Thread Laurent Montel
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119895/ --- (Updated août 22, 2014, 5:43 matin) Review request for KDE Frameworks, Da

Re: Review Request 119876: KIO: add KIO::EmptyTrashJob* KIO::emptyTrash().

2014-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119876/ --- (Updated Aug. 21, 2014, 10:30 p.m.) Status -- This change has been m

OSX/CI: kdepimlibs fails to build on branch frameworks

2014-08-21 Thread Marko Käning
Now that prison successfully builds I was able to proceed somewhat with kdepimlibs, but for some reason its build fails due to akonadi: --- Generating moc_specialmailcollectionsdiscoveryjob.cpp Generating moc_specialmailcollectionsrequestjob.cpp [ 12%] [ 12%] Built target KF5AkonadiMime_automoc

Re: OSX/CI system: prison fails to build on branch master

2014-08-21 Thread Marko Käning
Prison now successfully builds on OSX, thanks to Raymond’s fix from August 19th! ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/#review64997 --- Ship it! src/widgets/kdesktopfileactions.cpp

Re: Review Request 119881: add version cmake file for PlasmaQuick, this allows Plasma Desktop to be able to set a required KF5 version

2014-08-21 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119881/ --- (Updated Aug. 21, 2014, 4:19 p.m.) Status -- This change has been ma

Re: Review Request 119881: add version cmake file for PlasmaQuick, this allows Plasma Desktop to be able to set a required KF5 version

2014-08-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119881/#review64989 --- Ship it! OK, so normally we would just have one cmake file an

Review Request 119884: Add cursor shape property to MouseEventListener

2014-08-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119884/ --- Review request for KDE Frameworks. Bugs: 337062 https://bugs.kde.org/

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread Maarten De Meyer
> On Aug. 21, 2014, 7:19 a.m., David Faure wrote: > > We have never needed this until now because we can recognize such files by > > their name... So while I'm not opposed to this, I wonder, why not use if > > (u.fileName() == ".directory") in KDesktopFileActions (RR 119869) -- which > > will

Re: Review Request 119869: KIO: Correctly handle .directory files

2014-08-21 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119869/ --- (Updated Aug. 21, 2014, 1:15 p.m.) Review request for KDE Frameworks, kde

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread Maarten De Meyer
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/ --- (Updated Aug. 21, 2014, 1:15 p.m.) Status -- This change has been di

Re: Review Request 119879: call style()->drawControl rather than drawItemText to handle button painting in kmultitabbar

2014-08-21 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119879/ --- (Updated Aug. 21, 2014, 1:02 p.m.) Status -- This change has been ma

Re: Review Request 119881: add version cmake file for PlasmaQuick, this allows Plasma Desktop to be able to set a required KF5 version

2014-08-21 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119881/#review64976 --- KConfig has multiple libraries but only 1 KF5ConfigConfig.cmak

Re: Review Request 119879: call style()->drawControl rather than drawItemText to handle button painting in kmultitabbar

2014-08-21 Thread Hugo Pereira Da Costa
> On Aug. 21, 2014, 10:42 a.m., Christoph Feck wrote: > > Regarding rotating the complete button, I doubt that it will look good. You > > will also rotate lightning/shadows, direction of gradients etc. yes, right ... in fact, what my own code does (after double checking), is call CE_ToolButto

Re: Review Request 119879: call style()->drawControl rather than drawItemText to handle button painting in kmultitabbar

2014-08-21 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119879/#review64971 --- Ship it! Regarding rotating the complete button, I doubt that

Re: Review Request 119881: add version cmake file for PlasmaQuick, this allows Plasma Desktop to be able to set a required KF5 version

2014-08-21 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119881/#review64970 --- https://git.reviewboard.kde.org/r/119882/ - Jonathan Riddell

Review Request 119881: add version cmake file for PlasmaQuick, this allows Plasma Desktop to be able to set a required KF5 version

2014-08-21 Thread Jonathan Riddell
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119881/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Review Request 119879: call style()->drawControl rather than drawItemText to handle button painting in kmultitabbar

2014-08-21 Thread Hugo Pereira Da Costa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119879/ --- Review request for KDE Frameworks, Christoph Feck, Gilles Caulier, and Mark

Re: How to promote less mature Frameworks?

2014-08-21 Thread Kevin Krammer
On Wednesday, 2014-08-20, 12:14:31, Aleix Pol wrote: > It would be very interesting to have somebody working on kdepimlibs around. > I keep hearing that they will be available soon, but I still ignore whether > the people doing the work want the kdepimlibs to become KDE Frameworks > (they didn't w

Re: Review Request 119876: KIO: add KIO::EmptyTrashJob* KIO::emptyTrash().

2014-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119876/ --- (Updated Aug. 21, 2014, 7:41 a.m.) Review request for KDE Frameworks. C

Re: Review Request 119868: KConfig add DirectoryType support

2014-08-21 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119868/#review64952 --- We have never needed this until now because we can recognize s