Re: Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

2014-08-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119809/ --- (Updated Aug. 17, 2014, 9:38 p.m.) Review request for KDE Frameworks and

Re: Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

2014-08-17 Thread David Faure
> On Aug. 17, 2014, 6:07 p.m., Emmanuel Pescosta wrote: > > src/core/restorejob.cpp, line 36 > > > > > > constBegin() because m_urlsIterator is a const iterator I compile with -DQT_STRICT_ITERATORS so the compile

Jenkins build is back to stable : ktexteditor_master_qt5 #584

2014-08-17 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: ktexteditor_master_qt5 #583

2014-08-17 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

2014-08-17 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119809/#review64687 --- src/core/restorejob.cpp

Re: Review Request 119781: Port TextArea to QtControls

2014-08-17 Thread David Edmundson
> On Aug. 17, 2014, 1:38 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml, line > > 30 > > > > > > I can see why you're doing this but I think this approach is

Re: Review Request 119781: Port TextArea to QtControls

2014-08-17 Thread Marco Martin
> On Aug. 17, 2014, 1:38 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/styles/TextAreaStyle.qml, line > > 30 > > > > > > I can see why you're doing this but I think this approach is

Re: Review Request 119781: Port TextArea to QtControls

2014-08-17 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119781/#review64672 --- src/declarativeimports/plasmacomponents/qml/styles/TextAreaSt

Re: Review Request 119805: Use "svn export" to fetch KDE identities if possible, and cache them

2014-08-17 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119805/ --- (Updated Aug. 17, 2014, 10:10 a.m.) Review request for KDE Frameworks and

Re: Review Request 119805: Use "svn export" to fetch KDE identities if possible, and cache them

2014-08-17 Thread Alex Merry
> On Aug. 16, 2014, 7:46 p.m., Denis Steckelmacher wrote: > > Great work! I've tested this patch in this configuration and it works: no > > PySVN, SVN installed, Python 2. I have one question, though: why do you try > > to get the temporary path for the cached file using three different > > OS

Re: kio_trash

2014-08-17 Thread Alex Merry
On Sunday 17 August 2014 00:03:41 David Faure wrote: > kio_trash is currently in kde-workspace/kio-extras, but KIO actually offers > API that depends on kio_trash (KIO::trash(), JobUiDelegateExtension::Trash, > support for trash in FileUndoManager, and I'm about to add a > KIO::restoreFromTrash job

Re: Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

2014-08-17 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119809/ --- (Updated Aug. 17, 2014, 9:01 a.m.) Review request for KDE Frameworks and

Re: Review Request 119805: Use "svn export" to fetch KDE identities if possible, and cache them

2014-08-17 Thread Denis Steckelmacher
> On Aug. 16, 2014, 7:46 p.m., Denis Steckelmacher wrote: > > Great work! I've tested this patch in this configuration and it works: no > > PySVN, SVN installed, Python 2. I have one question, though: why do you try > > to get the temporary path for the cached file using three different > > OS