Re: Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

2014-08-16 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119809/#review64658 --- src/core/restorejob.h

Review Request 119809: KIO: New job RestoreJob, public API KIO::restoreFromTrash().

2014-08-16 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119809/ --- Review request for KDE Frameworks and Eike Hein. Repository: kio Descri

Re: name of the kconfig config file

2014-08-16 Thread David Faure
On Wednesday 30 July 2014 09:06:13 k...@nicolaslecureuil.fr wrote: > Hello, > > i saw that kconfig want to use kde5rc, for coherency and to not confuse > people, shouldn't it be kf5rc ? Difficult to find a proper name for it, /etc/kde5rc is the global-global config file (all apps, all users), wh

kio_trash

2014-08-16 Thread David Faure
kio_trash is currently in kde-workspace/kio-extras, but KIO actually offers API that depends on kio_trash (KIO::trash(), JobUiDelegateExtension::Trash, support for trash in FileUndoManager, and I'm about to add a KIO::restoreFromTrash job). And KIO::trash is called from the file dialog (kdiropera

Re: Update of the metainfo.yaml file of all the frameworks

2014-08-16 Thread Michael Pyne
On Sat, August 16, 2014 17:33:48 Michael Pyne wrote: > To be more clear, it might be best just for kapidox to download the file > directly via anonymous SVN (at least as a first priority). Never mind, there's already an open review request for exactly this, sorry for the noise. Regards, - Micha

Re: Update of the metainfo.yaml file of all the frameworks

2014-08-16 Thread Michael Pyne
On Thu, August 14, 2014 09:46:37 Ben Cooksley wrote: > On Thu, Aug 14, 2014 at 3:16 AM, Denis Steckelmacher > > Nice! kapidox now downloads the list of the KDE accounts from > > websvn.kde.org, and these two fields can now be used in metainfo.yaml: > Just wondering - how often does the tool fetch a

Re: Review Request 119805: Use "svn export" to fetch KDE identities if possible, and cache them

2014-08-16 Thread Alex Merry
> On Aug. 16, 2014, 7:46 p.m., Denis Steckelmacher wrote: > > Great work! I've tested this patch in this configuration and it works: no > > PySVN, SVN installed, Python 2. I have one question, though: why do you try > > to get the temporary path for the cached file using three different > > OS

Review Request 119808: Move module metadata to after class picker

2014-08-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119808/ --- Review request for KDE Frameworks, Denis Steckelmacher and Aurélien Gâteau.

Re: Review Request 119805: Use "svn export" to fetch KDE identities if possible, and cache them

2014-08-16 Thread Denis Steckelmacher
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119805/#review64653 --- Great work! I've tested this patch in this configuration and i

Review Request 119805: Use "svn export" to fetch KDE identities if possible, and cache them

2014-08-16 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119805/ --- Review request for KDE Frameworks, Denis Steckelmacher and Aurélien Gâteau.