Re: Problems with KFilterDev::deviceForFile method in a KF5 based application

2014-08-09 Thread Arnold Dumas
Le 09/08/2014 10:47, David Faure a écrit : On Sunday 27 July 2014 20:22:14 Arnold Dumas wrote: I've tried to replace this by: QScopedPointer device(new KFilterDev(file)); but it still only load gziped files and not plain-text ones. This is surprising because this case is unittested and works.

Jenkins build is back to normal : ktexteditor_master_qt5 #553

2014-08-09 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: ktexteditor_master_qt5 #552

2014-08-09 Thread KDE CI System
See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Build failed in Jenkins: ktexteditor_master_qt5 #551

2014-08-09 Thread KDE CI System
See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Build failed in Jenkins: ktexteditor_master_qt5 #550

2014-08-09 Thread KDE CI System
See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Build failed in Jenkins: ktexteditor_master_qt5 #549

2014-08-09 Thread KDE CI System
See -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 4 (PACKAGER LINBUILDER) in workspace

Review Request 119681: Duplicate header guard from notifybylogfile.h in notifybyaudio.h

2014-08-09 Thread Andreas Xavier
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119681/ --- Review request for KDE Frameworks and Martin Klapetek. Repository: knotif

Re: [qca] /: Revert "Fix plugins lookup when not building in the Qt prefix"

2014-08-09 Thread Ben Cooksley
On Sun, Aug 10, 2014 at 2:40 AM, Aleix Pol wrote: > On Sat, Aug 9, 2014 at 2:07 PM, Ben Cooksley wrote: >> >> Git commit c8b445b04a0efe66e491a6f0a06ca4ef312fdc91 by Ben Cooksley. >> Committed on 09/08/2014 at 12:00. >> Pushed by bcooksley into branch 'master'. >> >> Revert "Fix plugins lookup whe

Re: [qca] /: Revert "Fix plugins lookup when not building in the Qt prefix"

2014-08-09 Thread Aleix Pol
On Sat, Aug 9, 2014 at 2:07 PM, Ben Cooksley wrote: > Git commit c8b445b04a0efe66e491a6f0a06ca4ef312fdc91 by Ben Cooksley. > Committed on 09/08/2014 at 12:00. > Pushed by bcooksley into branch 'master'. > > Revert "Fix plugins lookup when not building in the Qt prefix" > > This reverts commit 38e

Re: OSX/CI: plasma-framework fails building on branch master

2014-08-09 Thread Ben Cooksley
On Sun, Aug 10, 2014 at 1:10 AM, Marko Käning wrote: > Hi Ben, Hi Marko, > > On 09 Aug 2014, at 15:07 , Ben Cooksley wrote: >> Is lcov available for OS X? > > I haven’t checked that up to now. Do we need that? How can I check it? Long term, it will be needed as lcov is used for code coverage c

Re: OSX/CI: plasma-framework fails building on branch master

2014-08-09 Thread Marko Käning
Hi Ben, On 09 Aug 2014, at 15:07 , Ben Cooksley wrote: > Is lcov available for OS X? I haven’t checked that up to now. Do we need that? How can I check it? > This is a part of our CI implementation as an optional feature, which > it appears plasma-framework has enabled. Oh, I see, I saw somew

Re: OSX/CI: plasma-framework fails building on branch master

2014-08-09 Thread Ben Cooksley
On Sun, Aug 10, 2014 at 1:05 AM, Marko Käning wrote: > Hi Aleix, Hi Marko, > > On 08 Aug 2014, at 01:27 , Aleix Pol wrote: >> You're building with coverage enabled, I guess you're using the same build >> arguments as Jenkins? > > that’s what I figured, but I wonder why this never happened befo

Re: OSX/CI: plasma-framework fails building on branch master

2014-08-09 Thread Marko Käning
Hi Aleix, On 08 Aug 2014, at 01:27 , Aleix Pol wrote: > You're building with coverage enabled, I guess you're using the same build > arguments as Jenkins? that’s what I figured, but I wonder why this never happened before. Something must have changed in the meantime. Yes, I should be using the

[qca] /: Revert "Fix plugins lookup when not building in the Qt prefix"

2014-08-09 Thread Ben Cooksley
Git commit c8b445b04a0efe66e491a6f0a06ca4ef312fdc91 by Ben Cooksley. Committed on 09/08/2014 at 12:00. Pushed by bcooksley into branch 'master'. Revert "Fix plugins lookup when not building in the Qt prefix" This reverts commit 38e0665127650b3db5676c1dd5f0ffeb8cdb176f. This change is incorrect,

Re: KDE Frameworks 2014 Sprint Dot Article missing

2014-08-09 Thread Mark Gaiser
On Fri, Aug 8, 2014 at 9:23 PM, Albert Astals Cid wrote: > El Dilluns, 28 de juliol de 2014, a les 00:48:54, Albert Astals Cid va > escriure: >> Hi guys, please note that the Dot Article of the KDE Frameworks 2014 Sprint >> is missing. >> >> Can someone of the guys that was there write something?

Re: Review Request 119505: Instance our onw QFileDialog instead of using getExistingDirectoryUrl

2014-08-09 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119505/#review64101 --- Well, I fixed this for Qt 5.4. https://codereview.qt-project.

Re: Problems with KFilterDev::deviceForFile method in a KF5 based application

2014-08-09 Thread David Faure
On Sunday 27 July 2014 20:22:14 Arnold Dumas wrote: > I've tried to replace this by: > QScopedPointer device(new KFilterDev(file)); > > but it still only load gziped files and not plain-text ones. This is surprising because this case is unittested and works. KFilterTest::test_block_read ends wit

Re: Porting KDialog::makeStandardCaption

2014-08-09 Thread David Faure
On Friday 25 July 2014 18:39:36 David Narvaez wrote: > Hi, > > What's the new way to do KDialog::makeStandardCaption[0] withot > KDELibs4Support? Don't do it. I made Qt add the application name to the titlebar automatically on desktop platforms. So don't add it again in the application code. -

Re: OSX/CI: KCrash misses DrKonqi

2014-08-09 Thread David Faure
On Wednesday 06 August 2014 21:43:25 Marko Käning wrote: > On 05 Aug 2014, at 08:09 , David Faure wrote: > > It's not a shared lib, it's a separate process started by KCrash. > > Oh, I see. I thought there was an executable called like that. There *is* an executable called drkonqi --- that's exa