Re: Review Request 119542: create qapplication before using dbus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119542/#review63482 --- +1, from what I've seen it looks fairly harmless. - Luca Belt

Review Request 119542: create qapplication before using dbus

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119542/ --- Review request for KDE Frameworks. Repository: kauth Description --

Review Request 119540: don't construct bogus KAuthAction objects

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119540/ --- Review request for KDE Frameworks, Hrvoje Senjan and Martin Bříza. Reposi

Re: Review Request 119417: kconfig: Fix QBasicAtomicInt being treated as int (reposted)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119417/ --- (Updated July 29, 2014, 9:26 p.m.) Status -- This change has been ma

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 6:04 p.m.) Review request for KDE Frameworks and

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

> On July 29, 2014, 4:34 p.m., Bhushan Shah wrote: > > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44 > > > > > > Maybe consider creating it a singleton type? > > Aleix Pol Gonzalez wrote: > Why?

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

> On July 29, 2014, 4:53 p.m., Bhushan Shah wrote: > > src/qmlcontrols/kcoreaddons/kuserproxy.h, line 96 > > > > > > why? nameChanged is not related here.. It's not visible API (the signal visible to QML has the

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

> On July 29, 2014, 10:04 p.m., Bhushan Shah wrote: > > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44 > > > > > > Maybe consider creating it a singleton type? > > Aleix Pol Gonzalez wrote: > Why?

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63459 --- src/qmlcontrols/kcoreaddons/kuserproxy.h

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

> On July 29, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote: > > Can we consider including this in KCoreAddons? > > > > I know KCoreAddons should only depend on QtCore, but then we can make it an > > optional dependency. If Qt5::Qml is there, then build the Qml plugin too. > > Marco Martin wrote:

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

> On July 29, 2014, 4:34 p.m., Bhushan Shah wrote: > > src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp, line 44 > > > > > > Maybe consider creating it a singleton type? Why? In fact, I think it's usually harder

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

> On July 29, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote: > > Can we consider including this in KCoreAddons? > > > > I know KCoreAddons should only depend on QtCore, but then we can make it an > > optional dependency. If Qt5::Qml is there, then build the Qml plugin too. > > Marco Martin wrote:

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63453 --- src/qmlcontrols/kcoreaddons/kcoreaddonsplugin.cpp

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

> On July 29, 2014, 2:33 p.m., Aleix Pol Gonzalez wrote: > > Can we consider including this in KCoreAddons? > > > > I know KCoreAddons should only depend on QtCore, but then we can make it an > > optional dependency. If Qt5::Qml is there, then build the Qml plugin too. KCoreAddons can depend f

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated July 29, 2014, 4:22 p.m.) Review request for KDE Frameworks and

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63443 --- Looks damn good, especially the documentation and example. Mi

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/#review63441 --- Can we consider including this in KCoreAddons? I know KCoreAd

Re: Review Request 119535: Move QML bindings for KUser to kdeclarative

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119535/ --- (Updated July 29, 2014, 2:31 p.m.) Review request for KDE Frameworks and

Re: Review Request 119534: take defaults from a plasma look and feel package, if available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- (Updated July 29, 2014, 1:25 p.m.) Review request for KDE Frameworks and

Re: Review Request 118263: Port polkit-kde-agent to KF5::KDELibs4Support and KF5::IconThemes

> On July 29, 2014, 11:54 a.m., José Manuel Santamaría Lema wrote: > > With the patch as is it doesn't build for me with Qt 5 but I could fix it > > changing this couple of things in the resulting CMakeLists.txt after > > applying the current patch: > > - removing the use of macro_optional_add

Review Request 119534: take defaults from a plasma look and feel package, if available

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119534/ --- Review request for KDE Frameworks and Plasma. Repository: frameworkintegr

Re: Review Request 118263: Port polkit-kde-agent to KF5::KDELibs4Support and KF5::IconThemes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118263/#review63425 --- With the patch as is it doesn't build for me with Qt 5 but I c

Review Request 119530: kcoreaddons: Fix kautosave doesn't work with more than 1 file per application

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119530/ --- Review request for KDE Frameworks and David Faure. Repository: kcoreaddon

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/ --- (Updated July 29, 2014, 9:10 a.m.) Status -- This change has been di

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review63396 --- Is this still useful? - David Edmundson On July 17, 2014, 8