Problems with KFilterDev::deviceForFile method in a KF5 based application

Hello, I'm porting massif-visualizer to Frameworks 5 libs and I'm facing a problem. Basically massif-visualizer is about loading a file generated by massif (from the Valgrind tools) and then displaying nice graphs. The application can handle both plain-text file and gzipped ones. In the KDE4

Re: Review Request 119510: Fix untranslated menu entries

> On Čec. 28, 2014, 8:12 odp., David Faure wrote: > > I don't know about the bcp47 thing, but setting the locale to C is > > definitely definitely wrong. > > > > This line of code in kdelibs4 was saying > > > >// force generating of KLocale object. if not, the database will get > >// b

Re: Review Request 119523: port TextField to QtControls

> On July 28, 2014, 6:54 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/TextField.qml, line 366 > > > > > > This is going to overlap with the text I think. > > It might be worth

Re: Review Request 119523: port TextField to QtControls

> On July 28, 2014, 7:09 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/plasmacomponents/qml/styles/TextFieldStyle.qml, line > > 52 > > > > > > Can't you account for the clear button width here? probabl

Re: Review Request 119523: port TextField to QtControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119523/#review63367 --- src/declarativeimports/plasmacomponents/qml/styles/TextFieldS

Re: Review Request 119523: port TextField to QtControls

On July 28, 2014, 6:54 p.m., Marco Martin wrote: > > Which methods do we need the inner control for? I saw positionAtPos and > > positionToRectangle, any others? > > Marco Martin wrote: > those two and passwordCharacter and missing properties are: passwordCharacter errorHighlight - Davi

Re: Review Request 119523: port TextField to QtControls

> On July 28, 2014, 6:54 p.m., David Edmundson wrote: > > src/declarativeimports/plasmacomponents/qml/TextField.qml, line 366 > > > > > > This is going to overlap with the text I think. > > It might be worth

Re: Review Request 119523: port TextField to QtControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119523/#review63363 --- Even if we fix the methods it's too close to 5.1 to merge righ

Re: Review Request 119510: Fix untranslated menu entries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119510/#review63359 --- I don't know about the bcp47 thing, but setting the locale to

Review Request 119523: port TextField to QtControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119523/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 119510: Fix untranslated menu entries

> On Čec. 28, 2014, 7:56 odp., Aleix Pol Gonzalez wrote: > > src/services/kservice.cpp, line 57 > > > > > > Unrelated change, commit separately. Ok, I'll make sure to split the commit into 2 On Čec. 28, 2014, 7

Re: Review Request 119510: Fix untranslated menu entries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119510/#review63356 --- src/services/kservice.cpp

Re: Review Request 119464: port ToolButton to QtControls

> On July 28, 2014, 4:40 p.m., David Edmundson wrote: > > >The ugly thing here is that QtControls ToolButton doesn't have a flat > > >property, it should probably be upstreamed, at least for compatibility > > >with the qwidgets ToolButton > > > > I can't see a flat property on the widget's too

Re: Review Request 119464: port ToolButton to QtControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/#review63340 --- >The ugly thing here is that QtControls ToolButton doesn't hav

Re: Review Request 119464: port ToolButton to QtControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/ --- (Updated July 28, 2014, 3:50 p.m.) Status -- This change has been ma

Re: Review Request 119464: port ToolButton to QtControls

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119464/#review63337 --- Ship it! Ship It! - David Edmundson On July 25, 2014, 4:52

Re: Review Request 119388: Add KDE Frameworks 5 simple app

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119388/ --- (Updated July 28, 2014, 2:41 p.m.) Status -- This change has been ma

Re: Review Request 119510: Fix untranslated menu entries

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119510/ --- (Updated Čec. 28, 2014, 4:28 odp.) Review request for KDE Frameworks and

Re: Review Request 119512: Fix saving/loading of file dialog sizes

> On Čec. 28, 2014, 12:17 odp., Thomas Lübking wrote: > > src/platformtheme/kdeplatformfiledialoghelper.h, line 53 > > > > > > this will also hit when the window is shaded, minimized or moved to > > another virtu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

On July 28, 2014, 12:17 p.m., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, bu

Re: Review Request 119512: Fix saving/loading of file dialog sizes

On Juli 28, 2014, 10:17 vorm., Lukáš Tinkl wrote: > > If the only issue is the open ::exec() TODO, you might "trick" it by > > calling ::winId(), then restore the size and ultimately ::exec() > > > > Otherwise you could open an own nested eventloop instead of relying on the > > dialogs exec, b

Re: Review Request 119512: Fix saving/loading of file dialog sizes

> On Čec. 28, 2014, 12:17 odp., Thomas Lübking wrote: > > src/platformtheme/kdeplatformfiledialoghelper.h, line 53 > > > > > > this will also hit when the window is shaded, minimized or moved to > > another virtu

Re: Review Request 119513: reintroduce containmentForScreen(int screen, const QString &defaultPluginIfNonExistent, args)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119513/ --- (Updated July 28, 2014, 11:46 a.m.) Status -- This change has been m

Re: Review Request 119513: reintroduce containmentForScreen(int screen, const QString &defaultPluginIfNonExistent, args)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119513/#review63318 --- Ship it! Ship It! - Sebastian Kügler On July 28, 2014, 11:

Review Request 119513: reintroduce containmentForScreen(int screen, const QString &defaultPluginIfNonExistent, args)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119513/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 119512: Fix saving/loading of file dialog sizes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119512/ --- (Updated July 28, 2014, 10:21 a.m.) Review request for KDE Frameworks, kd