Re: Review Request 119331: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119331/ --- (Updated July 18, 2014, 2:51 p.m.) Status -- This change has been ma

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review62657 --- src/declarativeimports/core/framesvgitem.cpp

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/ --- (Updated Juli 18, 2014, 3:34 nachm.) Review request for KDE Frameworks.

Review Request 119356: Create a QtCore only desktoptojson exe based on the one from kservice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119356/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

> On July 18, 2014, 10:54 a.m., David Edmundson wrote: > > src/declarativeimports/core/framesvgitem.cpp, line 121 > > > > > > 1) This leaks. > > if you remove a node from a parent you have to delete it yourse

Re: Review Request 119336: Convert FrameSvg to 9 textures: different approach

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119336/#review62619 --- src/declarativeimports/core/framesvgitem.cpp

Re: Review Request 119349: typo in signal names ( upowermanager )

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119349/ --- (Updated July 18, 2014, 12:58 p.m.) Status -- This change has been d

Re: Review Request 119349: typo in signal names ( upowermanager )

> On July 18, 2014, 12:50 p.m., Lukáš Tinkl wrote: > > Hmm, my upower (and also the newer one) has DeviceAdded/Removed signals... > > how did you come to this conclusion? Have you done any testing? Yes you are right, after making test the result is same. Still getting no such Signal erros in m

Re: Review Request 119349: typo in signal names ( upowermanager )

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119349/#review62638 --- Hmm, my upower (and also the newer one) has DeviceAdded/Remove

Re: Review Request 119345: Port away from deprecated QUrl API

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119345/ --- (Updated July 18, 2014, 9:34 a.m.) Status -- This change has been ma

Re: Review Request 119331: Use CMAKE_INSTALL_FULL_LIBEXECDIR_KF5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119331/#review62636 --- Ship it! Ship It! - Alex Merry On July 17, 2014, 11:01 a.m

Re: Review Request 119323: fix auth race condition

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62631 --- Ship it! I have been using this for 4.x and 5.x for a while w