Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

> On Iulie 12, 2014, 7:58 p.m., Nicolás Alvarez wrote: > > Windows has no concept of an integer UID/GID, it uses much longer SIDs to > > identify users. These are not returned by stat (stat always returns zero in > > the st_uid member). > > > > I would just ifdef away the UDS_USER and UDS_GROU

Re: Translations in frameworks released tarballs

On Wednesday 09 July 2014 11:59:01 Harald Sitter wrote: > On Wed, Jul 9, 2014 at 11:27 AM, Alexander Potashev > > wrote: > > 2014-07-09 2:38 GMT+04:00 David Faure : > >> On Tuesday 08 July 2014 23:24:36 Christoph Feck wrote: > >>> Is it possible to strip them before the archives are packed? Or ca

Re: Review Request 119164: khtml: install kxmlgui .rc files into KXMLGUI_INSTALL_DIR (= share/kxmlgui5)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119164/ --- (Updated July 12, 2014, 9:25 p.m.) Status -- This change has been ma

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/#review62224 --- Windows has no concept of an integer UID/GID, it uses much lon

Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated July 12, 2014, 7:55 p.m.) Status -- This change has been ma

Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)

> On Iulie 12, 2014, 7:33 p.m., David Faure wrote: > > Looks good. > > > > Grepping for S_ISDIR shows that kdelibs4support has some more (but no other > > framework does). The rest is in code the is not compiled on Windows or at least MSVC. - Cristian --

Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated July 12, 2014, 7:49 p.m.) Status -- This change has been ma

Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated July 12, 2014, 7:48 p.m.) Status -- This change has been ma

Re: Review Request 119164: khtml: install kxmlgui .rc files into KXMLGUI_INSTALL_DIR (= share/kxmlgui5)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119164/#review62219 --- Ship it! I checked this patch and the rc files do land in sha

Re: Review Request 119164: khtml: install kxmlgui .rc files into KXMLGUI_INSTALL_DIR (= share/kxmlgui5)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119164/#review62218 --- Ship it! I checked this patch and the rc files do land in sha

Re: Review Request 119198: Don't search default paths when finding lconvert.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119198/#review62214 --- Ship it! Yep, seems sensible to me. We definitely want the lc

Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/#review62213 --- Ship it! Looks good. Grepping for S_ISDIR shows that kdelibs

Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/#review62212 --- Ship it! Ship It! - Alex Merry On July 12, 2014, 7:30 p.m.

Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated Iulie 12, 2014, 7:30 p.m.) Review request for KDE Frameworks and

Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/#review62211 --- Ship it! Please make it one commit for each issue you listed

Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

> On Iulie 12, 2014, 7:26 p.m., Alex Merry wrote: > > src/lib/kaboutdata.h, line 38 > > > > > > Normally, it goes before the return type. It presumably still works > > where you put it, but it looks very odd. Yo

Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- (Updated Iulie 12, 2014, 7:30 p.m.) Review request for KDE Frameworks.

Re: Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/#review62209 --- src/lib/kaboutdata.h

Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated Iulie 12, 2014, 7:25 p.m.) Review request for KDE Frameworks and

Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)

> On Iulie 12, 2014, 6:54 p.m., David Faure wrote: > > Doesn't qplatformdefs.h define this already? > > David Faure wrote: > Ah not exactly, but you can use & QT_STAT_DIR and & QT_STAT_REG. Yeah, that was my other option, I'm going to update the diff. - Cristian

Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated Iulie 12, 2014, 7:15 p.m.) Review request for KDE Frameworks and

Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated Iulie 12, 2014, 7:09 p.m.) Review request for KDE Frameworks and

Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013

> On Iulie 12, 2014, 5:44 p.m., Alex Merry wrote: > > src/kdeui/kapplication.cpp, lines 22-24 > > > > > > Ooh, that's a nasty trap. We should fix this in KCoreAddons, not work > > around it here. Possibly by usin

Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- (Updated Iulie 12, 2014, 7:07 p.m.) Review request for KDE Frameworks.

Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013

> On July 12, 2014, 5:19 p.m., Cristian Oneț wrote: > > src/kio/netaccess.h, line 197 > > > > > > Issue 3: See http://msdn.microsoft.com/en-us/library/t72ahzw1.aspx > > > > Member methods of exported cla

Review Request 119251: Fix a conflict with KCrash where the function is declared as exported

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119251/ --- Review request for KDE Frameworks and kdewin. Repository: kcoreaddons D

Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)

> On July 12, 2014, 6:54 p.m., David Faure wrote: > > Doesn't qplatformdefs.h define this already? Ah not exactly, but you can use & QT_STAT_DIR and & QT_STAT_REG. - David --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/#review62202 --- Doesn't qplatformdefs.h define this already? - David Faure

Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/#review62198 --- Generally seems sensible, apart from the things I noted below.

Re: Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/#review62197 --- src/kdecore/k3resolver.h

Review Request 119249: Discuss fixes for building kdelibs4support on Windows using msvc 2013

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119249/ --- Review request for KDE Frameworks and kdewin. Repository: kdelibs4support

Re: Review Request 119079: Add utility function for loading all plugins from a given dir + easy accessor for metadata

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119079/#review62194 --- I'm generally in favour of this. Other than the issues noted b

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

> On July 12, 2014, 2:01 p.m., Aleix Pol Gonzalez wrote: > > tests/ksycocatest.cpp, line 104 > > > > > > Why does it need a static_cast if we're upcasting? > > Also constructing a shared pointer from the data

Re: Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- (Updated Iulie 12, 2014, 2:20 p.m.) Review request for KDE Frameworks and

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

> On July 12, 2014, 2:01 p.m., Aleix Pol Gonzalez wrote: > > tests/ksycocatest.cpp, line 104 > > > > > > Why does it need a static_cast if we're upcasting? > > Also constructing a shared pointer from the data

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 12, 2014, 2:20 p.m.) Review request for KDE Frameworks and

Review Request 119248: Fix the build of kshorturifilter.cpp Windows (msvc2013 32 bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119248/ --- Review request for KDE Frameworks. Repository: kio Description ---

Re: Review Request 119241: Fix QExplicitlySharedDataPointer usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/#review62182 --- tests/ksycocatest.cpp

Re: Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- (Updated Iulie 12, 2014, 2:01 p.m.) Review request for KDE Frameworks.

Review Request 119247: Fix the build of udsentry.cpp on Windows (msvc2013 32 bits)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119247/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 119242: Fix QExplicitlySharedDataPointer usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119242/ --- Review request for KDE Frameworks. Repository: kio Description ---

Review Request 119241: Fix QExplicitlySharedDataPointer usage

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119241/ --- Review request for KDE Frameworks. Repository: kservice Description ---