Re: [OSX/Qt5/KF5/KDE CI system] - libksysguard currently broken on master branch

2014-07-06 Thread Marko Käning
On 07 Jul 2014, at 00:54 , Aleix Pol wrote: > This was split from kde-workspace, libksysguard is already frameworks. Oh, ok, good to know. I’ve learnt on IRC by now that there’s an OSX backend missing… So perhaps that’s the reason why I met the linker failure. I guess I should post a ticket at bko

Re: OSX/MacPorts KDE CI System: Asking for trouble due to installations outside the expected $DATA_INSTALL_DIR/kf5 directory for khtml and katepart5

2014-07-06 Thread Marko Käning
On 07 Jul 2014, at 00:09 , David Faure wrote: >> I reinstalled ECM, kxmlgui and kate, but I don’t see a folder >> /Library/Application Support/kxmlgui5 but instead this for kate’s install >> root > > I said "if this goes in". It wasn't committed yet, as you can see in RR > 119142. Patience :) D

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

2014-07-06 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61766 --- Ship it! Looks good to me. - Aleix Pol Gonzalez On July 1,

Re: [OSX/Qt5/KF5/KDE CI system] - libksysguard currently broken on master branch

2014-07-06 Thread Aleix Pol
On Sat, Jul 5, 2014 at 11:37 PM, Marko Käning wrote: > When trying to build the current libksysguard (using the 'jenkins' branch) > the CI system ran into this issue: > > --- > > [ 76%] Built target graphicssignalplotterbenchmark > Undefined symbols for architecture x86_64: > "KSysGuard::Proces

Review Request 119152: Do not define QT_DISABLE_DEPRECATED_BEFORE

2014-07-06 Thread Kevin Funk
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119152/ --- Review request for KDE Frameworks and Stephen Kelly. Repository: kdelibs4

Re: Review Request 119142: KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc

2014-07-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119142/ --- (Updated July 6, 2014, 10:09 p.m.) Status -- This change has been ma

Re: OSX/MacPorts KDE CI System: Asking for trouble due to installations outside the expected $DATA_INSTALL_DIR/kf5 directory for khtml and katepart5

2014-07-06 Thread David Faure
On Sunday 06 July 2014 20:20:08 Marko Käning wrote: > On 06 Jul 2014, at 11:41 , David Faure wrote: > > Marko, if this goes in, can you port everything kf5-based to install .rc > > files in KXMLGUI_INSTALL_DIR just like kwrite.diff does for write? > > I reinstalled ECM, kxmlgui and kate, but I do

Re: OSX/MacPorts KDE CI System: Asking for trouble due to installations outside the expected $DATA_INSTALL_DIR/kf5 directory for khtml and katepart5

2014-07-06 Thread Marko Käning
On 06 Jul 2014, at 11:41 , David Faure wrote: > Marko, if this goes in, can you port everything kf5-based to install .rc > files > in KXMLGUI_INSTALL_DIR just like kwrite.diff does for write? I reinstalled ECM, kxmlgui and kate, but I don’t see a folder /Library/Application Support/kxmlgui5 but

Re: Review Request 119142: KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc

2014-07-06 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119142/#review61739 --- Ship it! Ship It! - Alex Merry On July 6, 2014, 3:32 p.m.,

Re: Review Request 119142: KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc

2014-07-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119142/ --- (Updated July 6, 2014, 3:32 p.m.) Review request for KDE Frameworks, Alex

Re: Review Request 119146: Autostart KCM: update env and shutdown paths to GenericConfigLocation + plasma-workspace + [env|shutdown]

2014-07-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119146/ --- (Updated July 6, 2014, 2:43 p.m.) Status -- This change has been mar

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated July 6, 2014, 2:41 p.m.) Status -- This change has been mar

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61724 --- Ship it! You can push it after the two fixes below. startkd

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:46 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:44 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61708 --- startkde/startkde.cmake

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread David Faure
> On July 6, 2014, 1:25 p.m., David Faure wrote: > > I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's > > missing in qtpaths, I'll fix that. > > > > We should be using it, because ConfigLocation includes the appname on > > Windows (big whoops). > > David Faure wrote

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
> On Lug. 6, 2014, 1:25 p.m., David Faure wrote: > > I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's > > missing in qtpaths, I'll fix that. > > > > We should be using it, because ConfigLocation includes the appname on > > Windows (big whoops). > > David Faure wrote

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:35 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 119146: Autostart KCM: update env and shutdown paths to GenericConfigLocation + plasma-workspace + [env|shutdown]

2014-07-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119146/#review61706 --- Ship it! Thanks. - David Faure On July 6, 2014, 1:28 p.m.,

Re: Review Request 119146: Autostart KCM: update env and shutdown paths to GenericConfigLocation + plasma-workspace + [env|shutdown]

2014-07-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119146/ --- (Updated Lug. 6, 2014, 1:33 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
> On Lug. 6, 2014, 1:25 p.m., David Faure wrote: > > I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's > > missing in qtpaths, I'll fix that. > > > > We should be using it, because ConfigLocation includes the appname on > > Windows (big whoops). > > David Faure wrote

Review Request 119146: Autostart KCM: update env and shutdown paths to GenericConfigLocation + plasma-workspace + [env|shutdown]

2014-07-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119146/ --- Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread David Faure
> On July 6, 2014, 1:25 p.m., David Faure wrote: > > I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, but indeed it's > > missing in qtpaths, I'll fix that. > > > > We should be using it, because ConfigLocation includes the appname on > > Windows (big whoops). I mean we should be u

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61701 --- I added GenericConfigLocation to Qt 5.2.0's QStandardPaths, bu

Re: Review Request 119142: KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc

2014-07-06 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119142/#review61699 --- Great to see this progressing, guys! I would like to test it,

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:19 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 119142: KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc

2014-07-06 Thread Alex Merry
> On July 6, 2014, 12:52 p.m., Alex Merry wrote: > > A little concerned that there are no documentation changes as part of this > > patch. Is this stuff noted in the apidocs? > > > > Also, I assume that not changing the behaviour of setXMLFile is a > > deliberate decision. What's the reasoning

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 1:13 p.m.) Review request for KDE Frameworks, Plas

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
> On Lug. 6, 2014, 12:57 p.m., David Faure wrote: > > GenericDataLocation + env is polluting the global namespace. Imagine if > > gnome did the same... > > > > My suggestion is GenericConfigLocation + "/startkde/env/" > > or GenericConfigLocation + "/kde-workspace/env/". > > > > Yes, this mean

Re: Review Request 119142: KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc

2014-07-06 Thread David Faure
> On July 6, 2014, 12:52 p.m., Alex Merry wrote: > > A little concerned that there are no documentation changes as part of this > > patch. Is this stuff noted in the apidocs? > > > > Also, I assume that not changing the behaviour of setXMLFile is a > > deliberate decision. What's the reasoning

Re: kf5-config, startkde and bug 333793

2014-07-06 Thread David Faure
On Sunday 06 July 2014 14:00:18 Luca Beltrame wrote: > Does anyone know the reason? Yes, blind porting :-) > Should we all change them to GenericConfigLocation? Yes. -- David Faure, fa...@kde.org, http://www.davidfaure.fr Working on KDE Frameworks 5 ___

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/#review61694 --- GenericDataLocation + env is polluting the global namespace. I

Re: kf5-config, startkde and bug 333793

2014-07-06 Thread Marko Käning
On 06 Jul 2014, at 14:53 , David Faure wrote: > https://community.kde.org/Frameworks/Epics/Contributions_to_Qt5 That, indeed, is an impressive list! :) ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listi

Re: kf5-config, startkde and bug 333793

2014-07-06 Thread David Faure
On Sunday 06 July 2014 13:25:25 Marko Käning wrote: > On 06 Jul 2014, at 13:19 , David Faure wrote: > > kf5-config is deprecated, qtpaths replaces it. > > Does this mean that KF5 now tries to use as much infrastructure delivered by > Qt5 as possible? (IIRC I saw changes of KIcon to QIcon and alre

Re: Review Request 119142: KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc

2014-07-06 Thread Alex Merry
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119142/#review61693 --- A little concerned that there are no documentation changes as

Re: Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- (Updated Lug. 6, 2014, 12:52 p.m.) Review request for KDE Frameworks, Pla

Review Request 119145: Use qtpaths instead of kf5-confg in startkde

2014-07-06 Thread Luca Beltrame
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119145/ --- Review request for KDE Frameworks, Plasma and David Faure. Bugs: 333793

Re: kf5-config, startkde and bug 333793

2014-07-06 Thread Luca Beltrame
David Faure wrote: > Well, kde4-config --path lib never included ~/.local so that's not really > a bug. It used to include $KDEHOME, on which startkde relied, that's probably the cause of the bug. > Shall we say ~/.config/startkde/env/ ? If that's the case, we have a problem elsewhere. ;) syst

Re: [OSX/Qt5/KF5/KDE CI system] - kate has problem with dynamic linking to phonon

2014-07-06 Thread Marko Käning
On 06 Jul 2014, at 13:25 , David Faure wrote: > On Sunday 06 July 2014 00:08:43 Marko Käning wrote: >> When starting kate or kwrite one gets this error: > > s/one gets/you get/ :-) yep. :) > Just check where libphonon4qt5.4.dylib is installed and whether it's in your > DYLD_LIBRARY_PATH ... or

Re: kf5-config, startkde and bug 333793

2014-07-06 Thread Marko Käning
On 06 Jul 2014, at 13:19 , David Faure wrote: > kf5-config is deprecated, qtpaths replaces it. Does this mean that KF5 now tries to use as much infrastructure delivered by Qt5 as possible? (IIRC I saw changes of KIcon to QIcon and already wondered what’s going on there...) ___

Re: [OSX/Qt5/KF5/KDE CI system] - kate has problem with dynamic linking to phonon

2014-07-06 Thread David Faure
On Sunday 06 July 2014 00:08:43 Marko Käning wrote: > When starting kate or kwrite one gets this error: s/one gets/you get/ :-) It works on linux. The soname is libphonon4qt5.so.4.7.50 so the .4.dylib is fine. Just check where libphonon4qt5.4.dylib is installed and whether it's in your DYLD_LIB

Re: kf5-config, startkde and bug 333793

2014-07-06 Thread David Faure
On Sunday 06 July 2014 11:49:22 Luca Beltrame wrote: > Hello, > > I set out an attempt to fix bug 333793 [1] and to port kf5-config in > kdelibs4support to QCommandLineParser and QStandardPaths where possible. > > The issue in the bug is that kf5-config --path lib misses ~/.local (XDG) > because

Re: Review Request 119126: KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.

2014-07-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119126/ --- (Updated July 6, 2014, 11:10 a.m.) Status -- This change has been ma

Re: Review Request 119126: KMimeTypeChooser: hide Edit button if keditfiletype5 isn't found.

2014-07-06 Thread Christoph Feck
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119126/#review61686 --- Ship it! Ship It! - Christoph Feck On July 5, 2014, 10:30

Re: OSX/MacPorts KDE CI System: Asking for trouble due to installations outside the expected $DATA_INSTALL_DIR/kf5 directory for khtml and katepart5

2014-07-06 Thread Marko Käning
Hi David, On 06 Jul 2014, at 11:41 , David Faure wrote: > Framework-specific yes. But again, take the case of kxmlgui files as an > example. They are loaded by the kxmlgui framework itself, whether they got > installed by a kde framework, a kde app, a non-kde app (= an application not > develo

kf5-config, startkde and bug 333793

2014-07-06 Thread Luca Beltrame
Hello, I set out an attempt to fix bug 333793 [1] and to port kf5-config in kdelibs4support to QCommandLineParser and QStandardPaths where possible. The issue in the bug is that kf5-config --path lib misses ~/.local (XDG) because basePrefixForResource (kstandarddirs.cpp) says (lines 244-250):

Review Request 119142: KXMLGUI: load .rc files from DATADIR/kxmlgui5/component_name/file.rc

2014-07-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119142/ --- Review request for KDE Frameworks, Alex Merry and Kevin Ottens. Repositor

Re: OSX/MacPorts KDE CI System: Asking for trouble due to installations outside the expected $DATA_INSTALL_DIR/kf5 directory for khtml and katepart5

2014-07-06 Thread David Faure
On Saturday 05 July 2014 20:47:13 Marko Käning wrote: > > This is the issue: there isn't just "one vendor". Anyone can build apps on > > top of Qt and KF5. So we can't hardcode a vendor in Qt or KF5 APIs. > > Well, I thought, that the frameworks themselves have a vendor, namely KDE! > System-wide

Jenkins build is back to stable : ktexteditor_master_qt5 #451

2014-07-06 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel