Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

> On June 30, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > PolkitQt-1Config.cmake.in, line 24 > > > > > > Passing the include dir is not needed anymore, given that those will be > > pulled by the targets. > >

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

> On June 30, 2014, 11:43 p.m., Aleix Pol Gonzalez wrote: > > CMakeLists.txt, line 6 > > > > > > Isn't it acceptable to depend on ECM here? not a wise choice. the master branch allows building both the Qt4 & Qt5 v

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

> On June 30, 2014, 8:37 p.m., Christophe Giboudeaux wrote: > > agent/CMakeLists.txt, line 10 > > > > > > LINK_PUBLIC > On June 30, 2014, 8:37 p.m., Christophe Giboudeaux wrote: > > core/CMakeLists.txt, line 13

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61334 --- CMakeLists.txt

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- (Updated June 30, 2014, 11:53 p.m.) Review request for KDE Frameworks, Po

Re: Translations are broken in KF5 apps

>> [: Chusslove Illich :] >> To note additionally, packaging of translations for Frameworks is still >> not resolved (to my knowledge?), so translations are actually not >> released right now. > > [: Albert Astals Cid :] > I see the translations in the tarballs. Why do you say they are not > releas

Re: Translations are broken in KF5 apps

El Dilluns, 30 de juny de 2014, a les 23:18:18, Chusslove Illich va escriure: > > [: Alexander Potashev :] > > What a non-English user can see is, many menu items still appear in > > English while they have translations in *.mo files installed [...] > > One thing I know is still not being translat

Re: Translations are broken in KF5 apps

> [: Alexander Potashev :] > What a non-English user can see is, many menu items still appear in > English while they have translations in *.mo files installed [...] One thing I know is still not being translated, because I didn't implement it yet, is menu names coming from *.rc files. This also h

Translations are broken in KF5 apps

Hi KDE Frameworks devs, I tried to run a couple of KF5-based KDE applications, namely Kate and Konsole (Russian and Ukrainian) and localization there looks very poor, even though from the translators' side the localization packages are complete or almost complete. One of the bugs that has been mo

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- (Updated June 30, 2014, 10:51 p.m.) Review request for KDE Frameworks, Po

Re: KAuth and KF5

On Monday 30 of June 2014 17:31:39 Thiago Macieira wrote: > Em seg 30 jun 2014, às 14:14:10, Milian Wolff escreveu: > > On Monday 30 June 2014 00:05:10 šumski wrote: > > > On Thursday 26 of June 2014 12:14:49 Milian Wolff wrote: > > > > Hey, > > > > > > > > did you run it through valgrind? > > >

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61326 --- agent/CMakeLists.txt

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- (Updated June 30, 2014, 10:28 p.m.) Review request for KDE Frameworks, Po

Re: Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/#review61318 --- The pkgconfig files need to be changed as well. While changing

Re: Review Request 118264: Switch to PolkitQt5-1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118264/ --- (Updated June 30, 2014, 8:31 p.m.) Review request for KDE Frameworks and

Re: Review Request 118264: Switch to PolkitQt5-1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118264/ --- (Updated June 30, 2014, 8:20 p.m.) Review request for KDE Frameworks and

Re: Review Request 118264: Switch to PolkitQt5-1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118264/ --- (Updated June 30, 2014, 8:20 p.m.) Review request for KDE Frameworks and

Review Request 119043: pollkit-qt-1 buildsystem adjustements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119043/ --- Review request for KDE Frameworks, Polkit Qt, Aleix Pol Gonzalez, and Chri

Re: Review Request 118985: KSharedConfig: move mainConfig and wasTestEnabled to the thread storage.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118985/#review61307 --- Ship it! Alright, LGTM. Just one final comment on the final

Re: Review Request 118264: Switch to PolkitQt5-1

> On May 28, 2014, 2:56 p.m., Aurélien Gâteau wrote: > > Building with polkit-qt-1 master (bac771e69887c9253f2b0973f6310810db0061f8) > > fails with this error: > > > > [ 55%] Building CXX object > > autotests/CMakeFiles/KAuthHelperTest.dir/HelperTest.cpp.o > > In file included from > > /home/

Re: Review Request 119005: Make desktoptojson include all values, not just the translated ones

> On June 30, 2014, 4:31 p.m., David Faure wrote: > > This seems wrong to me. QSettings is not a desktop file parser. It will get > > escaping wrong, compared to what the desktop entry spec says. > > > > Isn't the long term solution to write .json files directly anyway? > > Alexander Richardso

Re: KAuth and KF5

Em seg 30 jun 2014, às 14:14:10, Milian Wolff escreveu: > On Monday 30 June 2014 00:05:10 šumski wrote: > > On Thursday 26 of June 2014 12:14:49 Milian Wolff wrote: > > > Hey, > > > > > > did you run it through valgrind? > > > > Here's what valgrind says: > Sounds like a bug in Qt to me, I have t

Re: Review Request 118264: Switch to PolkitQt5-1

> On May 28, 2014, 12:56 p.m., Aurélien Gâteau wrote: > > Building with polkit-qt-1 master (bac771e69887c9253f2b0973f6310810db0061f8) > > fails with this error: > > > > [ 55%] Building CXX object > > autotests/CMakeFiles/KAuthHelperTest.dir/HelperTest.cpp.o > > In file included from > > /home

Review Request 119038: Allow loading KCMs from QT_PLUGIN_PATH subdirectories

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119038/ --- Review request for KDE Frameworks. Repository: kcmutils Description ---

Re: Review Request 119005: Make desktoptojson include all values, not just the translated ones

> On June 30, 2014, 4:31 p.m., David Faure wrote: > > This seems wrong to me. QSettings is not a desktop file parser. It will get > > escaping wrong, compared to what the desktop entry spec says. > > > > Isn't the long term solution to write .json files directly anyway? Okay, after reading the

Review Request 119037: Fix KAuth backend loading

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119037/ --- Review request for KDE Frameworks and Vishesh Handa. Repository: kauth

Re: Review Request 118264: Switch to PolkitQt5-1

> On June 30, 2014, 4:23 p.m., Aleix Pol Gonzalez wrote: > > Hi, > > I tried the patch, it's not building. > > > > [10/64] Building CXX object > > src/CMakeFiles/kauth_backend_plugin.dir/backends/polkit-1/Polkit1Backend.cpp.o > > FAILED: /usr/bin/c++ -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB

Re: Review Request 119005: Make desktoptojson include all values, not just the translated ones

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119005/#review61287 --- This seems wrong to me. QSettings is not a desktop file parser

tagging date

On Tuesday 24 June 2014 14:21:53 Jonathan Riddell wrote: > Sorry for late cancellation but seems I can't chair and I can't find a > replacement. > > Please prepare for final tagging this week, any last binary incompatibility > must be in by the weekend. dfaure will tag for final release on Monday

Re: Review Request 118264: Switch to PolkitQt5-1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118264/#review61286 --- Hi, I tried the patch, it's not building. [10/64] Building CX

Re: Review Request 118985: KSharedConfig: move mainConfig and wasTestEnabled to the thread storage.

> On June 29, 2014, 3:31 a.m., Matthew Dawson wrote: > > I'm not sure about moving the warning about immutable files to only happen > > on the main thread, as it is possible that an application may use it > > KSharedConfig on an alternate thread only. > > > > As this is mainly an optimization,

Frameworks meeting tomorrow 14:00UTC

KDE Frameworks meeting is tomorrow at 14:00UTC (15:00 Edinburgh time, 16:00 Barcelona time) in #kde-devel. 5.0 final tag is due today, exciting times, get those last second fixes in quick! Jonathan ___ Kde-frameworks-devel mailing list Kde-frameworks

Re: Review Request 118960: Add a test to print out KLauncher's autostart files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118960/ --- (Updated June 30, 2014, 12:45 p.m.) Status -- This change has been m

Re: Review Request 118960: Add a test to print out KLauncher's autostart files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118960/#review61279 --- This review has been submitted with commit b82102fec5a0f54669

Re: Review Request 118960: Add a test to print out KLauncher's autostart files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118960/#review61278 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 26, 2014, 2

Re: KAuth and KF5

On Monday 30 June 2014 00:05:10 šumski wrote: > On Thursday 26 of June 2014 12:14:49 Milian Wolff wrote: > > Hey, > > > > did you run it through valgrind? > > Here's what valgrind says: Sounds like a bug in Qt to me, I have to say. Looking at the code, QDBusConnectionPrivate::objectDestroyed lo

Re: KIconLoader problem with KFontInst

On Mon, Jun 30, 2014 at 12:02 PM, Martin Klapetek wrote: > ...or have the icons installed properly (hicolor?) and remove the custom > addAppDir call altogether? Not that I grasp the issue, but if it is a general problem that could have impact on every application using custom icon overloads/addit

Re: qt5 polkit-qt-1 and kdesrc-build

On Sat, Jun 28, 2014 at 5:09 PM, Sune Vuorela wrote: > On 2014-06-27, David Faure wrote: > > > > This question is still open. We're releasing kauth as part of KF5 but > > polkit-qt-1 isn't getting released. > > > > Is there any maintainer for polkit-qt-1? > > > > For that matter, who maintains K

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

> On June 30, 2014, 9:01 a.m., Martin Gräßlin wrote: > > src/kwindowinfo_x11.cpp, line 301 > > > > > > are you sure it's Latin1? Normally string properties are utf8. > > Ivan Čukić wrote: > Well, since those

Re: KIconLoader problem with KFontInst

...or have the icons installed properly (hicolor?) and remove the custom addAppDir call altogether? -- Sent from my Nexus 7 ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/ --- (Updated June 30, 2014, 9:57 a.m.) Status -- This change has been ma

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/#review61264 --- This review has been submitted with commit 5c49d96ecd559c6180

Re: KIconLoader problem with KFontInst

On Monday 30 June 2014, Martin Klapetek wrote: > Maybe the KFontInst shouldn't use KIconLoader::global() and have its own > instance? I think KFontInst should just get away with those personalized icons.. but still seems something is wrong in kiconloader anyways.. -- Marco Martin __

KIconLoader problem with KFontInst

Hi all, there is a weird problem with the kf5 version of the KFontInst kcm module. if you load it from SystemSettings, then going back all icons of systemsettings categories disappear. since kfontinst has some "own" icons, I see it's doing this in KCmFontInst.cpp: KIconLoader::global()->addAppDi

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/#review61260 --- Ship it! Ship It! - Martin Gräßlin On June 30, 2014, 11:12

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

> On June 30, 2014, 9:01 a.m., Martin Gräßlin wrote: > > src/kwindowinfo_x11.cpp, line 301 > > > > > > are you sure it's Latin1? Normally string properties are utf8. Well, since those are UUIDs, it does not make

Re: Review Request 118960: Add a test to print out KLauncher's autostart files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118960/#review61258 --- ping? It's just a test. - Vishesh Handa On June 26, 2014,

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/ --- (Updated June 30, 2014, 9:12 a.m.) Review request for KDE Frameworks, kwi

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/#review61256 --- src/kwindowinfo_x11.cpp

Re: Review Request 119008: Adding QStringList KWindowInfo::activities() method

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119008/ --- (Updated June 30, 2014, 8:22 a.m.) Review request for KDE Frameworks, kwi