Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-29 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118852/#review61241 --- This review has been submitted with commit 55c055470aa4f8e153

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

2014-06-29 Thread Nicolás Alvarez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118852/ --- (Updated June 30, 2014, 1:19 a.m.) Status -- This change has been ma

Re: Review Request 119011: KInit: call setgroups(0, 0) before calling setgid()

2014-06-29 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119011/#review61240 --- Ship it! We did a similar thing in kwallet pam module. - Àle

Re: KAuth and KF5

2014-06-29 Thread šumski
On Thursday 26 of June 2014 12:14:49 Milian Wolff wrote: > Hey, > > did you run it through valgrind? Here's what valgrind says: ==30114== Invalid read of size 8 ==30114==at 0xDF080C1: QDBusConnectionPrivate::disconnectSignal(QHash::iterator&) (qstring.h:814) ==30114==by 0xDF08430: QDBusC

Re: Review Request 118985: KSharedConfig: move mainConfig and wasTestEnabled to the thread storage.

2014-06-29 Thread Matthew Dawson
> On June 28, 2014, 11:31 p.m., Matthew Dawson wrote: > > I'm not sure about moving the warning about immutable files to only happen > > on the main thread, as it is possible that an application may use it > > KSharedConfig on an alternate thread only. > > > > As this is mainly an optimization

Re: Review Request 119005: Make desktoptojson include all values, not just the translated ones

2014-06-29 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119005/ --- (Updated June 29, 2014, 5:59 p.m.) Review request for KDE Frameworks and

Re: Added current release schedule to techbase

2014-06-29 Thread Mario Fux
Am Sonntag, 29. Juni 2014, 12.42:37 schrieb Kevin Ottens: Morning Kevin > > > > And what about the future releases of KF5? Any decisions made? At > > > > least Plasma 5 has a tentative schedule now: > > > > http://techbase.kde.org/Schedules/Plasma_5 > > > > > > I think we should have this in a s

Re: Review Request 118985: KSharedConfig: move mainConfig and wasTestEnabled to the thread storage.

2014-06-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118985/ --- (Updated June 29, 2014, 1:55 p.m.) Review request for KDE Frameworks and

Re: Review Request 118985: KSharedConfig: move mainConfig and wasTestEnabled to the thread storage.

2014-06-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118985/ --- (Updated June 29, 2014, 1:49 p.m.) Review request for KDE Frameworks and

Re: Review Request 118985: KSharedConfig: only write to mainConfig and wasTestModeEnabled in the main thread

2014-06-29 Thread David Faure
> On June 29, 2014, 3:31 a.m., Matthew Dawson wrote: > > src/core/ksharedconfig.cpp, line 83 > > > > > > Thinking more on this, both ways are incorrect. This should instead be > > based on a per thread variable,

Re: Review Request 118985: KSharedConfig: only write to mainConfig and wasTestModeEnabled in the main thread

2014-06-29 Thread David Faure
> On June 29, 2014, 3:31 a.m., Matthew Dawson wrote: > > I'm not sure about moving the warning about immutable files to only happen > > on the main thread, as it is possible that an application may use it > > KSharedConfig on an alternate thread only. > > > > As this is mainly an optimization,

Review Request 119011: KInit: call setgroups(0, 0) before calling setgid()

2014-06-29 Thread Dan Vrátil
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119011/ --- Review request for KDE Frameworks. Repository: kinit Description --

Re: Added current release schedule to techbase

2014-06-29 Thread Kevin Ottens
On Saturday 28 June 2014 13:13:19 Mario Fux wrote: > Am Samstag, 28. Juni 2014, 13.05:09 schrieb Alex Merry: > > Morning Alex > > > > And what about the future releases of KF5? Any decisions made? At least > > > Plasma 5 has a tentative schedule now: > > > http://techbase.kde.org/Schedules/Plasma

Jenkins build is back to normal : plasma-framework_master_qt5 » All,LINBUILDER #602

2014-06-29 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build is back to normal : plasma-framework_master_qt5 » NoX11,LINBUILDER #602

2014-06-29 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel