Re: Review Request 118970: libkeduvocdocument: Remove KDELibs4Support dependency.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118970/ --- (Updated June 28, 2014, 12:57 a.m.) Status -- This change has been m

Re: Review Request 118970: libkeduvocdocument: Remove KDELibs4Support dependency.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118970/#review61117 --- This review has been submitted with commit 693b76ee4528b1bfda

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-06-27 20:59 GMT-03:00 David Faure : > On Friday 27 June 2014 23:01:33 Marko Käning wrote: >> I guess I’ve spotted that one of the frameworks obviously messes up when >> writing to the standard location below “Library/Application Support/“ >> because it omits the trailing slash leading to this

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

> On June 27, 2014, 9:02 p.m., David Faure wrote: > > autotests/kconfigtest.cpp, line 175 > > > > > > So any idea what in here triggers the ICE, more specifically, if it's > > not related to enums? Minimal ICE

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

Hi David, On 28 Jun 2014, at 01:59 , David Faure wrote: > That was one of the kbookmarks autotest. Fixed, thanks for the report. oh, I am glad you spotted that so quickly. Thanks for fixing it right away. Greets, Marko ___ Kde-frameworks-devel mailin

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118852/#review61114 --- autotests/kconfigtest.cpp

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

On Friday 27 June 2014 23:01:33 Marko Käning wrote: > I guess I’ve spotted that one of the frameworks obviously messes up when > writing to the standard location below “Library/Application Support/“ > because it omits the trailing slash leading to this mess-up: > ---

Re: Review Request 118985: KSharedConfig: only write to mainConfig and wasTestModeEnabled in the main thread

> On June 27, 2014, 11:47 p.m., Mark Gaiser wrote: > > src/core/ksharedconfig.cpp, line 91 > > > > > > -- slightly unrelated since it wasn't there before this patch. > > > > } else { > > wasTestMo

Re: Review Request 118985: KSharedConfig: only write to mainConfig and wasTestModeEnabled in the main thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118985/#review61112 --- src/core/ksharedconfig.cpp

Review Request 118985: KSharedConfig: only write to mainConfig and wasTestModeEnabled in the main thread

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118985/ --- Review request for KDE Frameworks and Matthew Dawson. Repository: kconfig

Re: qt5 polkit-qt-1 and kdesrc-build

On Saturday 01 March 2014 17:33:45 David Faure wrote: > > I don't mind adding it - but what about releasing? > > Is anyone taking care of releasing polkit-qt-? > > Or should we make it a framework so I release it with the rest of the > > stuff > > ? Cc'ing some polkit-qt contributors. This questio

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

Hi Ben,Hi Olivier,Hi KF5 devs,Hi folks on KDE-MAC,I finally came up with a patch for QStandardPaths:--MVM2:scripts marko$ ls -l patches/qt5/kf5-qt5/patch-qstandardpaths_mac.cp

Re: Review Request 118962: Add api for setting download widget and dialog title. Helps with bug 336737

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118962/#review61106 --- This review has been submitted with commit c6986ec5b7e55c6327

Re: Review Request 118962: Add api for setting download widget and dialog title. Helps with bug 336737

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118962/ --- (Updated June 27, 2014, 6:17 p.m.) Status -- This change has been ma

Re: Review Request 118962: Add api for setting download widget and dialog title. Helps with bug 336737

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118962/#review61105 --- Ship it! Ship It! - Marco Martin On June 26, 2014, 7:03 p.

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #601

See -- Started by upstream project "plasma-framework_master_qt5" build number 601 originally caused by: Started by remote host 2a01:4f8:160:9363::9 with note: Trigge

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #601

See -- Started by upstream project "plasma-framework_master_qt5" build number 601 originally caused by: Started by remote host 2a01:4f8:160:9363::9 with note: Trig

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/#review61086 --- This review has been submitted with commit 18b6d854a01c010fd5

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #600

See Changes: [notmart] Don't expose color properties in c++ api -- Started by upstream project "plasma-framework_master_qt5" build number 600 originally caus

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #600

See Changes: [notmart] Don't expose color properties in c++ api -- Started by upstream project "plasma-framework_master_qt5" build number 600 originally ca

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/ --- (Updated June 27, 2014, 1:09 p.m.) Status -- This change has been ma

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/#review61085 --- This review has been submitted with commit 6c54fb596d96e697b6

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/ --- (Updated June 27, 2014, 1:07 p.m.) Review request for KDE Frameworks and

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

> On June 27, 2014, 12:24 p.m., David Edmundson wrote: > > src/declarativeimports/core/quicktheme.h, line 179 > > > > > > Doesn't redeclaring a signal in a subclass cause a massive warning at > > runtime? > >

Re: Review Request 118972: Don't have all the Thmeme color properties in the public api

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/#review61082 --- Ship it! Concept seems fine in general. Check my comment befo

Review Request 118972: Don't have all the Thmeme color properties in the public api

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118972/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Added current release schedule to techbase

Morning As I was asked recently why the release schedule of KDE Frameworks 5 is not (yet) on techbase.kde.org I took the liberty to change this: http://techbase.kde.org/Schedules/Frameworks It's link to the main page as well: http://techbase.kde.org/Schedules The content is taken from: http://c

Re: Review Request 118962: Add api for setting download widget and dialog title. Helps with bug 336737

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118962/#review61080 --- +1 from me! src/downloaddialog.h

Re: Review Request 118911: Fix the connection to signal globalShortcutChanged

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118911/#review61070 --- This review has been submitted with commit b23ea08320a59b90eb

Re: Review Request 118911: Fix the connection to signal globalShortcutChanged

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118911/ --- (Updated June 27, 2014, 8:38 a.m.) Status -- This change has been ma

Re: Review Request 118970: libkeduvocdocument: Remove KDELibs4Support dependency.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118970/#review61068 --- The code formatting is quite off. You probably want to run eve