Re: Review Request 118879: Revert to old shell script code for parsing rgb.txt

> On June 23, 2014, 8:28 a.m., Aurélien Gâteau wrote: > > Out of curiosity: why is it necessary to skip colors with spaces? I guess it's a heuristic to remove duplicate entries for same {R,G,B}. However, it doesn't work perfectly, e.g. we have two entries "navy" and "NavyBlue" for the same RGB

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

> On June 23, 2014, 5:29 p.m., Patrick Spendrin wrote: > > autotests/kconfigtest.cpp, line 175 > > > > > > Did you try out whether removing the Flags calls did change something? Yes, my final minimal testcase fo

Re: Review Request 118853: Log name + size of not found icons in debug output

> On June 21, 2014, 11:36 a.m., Christoph Feck wrote: > > What is the status of categorized debugging/logging support in Qt, and how > > do we utilize that in our frameworks? > > > > If we are still simply using uncategorized qDebug(), please commit it. > > Luigi Toscano wrote: > We can us

Re: Review Request 118853: Log name + size of not found icons in debug output

> On June 21, 2014, 9:36 a.m., Christoph Feck wrote: > > What is the status of categorized debugging/logging support in Qt, and how > > do we utilize that in our frameworks? > > > > If we are still simply using uncategorized qDebug(), please commit it. > > Luigi Toscano wrote: > We can use

Re: Review Request 118909: Imply SkipTaskbar and SkipPager depending on Window Type

> On June 23, 2014, 10:08 p.m., Thomas Lübking wrote: > > What about (non override) utility windows (eg. assume Qt would not set > > floating dock override to bring its own titlebar)? > > While kwin (iirc by default) hides them for inactive windows, that's rather > > a feature. > > > > -> By t

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118852/#review60850 --- autotests/kconfigtest.cpp

Re: Review Request 118909: Imply SkipTaskbar and SkipPager depending on Window Type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118909/#review60843 --- What about (non override) utility windows (eg. assume Qt would

Review Request 118909: Imply SkipTaskbar and SkipPager depending on Window Type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118909/ --- Review request for KDE Frameworks, kwin and Eike Hein. Repository: kwindo

Re: Solid situation for 5.0

Hello, On Monday 23 June 2014 17:56:20 Àlex Fiestas wrote: > As many of you know late in the game I started writing some new code to add > much needed asynchronous api to Solid/Power which meant moving the old > deprecate code to kdelibs4Support. > > The new API is done (you can review it on mast

Review Request 118906: Fix dialog's check for isTooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118906/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Solid situation for 5.0

As many of you know late in the game I started writing some new code to add much needed asynchronous api to Solid/Power which meant moving the old deprecate code to kdelibs4Support. The new API is done (you can review it on master, there are 2 CMake options to enable them) and all is left to do

Re: Review Request 118366: Porting keyboard module to Framework5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 23, 2014, 1:46 p.m.) Review request for kde-workspace, KDE

Re: Review Request 118889: Use new Konqui in the about Dialog

> On June 23, 2014, 10:34 a.m., Aleix Pol Gonzalez wrote: > > What about bringing this to VdG? They can come up with a more integrated > > new design for the about dialog. > > > > For the moment, I'm good with just changing the picture, but I wouldn't > > like to leave it there. > > Marco Mar

Re: Review Request 118366: Porting keyboard module to Framework5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review60787 --- Can you please try to generate a proper diff? The one you uplo

Re: Review Request 118889: Use new Konqui in the about Dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60786 --- This review has been submitted with commit 09fc14eda3fa7f378f

Re: Review Request 118889: Use new Konqui in the about Dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/ --- (Updated June 23, 2014, 11:33 a.m.) Status -- This change has been m

Re: Review Request 118889: Use new Konqui in the about Dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60784 --- Ship it! Ship It! - Sebastian Kügler On June 22, 2014, 8:1

Re: Review Request 118889: Use new Konqui in the about Dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60783 --- Sorry for hijacking this review, but I think we need the plush

Re: Review Request 118852: [kconfig] Fix build on Visual C++ 2010

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118852/#review60776 --- Isn't that same uses breaking when using kconfig then? - Alei

Re: Review Request 118889: Use new Konqui in the about Dialog

> On June 23, 2014, 10:34 a.m., Aleix Pol Gonzalez wrote: > > What about bringing this to VdG? They can come up with a more integrated > > new design for the about dialog. > > > > For the moment, I'm good with just changing the picture, but I wouldn't > > like to leave it there. > > Marco Mar

Re: Review Request 118889: Use new Konqui in the about Dialog

> On June 23, 2014, 10:34 a.m., Aleix Pol Gonzalez wrote: > > What about bringing this to VdG? They can come up with a more integrated > > new design for the about dialog. > > > > For the moment, I'm good with just changing the picture, but I wouldn't > > like to leave it there. this comes *f

Re: Review Request 118889: Use new Konqui in the about Dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60772 --- What about bringing this to VdG? They can come up with a more

Re: Review Request 118889: Use new Konqui in the about Dialog

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118889/#review60771 --- Ship it! Ship It! - David Edmundson On June 22, 2014, 8:13

Re: Review Request 118879: Revert to old shell script code for parsing rgb.txt

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118879/#review60754 --- Out of curiosity: why is it necessary to skip colors with spac

Re: KIOAccessManagerFactory and QtQuick2

On Wednesday 14 May 2014 20:06:17 Albert Astals Cid wrote: > El Dimecres, 14 de maig de 2014, a les 12:09:54, Marco Martin va escriure: > > On Tuesday 13 May 2014 18:31:06 Aleix Pol wrote: > > > Hi, > > > I've been getting some error messages [1] from some QML applications and > > > I > > > decided

Re: (UNINTENDED?) installation outside the configured DATA_INSTALL_DIR (was Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts)

On Wednesday 04 June 2014 10:31:28 Marko Käning wrote: > Turns out thought that these aren’t all yet, since two frameworks (khtml & > ktexteditor) actually place their stuff outside of the actually configured > kf5 subdirectory: --- > which is probably unintended! Can this be considered a glitch of