Re: git hooks for reviews mandatory?

On Friday 20 June 2014 01:46:10 Aleix Pol wrote: > On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin wrote: > > Hi all, > > I was thinking, since the policy for committing in frameworks is to always > > asking for a review, what about on repositories under frameworks/* adding > > an > > hook that acc

Re: Building KF5

Hello, On Thursday 19 June 2014 22:30:26 André Wöbbeking wrote: > I wanted to give KF5 a try and followed the instructions from > http://community.kde.org/Frameworks/Building. After Albert told me not to > use Clang most of it compiled without any problem. Actually if it breaks with Clang it shou

Review Request 118842: Add reset function to QImageItem image property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118842/ --- Review request for KDE Frameworks and Plasma. Repository: kdeclarative

Re: git hooks for reviews mandatory?

On Thu, Jun 19, 2014 at 11:21 PM, Marco Martin wrote: > Hi all, > I was thinking, since the policy for committing in frameworks is to always > asking for a review, what about on repositories under frameworks/* adding > an > hook that accepts pushes only if the comment has a REVIEW: line? > > I ha

Re: Building KF5

On Thu, Jun 19, 2014 at 10:30 PM, André Wöbbeking wrote: > Hi, > > I wanted to give KF5 a try and followed the instructions from > http://community.kde.org/Frameworks/Building. After Albert told me not to > use > Clang most of it compiled without any problem. But I had to install these > files >

Re: Review Request 118366: Porting keyboard module to Framework5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/#review60569 --- kcms/keyboard/bindings.cpp

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/#review60568 --- Ship it! (again, with the agreement that the dirlister soluti

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #572

See Changes: [kde] Add notify property to colorGroup -- [...truncated 201 lines...] Scanning dependencies of target plasmaextracomponentsplugin_automoc Scann

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #572

See Changes: [kde] Add notify property to colorGroup -- [...truncated 192 lines...] Scanning dependencies of target -srv-jenkins-workspace-plasma-framewor

Re: Review Request 118841: Add notify to colorGroup property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118841/ --- (Updated June 19, 2014, 10:20 p.m.) Status -- This change has been m

Re: Review Request 118841: Add notify to colorGroup property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118841/#review60567 --- This review has been submitted with commit c317939aba7177077c

Re: Review Request 118841: Add notify to colorGroup property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118841/#review60566 --- Ship it! Ship It! - Marco Martin On June 19, 2014, 9:34 p.

Re: Review Request 118841: Add notify to colorGroup property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118841/#review60565 --- Fixes for me these messages from battery monitor: QQmlExpress

Re: git hooks for reviews mandatory?

2014-06-19 18:21 GMT-03:00 Marco Martin : > Hi all, > I was thinking, since the policy for committing in frameworks is to always > asking for a review, what about on repositories under frameworks/* adding an > hook that accepts pushes only if the comment has a REVIEW: line? > > I have been guilty t

Re: git hooks for reviews mandatory?

Marco Martin ha scritto: > Hi all, > I was thinking, since the policy for committing in frameworks is to always > asking for a review, what about on repositories under frameworks/* adding an > hook that accepts pushes only if the comment has a REVIEW: line? ... or "Reviewed by:" https://communit

Review Request 118841: Add notify to colorGroup property

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118841/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

> On June 19, 2014, 8:42 p.m., David Edmundson wrote: > > Note: The property names don't line up 100% in the merge. > > > > flickableItem has now become contentItem (which is a default property) > > > > All instances in plasma-workspace/plasma-desktop are now updated. > > Kai Uwe Broulik wrote

git hooks for reviews mandatory?

Hi all, I was thinking, since the policy for committing in frameworks is to always asking for a review, what about on repositories under frameworks/* adding an hook that accepts pushes only if the comment has a REVIEW: line? I have been guilty too many times of not respecting that, mostly for no

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

> On June 19, 2014, 8:42 p.m., David Edmundson wrote: > > Note: The property names don't line up 100% in the merge. > > > > flickableItem has now become contentItem (which is a default property) > > > > All instances in plasma-workspace/plasma-desktop are now updated. > > Kai Uwe Broulik wrote

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

> On June 19, 2014, 8:42 p.m., David Edmundson wrote: > > Note: The property names don't line up 100% in the merge. > > > > flickableItem has now become contentItem (which is a default property) > > > > All instances in plasma-workspace/plasma-desktop are now updated. That doesn't matter: "fli

Building KF5

Hi, I wanted to give KF5 a try and followed the instructions from http://community.kde.org/Frameworks/Building. After Albert told me not to use Clang most of it compiled without any problem. But I had to install these files frameworks/kio/src/core/kssl/ksslsettings.h frameworks/ktextwidgets/s

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/#review60561 --- Note: The property names don't line up 100% in the merge. fli

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #571

See Changes: [notmart] position the slider bar at margins -- [...truncated 194 lines...] Scanning dependencies of target KF5PlasmaQuick_automoc Scanning depe

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #571

See Changes: [notmart] position the slider bar at margins -- [...truncated 164 lines...] * KF5GuiAddons (required version >= 4.100.0) * Gettext * KF5I18

Re: Review Request 118366: Porting keyboard module to Framework5

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118366/ --- (Updated June 19, 2014, 6:48 p.m.) Review request for kde-workspace, KDE

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #570

See Changes: [kde] Replace ScrollArea with a QQuickControls ScrollView [kde] Fix typo -- [...truncated 204 lines...] [ 1%] [ 1%] [ 2%] Scanning dependenc

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #570

See Changes: [kde] Replace ScrollArea with a QQuickControls ScrollView [kde] Fix typo -- [...truncated 199 lines...] Automatic moc for target KF5Plasma Au

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #569

See Changes: [notmart] "configure" icon for config dialogs -- [...truncated 201 lines...] Scanning dependencies of target plasmapkg2_automoc Scanning depende

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #569

See Changes: [notmart] "configure" icon for config dialogs -- [...truncated 208 lines...] Automatic moc for target KF5PlasmaQuick Generating moc_plasmapkg.

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/ --- (Updated June 19, 2014, 6:09 p.m.) Status -- This change has been ma

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/#review60554 --- This review has been submitted with commit 66e2b915f6c8bc82b0

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/#review60553 --- Ship it! Ship It! - Marco Martin On June 19, 2014, 6 p.m.,

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

> On Dec. 3, 2013, 8:49 p.m., Sebastian Kügler wrote: > > I really like the idea. I think we should keep our Scroll* components in to > > ease porting, but move away from using it for our own stuff first, and > > then, before a first API promise, revisit if we can remove our own > > implementa

Re: Review Request 114283: Use QtQuickControls ScrollView internally in PlasmaExtraComponents.ScrollArea

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114283/ --- (Updated June 19, 2014, 6 p.m.) Review request for KDE Frameworks and Pla

KGlobalAccel Problems

Hey guys I've been looking into kglobalaccel in order to fix some problems that I was having. I seems to have opened a can of worms. Background Information: KGlobalAccel has 2 kinds of shortcuts - Active Shortcuts and Default Shortcuts. Active Shortcuts are the ones currently in use, whereas the

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #568

See Changes: [notmart] prune ColorRole enum -- [...truncated 193 lines...] Scanning dependencies of target KF5Plasma_automoc Scanning dependencies of target

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #568

See Changes: [notmart] prune ColorRole enum -- [...truncated 216 lines...] Generating plasmaextracomponentsplugin.moc

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #567

See Changes: [notmart] Introduce the ColorScope class -- [...truncated 219 lines...]

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #567

See Changes: [notmart] Introduce the ColorScope class -- [...truncated 174 lines...] Required for tests * KF5CoreAddons -- Configuring done -- Generat

Build failed in Jenkins: ktexteditor_master_qt5 #424

See -- [...truncated 764 lines...] Generating moc_testutils.cpp Automatic moc for target katetextbuffertest Automatic moc for target kateview_test [ 5%] Built target commands_test_automoc Scanning depen

Build failed in Jenkins: ktexteditor_master_qt5 #423

See Changes: [Kevin Funk] Marks: Fix appearance -- [...truncated 806 lines...] Scanning dependencies of target katetextbuffertest_automoc [ 4%] [ 5%] Scanning dependencies of target kateview_t

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/#review60528 --- Ship it! Yep, looks good to me. - Milian Wolff On June 19

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/ --- (Updated June 19, 2014, 2:47 p.m.) Review request for KDE Frameworks and

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #566

See Changes: [kde] Replace incorrect documentation -- [...truncated 198 lines...] Scanning dependencies of target plasmacomponentsplugin_automoc Scanning dep

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #566

See Changes: [kde] Replace incorrect documentation -- [...truncated 213 lines...] [ 4%] Automatic moc for target kded_platformstatus Generating framesvgit

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #565

See Changes: [kde] Don't require mandatory subText in tooltip -- [...truncated 200 lines...] Scanning dependencies of target plasmacomponentsplugin_automoc S

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #565

See Changes: [kde] Don't require mandatory subText in tooltip -- [...truncated 207 lines...] Automatic moc for target plasmacomponentsplugin Automatic moc

Re: Review Request 118838: Don't require mandatory subText in tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118838/#review60514 --- This review has been submitted with commit 21af3f8c817cfd1fb9

Re: Review Request 118838: Don't require mandatory subText in tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118838/ --- (Updated June 19, 2014, 1:11 p.m.) Status -- This change has been ma

Re: Review Request 118838: Don't require mandatory subText in tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118838/#review60512 --- Ship it! Ship It! - Aleix Pol Gonzalez On June 19, 2014, 1

Re: Review Request 118838: Don't require mandatory subText in tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118838/ --- (Updated June 19, 2014, 1:07 p.m.) Review request for KDE Frameworks and

Re: Review Request 118838: Don't require mandatory subText in tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118838/#review60511 --- yeah, the code was wrong, just a small issue on the patch sr

Review Request 118838: Don't require mandatory subText in tooltip

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118838/ --- Review request for KDE Frameworks and Plasma. Repository: plasma-framewor

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #564

See Changes: [notmart] adjust to pixel grid -- [...truncated 192 lines...] Scanning dependencies of target KF5Plasma_automoc Scanning dependencies of target

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #564

See Changes: [notmart] adjust to pixel grid -- [...truncated 173 lines...] * Qt5Test (required version >= 5.2.0) Required for tests * KF5CoreAddons -

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #563

See Changes: [notmart] new shiny icons for kickoff by alake -- [...truncated 218 lines...] Generating plasmaextracomponentsplugin.moc

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #563

See Changes: [notmart] new shiny icons for kickoff by alake -- [...truncated 207 lines...] Automatic moc for target calendarplugin Automatic moc for target

Jenkins build is back to stable : kdelibs_stable #1119

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Jenkins build became unstable: kdelibs_stable #1118

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel