Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

> On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: > > Marco, any chance for a second run of review on that patch? > > Marco Martin wrote: > i still not like this patch.. > > Kevin Ottens wrote: > Should be dropped then? Or it can get somewhere? > Feel free to drop it if you conside

Re: Review Request 118264: Switch to PolkitQt5-1

> On May 28, 2014, 2:56 p.m., Aurélien Gâteau wrote: > > Building with polkit-qt-1 master (bac771e69887c9253f2b0973f6310810db0061f8) > > fails with this error: > > > > [ 55%] Building CXX object > > autotests/CMakeFiles/KAuthHelperTest.dir/HelperTest.cpp.o > > In file included from > > /home/

Re: Review Request 118692: Fix reading of entries for language/country combinations

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118692/#review60336 --- Ship it! LGTM. Just a couple of minor issues, and a couple m

Jenkins build is back to normal : kwidgetsaddons_master_qt5 #82

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Build failed in Jenkins: kwidgetsaddons_master_qt5 #81

See Changes: [christoph] Fix build -- [...truncated 176 lines...] [ 7%] Generating moc_kdatetimeedittest.cpp Generating moc_kdatecomboboxtest.cpp Scanning dependencies of target kcharselectte

Build failed in Jenkins: kwidgetsaddons_master_qt5 #80

See Changes: [christoph] Use standard message box icon size in password dialogs -- [...truncated 164 lines...] Automatic moc for target kwidgetsaddons-kmessagewidgetautotest Automatic moc for

Re: Review Request 118740: Use standard message box icon size in password dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118740/#review60332 --- This review has been submitted with commit 3f58df63f8d9956a9c

Re: Review Request 118740: Use standard message box icon size in password dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118740/ --- (Updated June 17, 2014, 9:16 p.m.) Status -- This change has been ma

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #555

See Changes: [notmart] fix tooltip resize in folderview -- [...truncated 184 lines...] KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_SIP_DIR -- Buil

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #555

See Changes: [notmart] fix tooltip resize in folderview -- [...truncated 190 lines...] == Commencing the Build Scanning dependencies of target KF5PlasmaQu

Re: Review Request 118498: Make ECM language-independent again, but make the tests use C

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/ --- (Updated June 17, 2014, 6:17 p.m.) Status -- This change has been ma

Re: Review Request 118498: Make ECM language-independent again, but make the tests use C

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/ --- (Updated June 17, 2014, 6:17 p.m.) Status -- This change has been ma

Re: Review Request 118498: Make ECM language-independent again, but make the tests use C

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/#review60309 --- This review has been submitted with commit bd22dc73a6da58dea8

Re: Review Request 118498: Make ECM language-independent again, but make the tests use C

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/#review60308 --- This review has been submitted with commit 3afc8f9875979e57cc

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/#review60306 --- I agree with the others, good temporary solution for the API,

Re: Review Request 118725: use renamed .direcory files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118725/#review60304 --- Ship it! Ship It! - David Faure On June 17, 2014, 4:14 p.m

Re: Review Request 118739: Make KSharedConfig thread-safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/#review60298 --- LGTM. Just a couple of minor points, but if you prefer to get

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

> On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: > > Marco, any chance for a second run of review on that patch? > > Marco Martin wrote: > i still not like this patch.. > > Kevin Ottens wrote: > Should be dropped then? Or it can get somewhere? > Feel free to drop it if you conside

Re: Review Request 118690: Introduce a KLocalizedTranslator

> On June 12, 2014, 11:06 p.m., Albert Astals Cid wrote: > > What's the use case? Didn't we have a different way for translating ui > > files? > > Martin Gräßlin wrote: > > What's the use case? > > well as explained in the comment for translating dynamically loaded UI > files. Whe

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

> On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: > > Marco, any chance for a second run of review on that patch? > > Marco Martin wrote: > i still not like this patch.. Should be dropped then? Or it can get somewhere? Feel free to drop it if you consider it a dead end. I prefer that to op

Re: Review Request 118783: Set the normal shortcut when setting the default shortcut as well

> On June 16, 2014, 7:10 p.m., Martin Gräßlin wrote: > > I would like to get the opinion from people who designed kglobalaccel. > > Personally I do not understand what the default shortcuts are for and why > > they are needed. > > > > From reading the documentation my understanding is that you

Re: Review Request 118780: Disable the xcb flush connection workaround for Qt >= 5.3.1

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118780/#review60291 --- Ship it! Ship It! - Kevin Ottens On June 16, 2014, 12:42 p

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118775/#review60290 --- Looks good to me for a "let's get the ABI change in, and impro

Re: Review Request 118775: Make KFileItem a Q_MOVABLE type

> On June 16, 2014, 10:09 a.m., Emmanuel Pescosta wrote: > > src/core/kcoredirlister_p.h, lines 40-42 > > > > > > "using KFileItem::KFileItem;" maybe? > > Frank Reininghaus wrote: > Maybe - I'm always a bit u

Re: Review Request 118614: Make KIO thread-safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118614/#review60288 --- Since there was no problem in QtDBus after all, this patch can

Re: Review Request 118498: Make ECM language-independent again, but make the tests use C

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118498/#review60285 --- Ship it! Looks fine to me. - Kevin Ottens On June 15, 2014

Re: Review Request 118690: Introduce a KLocalizedTranslator

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118690/#review60286 --- Ship it! Independent from the (needed) change for "uic -tr i1

Re: Review Request 118740: Use standard message box icon size in password dialogs

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118740/#review60283 --- Ship it! Ship It! - Kevin Ottens On June 14, 2014, 11:11 a

Re: Review Request 118739: Make KSharedConfig thread-safe

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118739/#review60282 --- Ship it! Looks fine to me. - Kevin Ottens On June 14, 2014

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

> On June 17, 2014, 4:11 p.m., Kevin Ottens wrote: > > Marco, any chance for a second run of review on that patch? i still not like this patch.. - Marco --- This is an automatically generated e-mail. To reply, visit: https://git.reviewb

Re: Review Request 118725: use renamed .direcory files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118725/ --- (Updated June 17, 2014, 4:14 p.m.) Review request for KDE Frameworks and

Re: Review Request 118725: use renamed .direcory files

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118725/#review60279 --- Looks fine to me, I'd like David's opinion on it though. - Ke

Re: Review Request 117974: Some more KArchive examples

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117974/#review60278 --- Ship it! Ship It! - Kevin Ottens On June 6, 2014, 7:15 p.m

Re: Review Request 118538: Add a property containing the real edge a dialog is shown on

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118538/#review60277 --- Marco, any chance for a second run of review on that patch? -

Re: Review Request 118162: Make sure to use the absolute file path for test files.

> On May 16, 2014, 11:49 a.m., Alex Merry wrote: > > This sounds like an issue that needs to be fixed in KArchive... > > Alex Merry wrote: > Where, exactly, were the files appearing? And which files were appearing > there? Any update about that patch? - Kevin --

Re: Review Request 118155: adapt to ecm_add_tests so that tests can be found

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118155/#review60275 --- Patrick, this patch got two ship it, any reason why it's not c

Re: Review Request 117985: frameworks/kjs: add missing man page docbook

> On May 5, 2014, 7:17 a.m., Kevin Ottens wrote: > > IIRC that was intentional as to not have kjs depend on kdoctools. > > Alex Merry wrote: > Hrm. Distros like Debian aren't going to be super-happy about this. And > KJS is officially a porting aid, so I'm not sure bumping it to tier 3 is t

Re: Review Request 118264: Switch to PolkitQt5-1

> On May 28, 2014, 12:56 p.m., Aurélien Gâteau wrote: > > Building with polkit-qt-1 master (bac771e69887c9253f2b0973f6310810db0061f8) > > fails with this error: > > > > [ 55%] Building CXX object > > autotests/CMakeFiles/KAuthHelperTest.dir/HelperTest.cpp.o > > In file included from > > /home

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #554

See Changes: [mklapetek] Remove bad merge leftovers -- [...truncated 209 lines...] Automatic moc for target plasmacomponentsplugin Generating fallbackcompone

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #554

See Changes: [mklapetek] Remove bad merge leftovers -- [...truncated 190 lines...] == Commencing the Build Scanning dependencies of target corebindingsplu

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #553

See Changes: [mklapetek] [calendar import]Set 'today' properly [mklapetek] [calendar import]Fix months capitalization -- [...truncated 200 lines...] Scannin

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #553

See Changes: [mklapetek] [calendar import]Set 'today' properly [mklapetek] [calendar import]Fix months capitalization -- [...truncated 208 lines...] Autom

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #552

See Changes: [mklapetek] [calendar import]Remove useless function -- [...truncated 200 lines...] Scanning dependencies of target plasmacomponentsplugin_autom

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #552

See Changes: [mklapetek] [calendar import]Remove useless function -- [...truncated 174 lines...] * Qt5Test (required version >= 5.2.0) Required for tes

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #551

See Changes: [aleixpol] Ensure that the containment's corona is properly calculated. [aleixpol] Reduce Applet::containment calls [kde] Add icon size "tiny" ---

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #551

See Changes: [aleixpol] Ensure that the containment's corona is properly calculated. [aleixpol] Reduce Applet::containment calls [kde] Add icon size "tiny" -

KF5 Update Meeting Minutes 2014-w25

Hello everyone, This is the minutes of the Week 25 KF5 meeting. As usual it has been held on #kde-devel at 4pm Paris time. Were present: agateau, apol, mgraesslin and myself. * agateau did some kapidox fixes on api.kde.org; * he also fixed a crash in KCMultiDialog; * he also proposed ColumnR

Build failed in Jenkins: plasma-framework_master_qt5 » All,LINBUILDER #550

See -- [...truncated 220 lines...] Generating framesvgitem.moc

Build failed in Jenkins: plasma-framework_master_qt5 » NoX11,LINBUILDER #550

See -- [...truncated 183 lines...] Manually-specified variables were not used by the project: KDE4_BUILD_TESTS LIB_SUFFIX SIP_DEFAULT_SIP_DIR -- Bu

Re: Review Request 118783: Set the normal shortcut when setting the default shortcut as well

> On June 16, 2014, 7:10 p.m., Martin Gräßlin wrote: > > I would like to get the opinion from people who designed kglobalaccel. > > Personally I do not understand what the default shortcuts are for and why > > they are needed. > > > > From reading the documentation my understanding is that you

Build failed in Jenkins: kdelibs4support_master_qt5 #223

See Changes: [scripty] SVN_SILENT made messages (.desktop file) -- [...truncated 609 lines...] Automatic moc for target kshortcuttest Scanning dependencies of target ktabwidgettest_automoc A